Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Departmental officers are now put together, rather than separate, if possible #57685

Merged
merged 16 commits into from Mar 21, 2021
Merged

Departmental officers are now put together, rather than separate, if possible #57685

merged 16 commits into from Mar 21, 2021

Conversation

Mothblocks
Copy link
Member

@Mothblocks Mothblocks commented Mar 13, 2021 •
edited

About The Pull Request

Security officers will now be paired up together in the same department, across departments. This means that, instead of 4 officers being split across 4 departments, there'll now be 2 groups of 2.

Late-join officers will be put into any department with only 1 officer. If none exist, the least populous department will be chosen, with their preference having priority.

Updates the maps to have more spawns for departmental officers. Delta previously had none, and now has some. Fixed a bug where MetaStation's security departmental officer was a supply one instead.

Removes the "random" departmental preference. All security officers are now given a department. The "none" preference still exists, but just to show that you don't care which department you're put into.

Updates the config to comment out SEC_START_BRIG. This is what the configuration was already on live servers.

This is something that should likely be test merged, but it mucks with savefiles. Luckily, the only damage it does is changing random departments to none, so if a TM is reverted, only that will have to be changed.

TODO:

  • Headset and PDA message to security officers about latejoiners being added to their department.
  • Only player sec officers should be assigned to departments.

Why It's Good For The Game

As a security officer, your survival and fun are greatly increased when pairing up with a fellow security officer. I told @ninjanomnom that I believe that departmental security officers present a weird tacit acceptance of splitting up, however. You're essentially encouraged to go your own way. However, I'm not opposed to them either, as I think it can promote teamwork, as you get more access the more separate officers team up.

My solution is to try and encourage, through design, teaming up, while preserving departmental officers. Thus, they now pair up, which is, I believe, a good way to suggest to players to stick by each other. ninjanomnom was interested to see the results.

Changelog

🆑
add: Security officers are now paired up into departments together, rather than separated.
add: DeltaStation now has departmental security officer spawners.
fix: Fixed MetaStation's science officer being marked as supply.
/:cl:

@Mothblocks Mothblocks added the Unit Tests Make sure the stuff that's broken is still broken label Mar 13, 2021
@tgstation-server tgstation-server added Config Update Time to bother the headadmins for three months to get your config applied Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. labels Mar 13, 2021
@Mothblocks Mothblocks added the Fix Rewrites a bug so it appears in different circumstances label Mar 13, 2021
@tgstation-server tgstation-server removed the Fix Rewrites a bug so it appears in different circumstances label Mar 13, 2021
@Mothblocks Mothblocks added the Fix Rewrites a bug so it appears in different circumstances label Mar 13, 2021
@TheVekter
Copy link
Contributor

That's a pretty salient point - sec does tend to be more enjoyable with other people. Does this make it so no sec officers naturally spawn in the brig? If so, we need to make sure each of the offices has enough gear for two people at roundstart.

@Mothblocks
Copy link
Member Author

Mothblocks commented Mar 13, 2021 •
edited

Does this make it so no sec officers naturally spawn in the brig? If so, we need to make sure each of the offices has enough gear for two people at roundstart.

Correct, no officers naturally spawn in the brig.

You bring up a good point, but I'm hesitant about supplying the rooms themselves, as they're prime targets for antags/tiders to try and score loot like sec HUDs. That's not a bad thing, but it makes me uneasy to supply them more than they are now.

If they're not already, then perhaps we can just give the sec HUDs by default, leaving a pair inside for a bad actor.

@TheVekter
Copy link
Contributor

I recall sec not getting HUDs on round start as a purposeful balance thing, but I can't for the life of me remember why.

Either way, you could just put optional stuff like flashbangs, mace, etc. in there and leave out anything they spawn with.

@Mothblocks
Copy link
Member Author

Mothblocks commented Mar 13, 2021 •
edited

I'm going to opt out of that now for the sake of scope, that's a separate balance change. I do understand the concern, though.

I recall sec not getting HUDs on round start as a purposeful balance thing, but I can't for the life of me remember why.

If you can find the source on this, that'd be appreciated! 😄

@Dorsisdwarf
Copy link
Contributor

I'm going to opt out of that now for the sake of scope, that's a separate balance change. I do understand the concern, though.

I recall sec not getting HUDs on round start as a purposeful balance thing, but I can't for the life of me remember why.

If you can find the source on this, that'd be appreciated! 😄

He's thinking of detectives IIRC

@Mickyan
Copy link
Contributor

Mickyan commented Mar 13, 2021

You bring up a good point, but I'm hesitant about supplying the rooms themselves, as they're prime targets for antags/tiders to try and score loot like sec HUDs. That's not a bad thing, but it makes me uneasy to supply them more than they are now.

May be out of scope but I think it would be useful to have the ability to set different job loadouts between roundstart and latejoin, we have a bunch of equipment that's mapped in with the expectation that players will gear up at roundstart but we don't necessarily want every latejoin officer to be fully equipped right out of the arrivals shuttle

Giving a full kit only to roundstart officers would solve the problem of requiring them to make a beeline to the brig to gear up right away without adding a bunch of loot to every security checkpoint

@Mothblocks
Copy link
Member Author

That's definitely possible, and sounds like a nice solution, though I will also consider that out of scope for now.

@Mothblocks Mothblocks marked this pull request as ready for review March 14, 2021 00:46
@TheVekter
Copy link
Contributor

I'm going to opt out of that now for the sake of scope, that's a separate balance change. I do understand the concern, though.

I recall sec not getting HUDs on round start as a purposeful balance thing, but I can't for the life of me remember why.

If you can find the source on this, that'd be appreciated! 😄

He's thinking of detectives IIRC

I was, thanks.

@Mothblocks
Copy link
Member Author

ath's greatest nightmare, he'll have to be with other people :(

@Mothblocks
Copy link
Member Author

why did i say that? did ath make a comment and then delete it

@Mothblocks
Copy link
Member Author

I've been told that security officers need to go to the brig in order to get their security belts already, so I don't think much will change on this front.

@Cyberboss
Copy link
Member

Looked at the code but it's late, I'm tired, and there's a lot of it. Sooo...

@Cyberboss Cyberboss added the Test Merge Candidate You're our unpaid test team label Mar 19, 2021
@Mothblocks
Copy link
Member Author

I'll throw it up on Sybil later then.

LemonInTheDark
LemonInTheDark requested changes Mar 20, 2021
View reviewed changes
Copy link
Member

@LemonInTheDark LemonInTheDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God this is some good documentation

code/modules/client/preferences_savefile.dm Show resolved Hide resolved
code/modules/jobs/job_types/security_officer.dm Outdated Show resolved Hide resolved
code/modules/jobs/job_types/security_officer.dm Show resolved Hide resolved
@Mothblocks
Copy link
Member Author

it didnt crash 🎉

@tgstation-server tgstation-server removed the Test Merge Candidate You're our unpaid test team label Mar 20, 2021
@Cyberboss
Copy link
Member

Bababooey

@Cyberboss Cyberboss merged commit f44c20c into tgstation:master Mar 21, 2021
tgstation-server added a commit that referenced this pull request Mar 21, 2021
@tgstation-server
Automatic changelog generation for PR #57685 [ci skip]
b09d921
@MrMelbert
Copy link
Contributor

nooo ihad testmerge feedback waiting for the round to end rEEEE

github-actions bot added a commit that referenced this pull request Mar 21, 2021
@github-actions
Updating GBP from PR #57685 [ci skip]
6cab00f
@SkyratBot SkyratBot mentioned this pull request Mar 21, 2021
Merged
2 tasks
@MrMelbert
Copy link
Contributor

fuck it
image
image

I was getting PDAs from every seccie that joined, not just seccies to my department. (I was assigned to medical this shift)

@Mothblocks
Copy link
Member Author

Easy fix, I forgot to actually check for the department. I'll get to it when I can, but I'm in the middle of a large PR right now, so can't promise an ETA.

@nickup9 nickup9 mentioned this pull request Mar 21, 2021
Open
MrDoomBringer added a commit to MrDoomBringer/tgstation that referenced this pull request Mar 25, 2021
@MrDoomBringer
Squashed commit of the following:
2cfe481 
commit f9c5f1082e5b0123b9b982d0934efb8617f86ab6
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Mar 25 01:48:36 2021 +0000

    Updating GBP from PR #57910 [ci skip]

commit 64fc4dacdeca53fbd5ffb32611cf5a9c949d4e42
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 18:48:13 2021 -0700

    Automatic changelog generation for PR #57910 [ci skip]

commit 246b4b79e505c308f3aadc4924a55123d5dbead7
Author: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
Date:   Wed Mar 24 19:48:10 2021 -0600

    Adds sticking metallic kitchenware into APCs (#57910)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 3135e4b2074e533903a2da4f75bee57422081ff4
Author: Changelogs <action@github.com>
Date:   Thu Mar 25 00:27:44 2021 +0000

    Automatic changelog compile [ci skip]

commit ab73968296027bf8f9a147d5e699d6a0f217c96b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 22:48:56 2021 +0000

    Updating GBP from PR #57923 [ci skip]

commit 308212b05b735c7c076d0460b4bbee4076cacedf
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 15:48:34 2021 -0700

    Automatic changelog generation for PR #57923 [ci skip]

commit 2e309d4eadf0edbd7f03a67dbcad4d4b01f63f88
Author: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
Date:   Wed Mar 24 16:48:30 2021 -0600

    Adds materials to PDAs (#57923)

    Puts a small amount of iron, glass, and plastic into a PDA 'cause that sort of material usage makes sense to me

commit da640b17216cd098986f7415eacc649e08c45c08
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 22:48:08 2021 +0000

    Updating GBP from PR #57926 [ci skip]

commit 4d8d11b1cb3ccaf606942aecc6af675e06e37c09
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 15:47:48 2021 -0700

    Automatic changelog generation for PR #57926 [ci skip]

commit 3539de20048a8d9bd6e28aee66746a063574f8d2
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Wed Mar 24 17:47:45 2021 -0500

    Makes deadchat control's examine only shows up for ghosts (#57926)

    This PR early returns the on_examine proc for deadchat control if the examiner is not an observer.
    So, only ghosts (deadchat) are allowed to see if something is under deadchat control. Humans don't need to know (or shouldn't know) if deadchat is expanding its reach into the physical realm.

commit af76a48c948885cf365cf8a50737535ed84e6898
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 20:50:29 2021 +0000

    Updating GBP from PR #57924 [ci skip]

commit 5d761e15f8c1941375f9b5b9d069a127dedb0f44
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 13:50:03 2021 -0700

    Automatic changelog generation for PR #57924 [ci skip]

commit 4982b4dbea4fd68d8292da419e5737938278e4ee
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Wed Mar 24 15:49:59 2021 -0500

    Fix plant trash from grown food not inheriting their proper seeds (#57924)

    This PR fixes plant trash not getting the seed from their parent.

    trash_type is a type path, not an instantiated object. istype always fails trying to use it on trash_type. ispath is the correct helper to use here, because it's a type path and not an object.

commit 596bb3560b9557aaab4c983c5ea5380f29819fd6
Author: Rob Bailey <actioninja@gmail.com>
Date:   Wed Mar 24 12:48:42 2021 -0700

    Move a signal that is randomly seperated from others of it's kind (#57914)

    Co-authored-by: actioninja <actioninja@criticalaction.net>

commit 1a0455283b62c2c10b7e6dfdacb278b00491347f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 17:58:25 2021 +0000

    Updating GBP from PR #57535 [ci skip]

commit d38d08597ff060085cab4a93702b09526af9d12d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 10:58:01 2021 -0700

    Automatic changelog generation for PR #57535 [ci skip]

commit 7b52daef41ff7b771cc84aedcdebba82679e684e
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date:   Wed Mar 24 10:57:57 2021 -0700

    Makes stations more airtight (#57535)

    I've gone through delta, meta, and icebox and added some choice windoors, changed some areas around, added some more doors, and changed some other miscellaneous things.

    I'll list the full changes in drop downs, for both our sakes

    Delta:
    <details>
    Splits the central hallway into fore and aft central hallways

    Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of
    medbay and sci

    Adds medbay access locked windoors to the back desk of the medbay reception area

    Adds airlocks to both the upper and lower parts of the main hallway
    </details>

    Meta:
    <details>
    Gives the storage wing another set of firelocks, and two fire alarms. It didn't have any alarms in the first place, so hopefully this helps things

    Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of
    medbay and sci

    Replaces a small bit of the science area with nanite lab, to prevent a breach near xenobio causing fire alarms
    at the front of sci

    Adds a windoor in front of the ORM to block air

    Adds a wall behind a smart fridge in chemistry
    </details>

    Icebox:
    <details>
    Added airlocks between arrivals and the port hallway, and the escape hallway and the starboard hallway

    Added a windoor between the kitchen and the bar
    </details>

    Cuts delta's main hallway in half, with the goal of reducing fire alarm strain. Some thoughts on this would be nice, I don't want to make everything else that uses areas worse just because fire alarms are dumb, and I'm worried that's what I've ended up doing here.

    I've also added the portions of medbay/sci that jut out into the main hallway into the main hallway, I think? I could make these into lobby areas, but I'm not sure if that's appropriate or not.

    Adds a few windoors and airlocks to better section off portions of the station, this should reduce the amount of mass gas spreading that can occur.

    My goal here is to reduce the amount of uninteresting gas movement and make firelocks less hellish when there's a breach

commit 2094d10a34c7eba9cda573b30e5404e540de7431
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 17:57:24 2021 +0000

    Updating GBP from PR #57494 [ci skip]

commit 98b931418d1a057b65c3da7ce6e0b13d32d121f5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 10:57:04 2021 -0700

    Automatic changelog generation for PR #57494 [ci skip]

commit 635079aa982f0f01be53e4e104939b180f1abbf5
Author: Time-Green <timkoster1@hotmail.com>
Date:   Wed Mar 24 18:57:00 2021 +0100

    Adds a plumbing layer manifold (#57494)

    Adds a multilayer plumbing manifold, I also murdered the multilayer duct

    You can now alt-click the plumbing RCD to change the layer it prints. I made a whole thing where right clicking changed the settings and you could use that to change machinery aswell. I even did that with the plunger, it was absolutely beautiful. Anyway that drained the life out of me because apparently there's no attack_obj_secondary and afterattack_secondary ALSO called attack_obj (left click). I just hate whoever made it with intensity

    Plumbing now uses three layers. They should be easier to navigate. I tried to make layer connecting the same as cross-color connecting, but that would take more of my soul then there is to take

commit 463872d402e41affd073a7373a2666619611d8a2
Author: AnturK <AnturK@users.noreply.github.com>
Date:   Wed Mar 24 18:38:16 2021 +0100

    Turns off cache on docker publish action (#57912)

    Maybe it will stop it screaming in pain about missing dependencies.
    Publish action suggests alternative of running this as cronjob to update cached version so if this works but is too slow we can change to that.

commit 7da7cfae8e0a23229fd6fe9851c3ce74136036e0
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 13:15:10 2021 +0000

    Updating GBP from PR #57670 [ci skip]

commit 485a9bf1864cc0ca83ef5526a2ab5b5460e01a22
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Mar 24 06:14:43 2021 -0700

    Automatic changelog generation for PR #57670 [ci skip]

commit f6848c6843c258b77647933a24496550a5551832
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Wed Mar 24 09:14:40 2021 -0400

    Dogs no longer take whatever they're holding/wearing to the grave (#57670)

commit 109617acb0381bdf13cb1e04ae8963025d694e5e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 06:51:08 2021 +0000

    Updating GBP from PR #57909 [ci skip]

commit 1ef2615fc3b80b4aa2da8ba39a4e02b15bd6e959
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 23:50:49 2021 -0700

    Automatic changelog generation for PR #57909 [ci skip]

commit 23757dadc58f479351a4b1c5afb0c50df64bfbef
Author: Kylerace <kylerlumpkin1@gmail.com>
Date:   Tue Mar 23 23:50:46 2021 -0700

    makes holodeck books a holo_effect so they get added to the spawned list (#57909)

commit 030f42c0ed4c0d05a3a943e314f0920d933b55f1
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 03:26:45 2021 +0000

    Updating GBP from PR #57817 [ci skip]

commit 217f47f001cbea872841a93ca7aadb5ff5f2b879
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 20:26:24 2021 -0700

    Automatic changelog generation for PR #57817 [ci skip]

commit 09b9ba6ce6c033a1134eecd9f4ddafc11574b2f1
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Mar 23 20:26:21 2021 -0700

    Highlander + Summon Guns and Magic now uses signals to equip new crewmembers (#57817)

commit 4b49756cc07fe70b3ca6b4ee6c3f2c5d974fa9a5
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 01:20:31 2021 +0000

    Updating GBP from PR #57387 [ci skip]

commit c57943a5e2bc0407e510869aea342b56e8a9cf17
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 18:20:11 2021 -0700

    Automatic changelog generation for PR #57387 [ci skip]

commit fca6c2e2a442a30edaab34661f34b83000f8a006
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Wed Mar 24 02:20:07 2021 +0100

    Replaces use of handle_atom_del() with Exited() in modular computer hardware. And fixes an issue. (#57387)

    Title. The issue being hardware/on_remove() calling /try_eject() even if the holder is being destroyed, which is quirky. I also replaced an instance of /New() with /Initialize() and deleted a troublesome /Destroy().

    handle_atom_del() is awful. Nearly every (minus the storage component; it's a tangled trial of mental gymnastic) behavior implemented there can pretty much be moved to Exited() and it'll work just as fine, if not better against edge cases such as recall spells. But that's not the scope of this PR. I'm here to fix #57161.

commit e16596982159ccfaf3ce30d94c377a7d1abb693c
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Wed Mar 24 01:58:29 2021 +0100

    [s] Fixing an infinite loop exception with Move() (#57895)

commit 1fe83befeca961cfb571a78ef4649dbf51b1f89c
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Mar 24 00:56:51 2021 +0000

    Updating GBP from PR #57898 [ci skip]

commit a8d0fe7db1fc154b3c62084d1a5c87ecd2b3037b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 17:56:25 2021 -0700

    Automatic changelog generation for PR #57898 [ci skip]

commit d067eaaf25fa6f47bf8dd9778d8ecfdb0710dce9
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Wed Mar 24 01:56:22 2021 +0100

    Fixing the undoable experisci arcade experiment. (#57898)

commit 0a6faa62967ec2adf1d4e8563391cff97cb85cf0
Author: Changelogs <action@github.com>
Date:   Wed Mar 24 00:03:42 2021 +0000

    Automatic changelog compile [ci skip]

commit 8080a5132ca5ac01340b0563acf98bf11917e42b
Author: Aleksej Komarov <stylemistake@gmail.com>
Date:   Wed Mar 24 01:35:19 2021 +0200

    tgui: ESLint and VSCode settings improvements (#57905)

        Added column 80 rulers to all javascript and scss files.
        Added a "prettier" config to have sensible defaults for those who prefer to use it.
        Added RadarJS (fork of SonarQube's SonarJS). Launchable only via bin/tgui --lint-harder for now.
        Disabled ESLint rule for parens around arrow function arguments, because in TypeScript they're pretty much always required, and I don't want to replace it throughout the codebase.
        Removed unused javascript extensions from tooling (jsx, mjs).

commit 92805c7a62bf2fb22864ce5ac726b8d80c94b74f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 17:44:00 2021 +0000

    Updating GBP from PR #57892 [ci skip]

commit 220775d8763feae9b89a964f051d47d6da9890dc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 10:43:37 2021 -0700

    Automatic changelog generation for PR #57892 [ci skip]

commit ee427897e25af3c40c6bef144530a29a57d806ae
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Mar 23 13:43:34 2021 -0400

    Fixes unbalanced flyperson leg (#57892)

    One of Flypeople's legs while facing up is missing a single pixel, causing it all to be unbalanced, this fixes that.

commit b4f2b7a71f19dddef1e00dee72927543cb8667df
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 17:42:53 2021 +0000

    Updating GBP from PR #57891 [ci skip]

commit 04801bc398d03b2b7a3b4accb70fc06fe518f80b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 10:42:30 2021 -0700

    Automatic changelog generation for PR #57891 [ci skip]

commit 1a271393bfadacce7eee2b978bfbd1bd5e71d3a1
Author: TheVekter <TheVekter@users.noreply.github.com>
Date:   Tue Mar 23 12:42:26 2021 -0500

    Ghosts can now interact with the crew monitor console. (#57891)

commit 2a732ff0c2b38c7eb9bf66a9bd5b08830ef0f51e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 17:41:31 2021 +0000

    Updating GBP from PR #57890 [ci skip]

commit a0d20e5c06f71f87830f42ab926f50cd2fb2d8b3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 10:41:04 2021 -0700

    Automatic changelog generation for PR #57890 [ci skip]

commit c0ad950def44a7a43ba14b0666ade4d4da8650de
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Tue Mar 23 13:41:00 2021 -0400

    Fixes admin immovable rods not hitting things (#57890)

    Timber did an oopsie in #57850 and made it so rods with a specific target (AKA any spawned by admins either through the trigger event button or the admin smite) quit out of their creation before they started listening for clonging things. Possibly this was partly intended, in case you wanted to spawn a rod that would only hit whatever you designated as your target and nothing else, but this current setup doesn't hit the target either soo something needs fixing.

    @Timberpoes let me know what you think and if you were intending for a soft rod option that would only hit the target.

    Fixes: #57888

commit 597bb8ac9f7c89e01fd82487a39ef4d018f0ffaa
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 09:55:58 2021 +0000

    Updating GBP from PR #57772 [ci skip]

commit fa4a36c532f6e1fa9b7d59912d789e10423b45a5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Mar 23 02:55:36 2021 -0700

    Automatic changelog generation for PR #57772 [ci skip]

commit 3ad077eb704271f9dd4d4e5fc9abb5a15e1f059c
Author: MLGTASTICa <61350382+MLGTASTICa@users.noreply.github.com>
Date:   Tue Mar 23 11:55:33 2021 +0200

    i shot my own phazon to death and i cry. (#57772)

    Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com>

commit c5675e40e2bea4916eb208cce901c0440fa9904f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 06:55:49 2021 +0000

    Updating GBP from PR #57415 [ci skip]

commit 732bb677c21628a4e42844b38f99dde36cbdce7c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 23:53:49 2021 -0700

    Automatic changelog generation for PR #57415 [ci skip]

commit ee59c16637cf06e7412eb496d4097b2a94561fad
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Mar 23 07:53:46 2021 +0100

    Ice cream revamp: Ice cream is a component and cones can hold multiple servings of ice cream now. (#57415)

    * Ice cream rework WIP

    * I'm done!

    * i'll deal with my verbose engrish at a later date. I'm dead tired.

    * linter aaaaaa

    * Take a bite!

    * FINALLY, A COMPONENT!

    * ghost macro.

    * Review, typos, beheading of a lame comsig.

    * Typo. Now I'm self-obliged to test it again.

    * It works.

commit a0968acc3846bd7b1fef50946aa25f4827860624
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 03:38:35 2021 +0000

    Updating GBP from PR #57881 [ci skip]

commit a96ff807bc902d8fd612909338409b9c725f9242
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 20:38:15 2021 -0700

    Automatic changelog generation for PR #57881 [ci skip]

commit f599d3e600bdaebeec540ade1a4de4998885ea76
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Tue Mar 23 04:38:11 2021 +0100

    Adds right-click support to AIs/Cyborgs (#57881)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 0c44a627123c95426d863eeb3b6b44919c920672
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Mar 23 03:58:36 2021 +0200

    Bump pillow from 7.2.0 to 8.1.1 in /tools (#57906)

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 7.2.0 to 8.1.1.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst)
    - [Commits](https://github.com/python-pillow/Pillow/compare/7.2.0...8.1.1)

    Signed-off-by: dependabot[bot] <support@github.com>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 98e03e575b0f4efc7b3fcabaa922bae574fbfb33
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 23 00:30:15 2021 +0000

    Updating GBP from PR #57612 [ci skip]

commit 355bbf336e208effb5e003671b0d738ad296e561
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 17:29:55 2021 -0700

    Automatic changelog generation for PR #57612 [ci skip]

commit b5a9002a5e8d16857aa2823432203fdc6f6d1af8
Author: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Date:   Mon Mar 22 20:29:51 2021 -0400

    Defines the interrogation room as unique area and not 4 different var edits. (#57612)

    * Defines the interrogation room as unique area and not 4 different var-edits

    * Fixes the gaping hole in the wall

    * We added a new map at the very end.

    * Blaseball

    * Committing the changes

    * Rebuilds the deltastation setup in case it's actually breaking something...

commit 8322bee316cac01808b8b1512e593d2c8a90967b
Author: Changelogs <action@github.com>
Date:   Tue Mar 23 00:03:37 2021 +0000

    Automatic changelog compile [ci skip]

commit 598cd0c268c97e156b504e78694ee07cd1f8707c
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 23:35:15 2021 +0000

    Updating GBP from PR #57861 [ci skip]

commit e6573da7dcacb6b917574ef2a075903449321d04
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 16:34:53 2021 -0700

    Automatic changelog generation for PR #57861 [ci skip]

commit 8811bc3ac06d76adf37ac2ab0d1ab87bf7577b84
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Mon Mar 22 23:34:50 2021 +0000

    Simple bots now use a different snowflake method for all access. (#57861)

commit 6f52c2be616e41550c46350901d38b3a292dcdea
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 22:23:48 2021 +0000

    Updating GBP from PR #57626 [ci skip]

commit 736ae8d4f5226d43c9cf16d9b7af8a72d6222cc3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 15:23:26 2021 -0700

    Automatic changelog generation for PR #57626 [ci skip]

commit f3946541eb1abdfd44e582d0beb66c2d62c10125
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Mon Mar 22 23:23:22 2021 +0100

    Minor vehicle tidying 2 (#57626)

    Moving some code, using tool procs, nothing special

commit f21323ac502d0034560a327e364ed812ddd49c7b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 20:11:15 2021 +0000

    Updating GBP from PR #57580 [ci skip]

commit 7a78d3dd966c809c30ed0ffe2ea10c0e53dac39c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 13:10:53 2021 -0700

    Automatic changelog generation for PR #57580 [ci skip]

commit 6121b13b942392e4c2c62d1f1b14eed18f6aa527
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Mon Mar 22 21:10:49 2021 +0100

    Bluespace gas vendor (#57580)

    * vendor

    * more

    * fex

    * reeee

    * WIP vendors

    * BIGGERING AND FIGURING MORE BIGGERING

    * CAPITALYSM!!

    * ops

    * tank refilling

    * not working yet

    * sprites and construction

    * some stuff

    * docs

    * maps

    * requested changes

    * more changes

    * change

    Co-authored-by: tralezab <spamqetuo2@gmail.com>

commit d194ca0880af420acd1ed033a30a49d98327cd38
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 17:39:16 2021 +0000

    Updating GBP from PR #57873 [ci skip]

commit 5c279a1bc5dbf1d7be5ad221fc83c6feace3e5d5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 10:38:53 2021 -0700

    Automatic changelog generation for PR #57873 [ci skip]

commit 326f78927f965f14cd2d0eab297481d98685cb64
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Mon Mar 22 13:38:49 2021 -0400

    Fixes simple bots wrongfully failing to path (#57873)

    In #56780 I thought it'd be fine to change the get_path function to return null if there was no path found instead of an empty list, but apparently quite a lot of code in simple bots expects empty lists and freaks out if path is just null, causing simple bots to occasionally fail to respond to summoning even if a path is clearly found and briefly assigned

    This undoes that

commit 30b1d8255342a4bb80c8c2375c112faf53dae53f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 10:38:06 2021 -0700

    Automatic changelog generation for PR #57871 [ci skip]

commit aec6fa9db7cf0855407f9ba0269ed7abc986a19c
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon Mar 22 12:38:02 2021 -0500

    Adds logging / admin messages to midround syndicate sleeper agent (#57871)

    This PR adds a log and an admin message to the syndicate sleeper agent.

    All the other midround rulesets make themselves known when they trigger and execute. Even latejoin syndicate infiltrator messages admins when it fires. This makes midround traitors more obvious when they spawn to admins, which is useful.

commit 1d865bf8a66d329a2a75d702963391590b5e1030
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 17:37:15 2021 +0000

    Updating GBP from PR #57876 [ci skip]

commit e4ce8511b7575136a38272bce82647c0cad602a4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 10:36:51 2021 -0700

    Automatic changelog generation for PR #57876 [ci skip]

commit 0fe1b8ce6622e4b7b599d6afcb302bf04f36e239
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Mon Mar 22 10:36:47 2021 -0700

    Fixes broken CQC area on Icebox (#57876)

commit ba5f155bd8daa96045ee57c0708aa186515b97b7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 10:36:15 2021 -0700

    Automatic changelog generation for PR #57880 [ci skip]

commit a96a011712f1b955cd8dda972f74a165f35a5723
Author: Fikou <piotrbryla@onet.pl>
Date:   Mon Mar 22 18:36:11 2021 +0100

    fixes mouse override icon on supplypod launchers (#57880)

commit bda13b9ee06e378340a876bd5bb6038d456c6721
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 14:42:30 2021 +0000

    Updating GBP from PR #57831 [ci skip]

commit de68ee8b193ec6c7a58296814e06dc3fd19f90a6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 07:42:07 2021 -0700

    Automatic changelog generation for PR #57831 [ci skip]

commit 5625e511960853f1fc925a0017ddc88c4ac166ab
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Mon Mar 22 15:42:01 2021 +0100

    Thermomachine rework (#57831)

    * heat pump rework

    * f

    * efficiency

    * powe

    * powermess

    * better math

    * math and enviroment equation

    * freezers connected to waste pipenet and co2 recircled in waste

    * smol

    * rotate danger

    * upgrades

    * minor tweaks

    * requested changes

commit 2ed6461804021bfc8729965f930ae3035cbc78e8
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 13:11:45 2021 +0000

    Updating GBP from PR #57852 [ci skip]

commit 5cfd03561d566122a952e048ec69a44f27a6e89c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 06:11:17 2021 -0700

    Automatic changelog generation for PR #57852 [ci skip]

commit 2ab7ed31c657b867133fe0c1149ec25983ea51e1
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Mon Mar 22 10:11:13 2021 -0300

    New biosuit hood object sprites (#57852)

    imageadd: New bio hood sprites.

commit ede8d5e67a85dc46fa6c3b782d344e6ac252abc5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 03:01:46 2021 -0700

    Automatic changelog generation for PR #57877 [ci skip]

commit 47a03f6bccb74d493ff0f84f0851dd3398d8b1d0
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Mar 22 03:01:42 2021 -0700

    Sec officers now only get PDA'd if the new member is of the same department (#57877)

    Fixes #57869 - Sec officers now only get PDA'd if the new member is of the same department

commit 302f7e392f3fef0d420befb2e6c7b722fd98e995
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 09:13:37 2021 +0000

    Updating GBP from PR #57864 [ci skip]

commit b51321a07025c1966ed4df28f102bd7034f6f811
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 02:13:12 2021 -0700

    Automatic changelog generation for PR #57864 [ci skip]

commit 3be92b1a74294719d5504f38b0a4660ba78d0780
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon Mar 22 04:13:09 2021 -0500

    Fixes items in toilet cisterns being deleted / null'd on deconstruction (#57864)

    * banished

    * drop loc

commit b35949269195fbb745c59c5b79f466bb32fa2cfe
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 09:09:40 2021 +0000

    Updating GBP from PR #57878 [ci skip]

commit 2f0a064853536580727602221d2da1903b704d9e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 02:09:17 2021 -0700

    Automatic changelog generation for PR #57878 [ci skip]

commit ae00b68fdd79de06febd8b720a6c68ce505603b9
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon Mar 22 04:09:13 2021 -0500

    Autodocs the slippery component + changes the hardcoded slot whitelist to a variable (#57878)

commit 2c91edea13df6df140c2602ee1ed3753831b62c4
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 09:08:22 2021 +0000

    Updating GBP from PR #57859 [ci skip]

commit 2c4c27db6a54e9ad5d65fabedad70e626d42dbed
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 02:08:00 2021 -0700

    Automatic changelog generation for PR #57859 [ci skip]

commit 161c65051ce3f3e72857e1774446ec9219de1d5a
Author: Thalpy <33956696+Thalpy@users.noreply.github.com>
Date:   Mon Mar 22 09:07:56 2021 +0000

    Speeds up drink reactions bringing them back to near instant. (#57859)

commit 0bbeca36ee67eeef15d711a7a61ca6ad4370b556
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Mar 22 00:38:58 2021 -0700

    Automatic changelog generation for PR #57835 [ci skip]

commit 3b91692a69ffda73544f87e5ba1917177c76ec4a
Author: bloons3 <bloons3@users.noreply.github.com>
Date:   Mon Mar 22 02:38:55 2021 -0500

    Adds Sec timer logging (#57835)

commit 8ee88a5e9ce8048fe9f0e62293c5cb9d5010d861
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 05:15:15 2021 +0000

    Updating GBP from PR #57882 [ci skip]

commit a0c6c7e39200aba9df40f8e31eb8423912822179
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 22:14:50 2021 -0700

    Automatic changelog generation for PR #57882 [ci skip]

commit f116289e671e50f4bbd3a7dba5e2e7ad88c908ba
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Mon Mar 22 05:14:47 2021 +0000

     Fixes not being able to open inactive ticket browser on admin ticket tab. (#57882)

    About The Pull Request

    Currently admins can't access the ticket logs for Resolved, Disconnected, Closed and Active tickets due to an early return that will block these from being opened in 100% of circumstances.

    Clicking on the Active/Disconnected/Closed/Resolved tickets would have behaviour handled by /datum/admin_help_tickets/proc/BrowseTickets() which was reached through Click() calls.

    image

    When we call .Click() from topic calls, we provide a null var for the control parameter.

    This then leads through to /client/Click() where #57084 added a bunch of if(!control) checks supposedly ported from TGMC (or at least Fikou couldn't explain why we changed that).

    I can't find a single instance of us using this locally, it appears it's always passed through to Byond. Byond docs at http://www.byond.com/docs/ref/#/client/proc/Click describe it as control - the name of the skin control involved

    I can't see any reason to early return if control is a FALSE-y value. This check is what was blocking access to the admin_help_tickets datum.

    In testing, removing these checks restored previous functionality.
    Why It's Good For The Game

    Admins less triggered.
    Changelog

    🆑
    fix: Admins can once again open the stat panels to look at active, disconnected, closed and resolved tickets.
    /🆑

commit c2cf32c71d7f6619afaf58a5b7317547cc325c69
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Mar 22 00:26:52 2021 +0000

    Updating GBP from PR #57824 [ci skip]

commit 000e470e3bd4c56aa8b1d795aa034c62cd5ac4e5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 17:26:32 2021 -0700

    Automatic changelog generation for PR #57824 [ci skip]

commit 0230e7c7adbbdd8342707058e2d5bd6d0059bcf2
Author: Y0SH1M4S73R <legoboyo@earthlink.net>
Date:   Sun Mar 21 20:26:28 2021 -0400

    Mind magnification helmets once again fall off monkeys when they are humanized (#57824)

    * Fixes mind magnified monkey humanization

    * Update helmet.dm

commit 83601865da2e8967b614677c99e62a678d81e9b0
Author: Changelogs <action@github.com>
Date:   Mon Mar 22 00:08:33 2021 +0000

    Automatic changelog compile [ci skip]

commit 274797d4107a3afd99b14f6b16a5d8c7d6134470
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 16:30:44 2021 -0700

    Automatic changelog generation for PR #57775 [ci skip]

commit 90ed4672a6526afbdad2d8a0cc0bf6b0cc963690
Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Date:   Sun Mar 21 16:30:41 2021 -0700

    tgui: Vote Panel (#57775)

    This upgrades the voting panel to TGUI which makes it much more user friendly and adds some new functionality:

    - Users can now change votes
    - The screen no longer scrolls to top when someone else votes
    - Admins can see ckeys of users with the voting window open
    - Fancy icons and vote tallies in a much better format
    - Map list is now shuffled.
    - All the old functionality remains for custom votes, etc.

    Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
    Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

commit f2e528553591a215dba50e5fe27e92d1d32ff2b4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 15:40:28 2021 -0700

    Automatic changelog generation for PR #57766 [ci skip]

commit e9880251e477affdaefbbbc8220e27133b80e473
Author: Cimika/Lessie/KathyRyals <65850818+KathyRyals@users.noreply.github.com>
Date:   Sun Mar 21 23:40:25 2021 +0100

    Added the N.E.R.D. (Nanotrasen Emergency Response Drone) team as an admin ERT. (#57766)

    Added the ability to call a Nanotrasen Emergency Response Drone Team in the Create Antagonist.

commit a22205995a1eab1b86aca8ef804c92bea53aea42
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Sun Mar 21 22:11:27 2021 +0000

    Fix (#57884)

commit f6f22a878b34d08b2c2f3ef7b2442278d46bb447
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 21:45:59 2021 +0000

    Updating GBP from PR #57804 [ci skip]

commit f4cf997beb696bde76756472df660ed534fac038
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 14:45:32 2021 -0700

    Automatic changelog generation for PR #57804 [ci skip]

commit 660b71dbcd4abbe275034272a47e2dc54af6ccb8
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Sun Mar 21 18:45:29 2021 -0300

    Splits Wintercoats into their own code file. Engineering wintercoats can now hold a gas analyzer like Science ones can. (#57804)

    Me again, moved wintercoats code from suit/miscellaneous into suit/wintercoat
    24 wintercoats, likely something that might get new ones added in the future since some jobs still don't have theirs and I might move their icon files to their own file too to make it easier for future additions once this is added.

    Moved some lines around, added a small tag before each suit because it was hard to read where one start and the other ends, yadda yadda yadda...

    Now do you think this is over? Nooooo... I started to move this around because I, as Atmostech, want to hold a gas analyzer in the exo slot, like those guys at science (And medical for some reason???) can!!

    Might need some rebalancing on what each can hold but that is for later.

commit e4a855a6cdd29d8e1d5272c9fbc94add22bb3cab
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 21:43:11 2021 +0000

    Updating GBP from PR #57856 [ci skip]

commit cdd2a80e75ead1c5f3a393e505cf91deb2807cec
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 14:42:51 2021 -0700

    Automatic changelog generation for PR #57856 [ci skip]

commit 493b8b45dad9bcb8dbdeeb11a5862ec4e1b27fc7
Author: Hadzabadza <hadzabadza@yandex.ru>
Date:   Sun Mar 21 21:42:49 2021 +0000

    Reverts tk_range for movable atoms to 10 (#57856)

    Now that #57700 is merged, this PR reverts the TK range for movable atoms (machinery, lockers, crates) from "as good as removed" back to useful.

commit 6f328da952eb222cdb255eeed478fd7839a92915
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 21:19:03 2021 +0000

    Updating GBP from PR #57803 [ci skip]

commit 5b49e9c08b24f51bf2733258690d5a8017f6c026
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 14:18:41 2021 -0700

    Automatic changelog generation for PR #57803 [ci skip]

commit d633c322ac0bda5a279d03fcb9df82014efb01c6
Author: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Date:   Sun Mar 21 17:18:38 2021 -0400

    Fixes an infinite credit exploit that got overlooked. (#57803)

    So, turns out when assigning values to crates, a good number of the "large object" crates all have multiples of their export, and that didn't get assessed when giving them their current values. As it is currently, you can make infinite credits by ordering some select crates. This adjusts their prices to make them not do the bad, and work in-line with similar crates that sell lower than their buy value.
    Also, fixes an issue with liquid tanks having a component of their sell value not tied to the defined, which was completely glossed over in the price rework, and is now scaled to the correct current value.(500 cr crates -> 200 cr crates).

commit 9a423f3f63f2078d38f360fcb7d3cc51ca83c6d6
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 21:14:13 2021 +0000

    Updating GBP from PR #57860 [ci skip]

commit dd013e5fc18b1e094e3ff78a79cc02db74c47d0e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 14:13:49 2021 -0700

    Automatic changelog generation for PR #57860 [ci skip]

commit 7d59802f74a6ea7625ed309756807cbec0c21329
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date:   Sun Mar 21 14:13:46 2021 -0700

    Removes nationality tags from restaurant customer bot names (#57860)

    Removes the "Space-American" and similar tags from customer bot names.

    The robots have unique sprites and sounds, and themed names and chat lines. These tags aren't really necessary and pretty much just ruin the joke by telling the punchline.

    Also, "Space-<Earth Country>" is dumb.

commit dc9cef40447ee86c2b9fff9f690385cd63b655fa
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 13:09:20 2021 +0000

    Updating GBP from PR #57833 [ci skip]

commit 4f458664c1965c695445d9c4f913163dec1467a4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 06:09:02 2021 -0700

    Automatic changelog generation for PR #57833 [ci skip]

commit 96b52ae9927ce82f8eeb3534bf2861ca325267b4
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Sun Mar 21 06:08:58 2021 -0700

    Adds brig area to Tram Emergency Shuttle (#57833)

commit faae6eb51689cd3d8b933d7358143b1acc186b34
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 13:08:16 2021 +0000

    Updating GBP from PR #57844 [ci skip]

commit 8450c4d83ce9bb6221024f340cadbead1da1bb3f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 06:07:57 2021 -0700

    Automatic changelog generation for PR #57844 [ci skip]

commit d71ce02c98d261a0d85a0c7b37702c3040190b4f
Author: Emmett Gaines <ninjanomnom@gmail.com>
Date:   Sun Mar 21 09:07:54 2021 -0400

    Makes cargo canister listings get automatically generated at runtime (#57844)

commit e629ec95d112cd1a35bba26c95ea5e270906cf61
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 13:02:49 2021 +0000

    Updating GBP from PR #57853 [ci skip]

commit fb137c3d05627c8728ec25323b29d3befd14ded3
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Sun Mar 21 14:02:26 2021 +0100

    Prevent augur deletes (#57853)

commit 62664ac0ce3910394c6f1fdc072e83ade0b60b13
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 13:00:59 2021 +0000

    Updating GBP from PR #57839 [ci skip]

commit b6d2e348169ace4c51b801b7a73a9d0ef9427236
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 06:00:39 2021 -0700

    Automatic changelog generation for PR #57839 [ci skip]

commit 7b12b80537e75ecb92ca46785eb67dcfcdf98b66
Author: Fikou <piotrbryla@onet.pl>
Date:   Sun Mar 21 14:00:36 2021 +0100

    fixes getting nothing from necropolis chests (#57839)

commit 7d91d9af11ff7a1fc65480db279cccc1e46b5548
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 12:57:43 2021 +0000

    Updating GBP from PR #57854 [ci skip]

commit 963553b4f4ccf3e0fb609b929c64cb0e135e8f17
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Mar 21 05:57:22 2021 -0700

    Automatic changelog generation for PR #57854 [ci skip]

commit 66fb1881288ec7bc2cd98cd800b0ecd1f48330af
Author: Qustinnus <Floydje123@hotmail.com>
Date:   Sun Mar 21 13:57:19 2021 +0100

    fixes some oddities in addiction code (#57854)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit f465fc9c89515d083cb4d98da1cb5702717852b3
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 12:53:14 2021 +0000

    Updating GBP from PR #57850 [ci skip]

commit 4a9b91e981fb0954ec8873e5333b2cf6a44aaad6
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Sun Mar 21 12:52:52 2021 +0000

     Immovable Rod code cleanup, signal listening and improvement. (#57850)

commit fec5bb160f76490094c8b0a0f3a338ae2efa0347
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 04:40:16 2021 +0000

    Updating GBP from PR #57084 [ci skip]

commit 0b2ee029d6dc2659e0dc83a8ad94efa21d267263
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 21:39:55 2021 -0700

    Automatic changelog generation for PR #57084 [ci skip]

commit ed85d3f5aac5990164fd6423a8658007faf0377e
Author: Fikou <piotrbryla@onet.pl>
Date:   Sun Mar 21 05:39:52 2021 +0100

    Full-Automatic Guns (#57084)

    * fullauto component

    * eh

    * h

    * brap

    * it works!

    * FUCK SHITUP

    * dumbass

    * l6

    * oops

    * GOD

    * THE LAST 10% OF A PROJECT IS 90% OF THE WORK

    * slopwer projecitles, replaces the tesla gun

    * heavy

    * minigun

    * minigun stuff

    * runtime fixes, pointer icon

    * nuh uh

    * makes modifeirs things

    * nerf this

    * yes

    * aghh

    * agh

    * real high intensity changes here

    Co-authored-by: Ryll-Ryll <3589655+Ryll-Ryll@users.noreply.github.com>

commit b91777b3255419e644d2178ac7b9e02ed92ee682
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 04:17:42 2021 +0000

    Updating GBP from PR #57524 [ci skip]

commit e08a2e173d57cc0901a6746dab1df4a41aba1f4c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 21:17:22 2021 -0700

    Automatic changelog generation for PR #57524 [ci skip]

commit 2425c5b7b75bfe29e1ef39a2726e4eb853ea50d3
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Sun Mar 21 00:17:19 2021 -0400

    Adds in an intern closet to centcom. (#57524)

commit 0ffdadfee8189be1d129bdf14f0899687ac8b86b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 01:15:47 2021 +0000

    Updating GBP from PR #56443 [ci skip]

commit a3ca50718ee3d28ccb6857ef4f9e782bbac042d1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 18:15:28 2021 -0700

    Automatic changelog generation for PR #56443 [ci skip]

commit 687f91d8bdb8b84a2e43460817efa68ba59fbe15
Author: TemporalOroboros <TemporalOroboros@gmail.com>
Date:   Sat Mar 20 18:15:24 2021 -0700

    Desnowflakes tank integrity (#56443)

    Makes tanks use obj_integrity instead of their own snowflaked version.
    Makes tanks check for exploding when they are destroyed, rather than once every process.
    Makes tanks always leak their gases when they are deconstructed.
    Removes the ability for tanks to seal themselves back up over time.
    Makes the bomb spawner actually produce functional bombs.
    Removes the extraneous syndicate bomb spawner subtype.
    Miscellaneous code improvements to tanks, bomb spawners, and the blastcannon.
    Fixes the explosives compressor doubling the power of any bomb you put in it.

    The changes to tank rupturing behavior shouldn't effect most tritium fueled TTVs including the 50K recipe. Toxins players don't need to worry about suddenly being incapable of getting points or refining anomaly cores. They should only really effect singlecaps, but I don't know enough about singlecaps to know what recipes I should test. I have confirmation that at least one mix is not effected by this.

    The self-sealing properties of tanks have been removed. I'm not sure what the purpose of it was, I have heard that it was used to enable hand-portable plasmaflooding, but I'm not familiar with the practice.

    As it turns out, the basic bomb spawners were broken on master! I have made the bombs they produce maxcap instead of just spring a leak. Since they maxcap by default now I have removed the syndicate subtype used to spawn the TTV produced by the cuban pete arcade game and replaced it with the normal timer subtype. Since none of the bomb spawner subtypes were used for anything else this shouldn't have any effect on the game.

    On a similar note, I have discovered that the maxcap recipe on the wiki stopped working at some point since it was written. I will replace it with a functioning set of instructions.

    Less snowflake code.
    Bomb spawners are actually functional now.
    Slightly better code.
    The explosives compressor accurately reflects the power of the bomb you put into it.

commit 6cab00f4ccd6b61a042d7db4accbbe5ad8850507
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Mar 21 00:11:42 2021 +0000

    Updating GBP from PR #57685 [ci skip]

commit b09d921455161d51e81006d6f14c9ba906023637
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 17:11:14 2021 -0700

    Automatic changelog generation for PR #57685 [ci skip]

commit f44c20cdf4242fa6ef5285b549df3b7119b9496a
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Sat Mar 20 17:11:11 2021 -0700

    Departmental officers are now put together, rather than separate, if possible (#57685)

    Security officers will now be paired up together in the same department, across departments. This means that, instead of 4 officers being split across 4 departments, there'll now be 2 groups of 2.

    Late-join officers will be put into any department with only 1 officer. If none exist, the least populous department will be chosen, with their preference having priority.

    Updates the maps to have more spawns for departmental officers. Delta previously had none, and now has some. Fixed a bug where MetaStation's security departmental officer was a supply one instead.

    Removes the "random" departmental preference. All security officers are now given a department. The "none" preference still exists, but just to show that you don't care which department you're put into.

    Updates the config to comment out SEC_START_BRIG. This is what the configuration was already on live servers.

    This is something that should likely be test merged, but it mucks with savefiles. Luckily, the only damage it does is changing random departments to none, so if a TM is reverted, only that will have to be changed.

commit 28d4cfb9c28a956414c65ed0904cbed1b8c36de4
Author: Changelogs <action@github.com>
Date:   Sun Mar 21 00:03:43 2021 +0000

    Automatic changelog compile [ci skip]

commit e9d0429902ac621c3ae1dc7523ac11c68bb6c1fe
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 23:36:25 2021 +0000

    Updating GBP from PR #57837 [ci skip]

commit 9219b1a4d630b866facfd91af535464259f013e3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 16:36:05 2021 -0700

    Automatic changelog generation for PR #57837 [ci skip]

commit 40e1e41fe4fb37a2c3ae524adbee29bac1df0786
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Sun Mar 21 00:36:02 2021 +0100

    Stack splitting now uses right click (#57837)

    Co-authored-by: Arkatos <arkatos1234@email.com>

commit b668738b94425a6797715c252fed86803c4e3ecd
Author: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Date:   Sat Mar 20 19:35:37 2021 -0400

    Adds RangedRightClickOn to Mobs (#57841)

    * Adds OnRangedRightClick

    * Do Changes

commit 1cc171f353d98203ed92b3e6e1453f33b020b05b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 23:23:57 2021 +0000

    Updating GBP from PR #57829 [ci skip]

commit 4ffbbd5cf571a4379dbfd25925ce57c919c80efb
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 23:23:40 2021 +0000

    Updating GBP from PR #57542 [ci skip]

commit fbe47b1c48ace67b5f0edd77c8fcb5886b055aa3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 16:23:37 2021 -0700

    Automatic changelog generation for PR #57829 [ci skip]

commit 5a9a8f02cc898feb29ab7f2d19295bfb5b4ece4b
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date:   Sat Mar 20 16:23:34 2021 -0700

    Round end report now shows AI laws even if they are controlling a shell (#57829)

    * Round end report now shows AI laws even if they are controlling a shell

    * inline

commit 2b9905fdd8a18df78246d5f8b7b5df8c09e9d4d7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 16:23:19 2021 -0700

    Automatic changelog generation for PR #57542 [ci skip]

commit 05edacb32489c3905929ba5f2c40b178a81996a4
Author: EOBGames <58124831+EOBGames@users.noreply.github.com>
Date:   Sun Mar 21 00:23:16 2021 +0100

    Rule Botannia: British Bots for the Restaurant (#57542)

    * I hate moths

    they're all dusty and shit

commit 75d3c3e601c1c4b6cd012139d276160673995954
Author: MMMiracles <lolaccount1@hotmail.com>
Date:   Sat Mar 20 19:07:50 2021 -0400

    tram hotfix hopefully maybe (#57646)

    The cause of the blender was the fact the UI wouldn't update properly if left open and you walked away, meaning you could tell the tram to go to a destination it was already at and brrrrrrrrrr.

    TGUI really isn't my strong suite and forcing it closed guarantees the info on the UI is updated so no blender.

commit 1899877ae19026a3108e9f5a8d6f62cac4557a6a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 23:06:41 2021 +0000

    Updating GBP from PR #57628 [ci skip]

commit b5be8d05803a4abb2c0ad08b026375b661f9b1f1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 16:06:22 2021 -0700

    Automatic changelog generation for PR #57628 [ci skip]

commit 47d991664671002e012f93d1f2a4a03ca170c931
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Sun Mar 21 00:06:19 2021 +0100

    Minor car refactor (#57628)

    Minor car refactor
    Changed how oil is made
    Replaced vars with cooldowns
    some other minor stuff

commit b3f45bafb6a1859aa4d64b9b233f59acfc70b524
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 23:05:40 2021 +0000

    Updating GBP from PR #57617 [ci skip]

commit 40be38622321ef5cb856f978d0c9e2999b4d731d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 16:05:22 2021 -0700

    Automatic changelog generation for PR #57617 [ci skip]

commit b8b4bf03998cdf6fede7ac62a821f2ee1077ce63
Author: Cimika/Lessie/KathyRyals <65850818+KathyRyals@users.noreply.github.com>
Date:   Sun Mar 21 00:05:18 2021 +0100

    Refactors /mob/living/CtrlClick(mob/user) and fixes pulling issues. (#57617)

    Refactors the whole /mob/living/CtrlClick(mob/user) proc to be better and fixes some issues around grabbing failing due to poor logic. Closes #57618

commit fb488fdfff3a22b2803fc9a824680651b5b86d4e
Author: TemporalOroboros <TemporalOroboros@gmail.com>
Date:   Sat Mar 20 16:03:59 2021 -0700

    Some explosions code cleanup (#57493)

    Clears out two deprecated explosions systems (explosion ids and explosion levels)
    Refactors a bunch of contents_explosions procs to be maybe slightly faster.
    Cleans up a bunch of ex_act code.
    Slightly cleaner code
    A few less unused vars on /atom and /turf

commit a71c7657af6cd568248af6db7ec503943313cff3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 05:58:18 2021 -0700

    Automatic changelog generation for PR #57798 [ci skip]

commit 01eef19c91567becbd9cbe795f53b310c530774a
Author: Fikou <piotrbryla@onet.pl>
Date:   Sat Mar 20 13:58:15 2021 +0100

    removes medkit from ert engineer (#57798)

commit 8878f2444735719a954182105501ad97263b3c2d
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 12:51:56 2021 +0000

    Updating GBP from PR #57832 [ci skip]

commit 359e6fc18f38d4d4ec3fd5c42a08175d2558a826
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 05:51:37 2021 -0700

    Automatic changelog generation for PR #57832 [ci skip]

commit 28d39ca517bbbd41f215c65a67e4d58ed3149e58
Author: Aleksej Komarov <stylemistake@gmail.com>
Date:   Sat Mar 20 14:51:34 2021 +0200

    Swap buttons in ListInput for improved accessibility  (#57832)

    Swapped OK/Cancel buttons in tgui list input, so that it stays consistent with Windows UI guidelines (was Cancel/OK before).

commit c66d079e4fe917ace80d04e61194c3723ce087df
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 12:47:31 2021 +0000

    Updating GBP from PR #57826 [ci skip]

commit 44c5b60143af3ca52fe2d02f9895419f31b7ec82
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 05:46:47 2021 -0700

    Automatic changelog generation for PR #57826 [ci skip]

commit 7d315ad317f436c659c2774396a2ede05ef9e19e
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Sat Mar 20 05:46:43 2021 -0700

    FIXES EVERYTHING (#57826)

commit 92f88b8c82fadd6694d5cab1d0994f262ac14e85
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 12:46:27 2021 +0000

    Updating GBP from PR #57828 [ci skip]

commit 0e6c8272d2f57e0b3728806a42a2b6377732390f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 05:46:07 2021 -0700

    Automatic changelog generation for PR #57828 [ci skip]

commit 2fad574a4ec6ac7d7bfba448c4ff9ef24f29ee48
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date:   Sat Mar 20 05:46:04 2021 -0700

    More harddel fixes + Tram sanity check (#57828)

    * Fixes a harddel caused by the FUCKING MACHINE VAR WHAT THE FU-

    * Fixes a tram related harddel, the proc that removed things from the riders list worked on stuff passed in by Uncrossed, but failed with the qdeleting signal. I've made a wrapper proc to better support these things, added signal handlers, and removed an if check that hid nulls (If it's breaking I need to know)

commit fbca3e697fc981bd87049fc2387517c8a27d1b31
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 12:06:05 2021 +0000

    Updating GBP from PR #57827 [ci skip]

commit 6691ece3255438e7f83ea5e204b4de87e894db21
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Mar 20 05:05:46 2021 -0700

    Automatic changelog generation for PR #57827 [ci skip]

commit 40466ab812ee78f4bad06d902869c07be2c6c248
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Sat Mar 20 05:05:43 2021 -0700

    borg model picker uses a radial menu: (#57827)

commit fac47b17ce46c2f7c6df5e1fbbfa11e78c3c4e76
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 06:09:18 2021 +0000

    Updating GBP from PR #57546 [ci skip]

commit 6cedd9b5b1f5fe8b48c2952a842959cee27e6257
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 23:08:57 2021 -0700

    Automatic changelog generation for PR #57546 [ci skip]

commit 259d66e77e3bdbf287c0ae6ce5e1a9485ceb2c3b
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Sat Mar 20 07:08:54 2021 +0100

    expands the list of orderable objects for space-italian and space-french customer_data datums. (#57546)

commit 0d9ffba62e3e124a2e2e5107e728830d59b2ad84
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Mar 20 01:42:43 2021 +0000

    Updating GBP from PR #57778 [ci skip]

commit fc48bc6915130f16cc4ffb1d19e3320309aac339
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 18:42:23 2021 -0700

    Automatic changelog generation for PR #57778 [ci skip]

commit ba0f40a0dfdad60d598818636e346a61f4106446
Author: Emmanuel S <mrdoomboyo@gmail.com>
Date:   Fri Mar 19 21:42:20 2021 -0400

    Makes defib description text slightly more informative (#57778)

    seems many people didn't know you can connect defibs directly to medical cyborgs
    This PR helps fix that

commit 99fd7b7e1cda1245ed487dd959c6d37013787d30
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 17:12:59 2021 -0700

    Automatic changelog generation for PR #57825 [ci skip]

commit 79753143181235119f0d303ba919a4706ea77532
Author: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
Date:   Fri Mar 19 20:12:56 2021 -0400

    Improve tgui routing to allow interface subdirectories (#57825)

    * Improve tgui routing to allow interface subdirectories

    * Reverse order of interface file resolution, to be consistent with common expectation (top-level .tsx, top-level .js, directory .tsx, directory.js) and the way Webpack checks

commit 35a311786d796fa610a4add3ae2a839d51fcfeaf
Author: Changelogs <action@github.com>
Date:   Sat Mar 20 00:03:54 2021 +0000

    Automatic changelog compile [ci skip]

commit b2d419cecbbdb0d9dfc912e0ac35bffe07847ee0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 15:56:38 2021 -0700

    Automatic changelog generation for PR #57510 [ci skip]

commit c7a399ec4af2b4f91a6d4ad75115db92f10d399d
Author: Kylerace <kylerlumpkin1@gmail.com>
Date:   Fri Mar 19 15:56:35 2021 -0700

    Fixes bug with atoms (including new players!!!!) not spawned from the holodeck being deleted by it if they happened to be initialized at the same time (#57510)

    About The Pull Request

    Fixes #57446
    yeah not my best moment, holodeck currently sets SSatoms to add every call to InitAtom() to a list and then give it back to the holodeck console (it actually goes through map_template/holodeck to do it but whatever). However it turns out atom/New() calls InitAtom too, so if an atom is created while SSatoms is still creating the list to give to the holodeck then that atom is added to the list regardless of whether or not its actually from the holodeck template.

    Now theres an extra argument to InitAtom that tells it whether its spawned directly from a map template (ie, its part of the input list of uninitialized atoms that InitializeAtoms was given) or otherwise the output list that the holodeck uses is populated by calling GetAllContents on all atom/movables spawned directly from the template.

    also renamed some vars in initTemplateBounds because it was hard to reason what it was doing and made it use as anything

    also note that loading a map template with returns_created_atoms = TRUE will no longer track atoms that arent in the map file but are spawned directly onto a turf, currently nothing does this with the holodeck (which is the only map template that has this feature)

    by the way this bug is my fault
    Why It's Good For The Game

    incredibly incredibly unlucky new players dont deserve to be deleted just because they didnt spawn in the holodeck
    Changelog

    🆑
    fix: the holodeck is no longer so powerful that it can destroy anything and everything that dares to start existing while it's busy loading programs
    /🆑

commit 3b7842e357142cb7f9dbfe171a08982866cf7972
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Mar 19 22:54:11 2021 +0000

    Updating GBP from PR #57300 [ci skip]

commit c63aed90a39bc4a3084d1ae5058c28c6c6b2accb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 15:53:49 2021 -0700

    Automatic changelog generation for PR #57300 [ci skip]

commit 7526cdae7df06306583c454ba617efeb3b78db2b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Mar 19 22:53:46 2021 +0000

    Updating GBP from PR #57425 [ci skip]

commit 11367dda89f8a706615c14f0c177afa8a5541169
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date:   Fri Mar 19 15:53:45 2021 -0700

    Adds the ability to download a borg's logs using SiliConnect. (#57300)

    About The Pull Request

    Adds a function to Siliconnect in which you can tap a borg using a mobile device that is currently running the software, and it will download the borg's logs. These logs list events such as being locked or unlocked, taken offline and being restored, and the process of being emagged. Borg logs will now list the emag user's name as a new user.

    Downloading the logs is done by right-clicking the borg while the software is open and active. This will "tap" the borg with the device, initiating the log transfer automatically. The transfer will take eight seconds to complete, requiring you and the borg to stay adjacent the entire time, and the borg will get a large red text alert about the upload when it starts. The logs are also not stored permanently on the device, and will be lost if the app is closed.

    This PR also introduces the tap() proc for modular computer programs, and adds functionality the the computers to call it when right-clicking with the tablet as a tool. Should the app use the tap in a meaningful way (such as starting a borg log download), it will return TRUE, and the computer will end the secondary attack chain.

    Currently, this requires using a tablet or laptop with Siliconnect, as you cannot tap with a console. Someday I hope to add an additional hardware option for consoles in the form of a wireless hand scanner to replicate tapping.
    Why It's Good For The Game

    Adds a neat way to "diagnose" a borg acting oddly, assuming you have a way to keep them still. Allows one to view if the borg has been emagged, by whom, what SiliConnect messages the borg has received, the number of law changes that have been made, as well as some other (somewhat fluff) information relating to taking damage and getting upgrades.
    Changelog

    🆑
    add: You can now download a cyborg's internal logs by right-clicking them with a mobile device running SiliConnect. Take a look if one is acting a bit strange, you might find something interesting.
    add: Borg integrity (health) is now roughly shown in SiliConnect, under "Condition".
    /🆑

    To Do:

    Fix the to_chat not being sent to the borg when a log transfer breaks due to distance
    Add some sort of text feedback when tapping an atom with a device, or viewing one being tapped.
    Possibly restrict syndicate borgs from having their logs viewed by SiliConnect (and likewise with station borgs and Roboverlord) Changed my mind on this, will implement later if we find it's needed.

        Change the log area of the window to expand naturally rather than use a fixed height

    image

    I'm not super deadset on the emag user's name being listed. It seems like a neat function unique to having a tablet running Siliconnect (as most of the other info is already available through other means), and one can always pop the brain out for a re-borg and demand the name anyway.

commit 8816136c413bde7fd7923434f021c7b08e466cc6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Mar 19 15:53:25 2021 -0700

    Automatic changelog generation for PR #57425 [ci skip]

commit aab2a9610a4da3d78bd59ff071d8f5e8f4b62dda
Author: Thalpy <33956696+Thalpy@users.noreply.github.com>
Date:   Fri Mar 19 22:53:22 2021 +0000

    Fixes some issues with helbital (#57425)

    About The Pull Request

    REM was changed from 1 to 0.5, so there were a few unintended side effects from that. It al…
Yenwodyah added a commit to Yenwodyah/tgstation that referenced this pull request May 4, 2021
@Yenwodyah
Revert "Departmental officers are now put together, rather than separ…
cf75a72 
…ate, if possible (tgstation#57685)"

This reverts commit f44c20c.
@Mothblocks Mothblocks mentioned this pull request Jun 13, 2021
Closed
@Potato-Masher Potato-Masher mentioned this pull request Jun 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coiax coiax coiax left review comments

@LemonInTheDark LemonInTheDark LemonInTheDark requested changes

@EOBGames EOBGames Awaiting requested review from EOBGames EOBGames is a code owner

@ShizCalev ShizCalev Awaiting requested review from ShizCalev ShizCalev is a code owner

Assignees
No one assigned
Labels
Config Update Time to bother the headadmins for three months to get your config applied Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Unit Tests Make sure the stuff that's broken is still broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Mothblocks @TheVekter @Dorsisdwarf @Mickyan @Cyberboss @MrMelbert @coiax @LemonInTheDark @tgstation-server