[The reconnect bug is maybe fixed] Queue stat panel commands, ideally fixing another source of the reconnect bug #59228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
stylemistake
approved these changes
May 21, 2021
|
TM'd on Terry. |
|
It seems to have completely fixed the reconnect bug for me on Terry. |
Mothblocks
changed the title
|
ive heard this one before.... |
Mothblocks
changed the title
|
my confidence has waned |
|
Someone with the bug confirmed to me it worked fine after they cleared cache. |
tgstation-server
added a commit
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #59226, ideally.
It's hard to test this, but this queues any
?commanduntilinit_verbs, in which case we have confirmed to be connected. The only one it does not is the one inonload, as that didn't seem to appear in my logs and I suspect is only called once we're connected to the server, which helps.Changelog
馃啈
fix: Fixed another source to the bug preventing reconnect.
/:cl: