You Are Two mutation #59278

tralezab · 2021-05-23T19:37:54Z

About The Pull Request

Makes you two.

You have two bodies, they both do what you're doing, or at least attempt to.

You have an ability to swap focus on which body, which lets you do some fine manipulation I can't replicate with signals.

Advantages of this:

If you can keep them close together (try walking into walls), you basically get to attack with two people
One can "save" the other
Equip em both with stuff, you have two fellas worth of space
Be in two places at once... I mean, slime split is probably better for this, but what do I know?

Disadvantages of this:

Both have to stay alive
Where the fuck is the other one
Both have to stay alive
Controlling two people at the same time
Both have to stay alive
Dear god

hook more signals for attacking, and other stuff
make one dying kill the other
add an achievement for escaping with two
add some sanity for not getting another "you are two" mutation on the other
...copy some more stuff over like mutations and traumas? they should actually be copies, or else this is just hars heal trick again
so a solution for the above was devised, BUT: i must refactor mutations and traumas to split behavior on "first applied" and "enabled" as to not have weird stacking/repeating effects that shouldn't when i transfer a mutation to a new person without exploits. same for traumas, most likely. maybe make a proc for this?
implement a way to prevent overlapping... you know, to make it more interesting.

p.s. I would have hooked more signals before pr'ing this but something came up and I wanna farm upvotes while i'm away. #honesty

Why It's Good For The Game

This seems like an incredibly fun concept for a mutation. Also, that achievement has GOT to happen. Who is up for a challenge?

Changelog

🆑
add: New mutation: You Are Two!
/:cl:

NoxVS · 2021-05-23T19:52:09Z

How does this interact with one or both being a slimeperson?

tralezab · 2021-05-23T19:56:31Z

Mmm... probably not well. I should make a mind transfer blocked trait. Or try it out in game first

ShibaInuLord · 2021-05-23T20:05:22Z

i cant believe jacob and esau are in ss13 now

maxymax13 · 2021-05-23T20:19:20Z

if you speak into common does it show up twice 🤔

tralezab · 2021-05-23T20:19:38Z

Yes (provided both have radios)

D4C-420 · 2021-05-23T21:14:17Z

It’s all fun and games until someone makes a tainted you are two mutation.

tralezab · 2021-05-23T21:19:25Z

this is great

TemporalOroboros · 2021-05-23T21:20:11Z

This doesn't look like the other gets the mutations of the original. Could that let you stack this basically infinitely?

tralezab · 2021-05-23T21:21:39Z

I'm still thinking of a good solution for that. Probably going to involve simply making the other immutable.

optimumtact · 2021-05-23T21:25:28Z

this is going to be buggier than dullahans

tralezab · 2021-05-23T21:26:42Z

Honestly if dullahans used signals like I am they wouldn't be buggy, so I have faith on making this work

tralezab · 2021-05-23T21:29:08Z

code/datums/mutations/you_are_two.dm

+		reviving.adjustCloneLoss(70)
+
+///called when the one moves
+/datum/mutation/human/you_are_two/proc/on_pre_move(datum/source, atom/newloc)


note to self: not deep enough, still checking if movement is possible

tralezab · 2021-05-23T21:33:26Z

Well... If I keep it modular, may we at least try? If I pull this off, this will be pretty fucking rad

D4C-420 · 2021-05-23T21:35:16Z

Oh yeah how does this work with mutadone. If one gets gibbed or dusted do they both? For revival do they both have even be in the original body? How is health displayed to the player. Inventory as well. . Do rev heads who have a clone off and on station count as on? Do spells/ gene/ ling/ body augments get carried over to the clone? going on here but these are just some interactions I thought up.

tralezab · 2021-05-23T21:40:33Z

Oh yeah how does this work with mutadone.

copy will be immutable, original will lose the mutation and lose their copy. Hell, maybe I should make the mutations pass between humans when you switch... interesting thought, i may pursue!

If one gets gibbed or dusted do they both?

Yes!

For revival do they both have even be in the original body?

For things that revive you, you must be in your body. one will revive when the other does.

How is health displayed to the player. Inventory as well.

You have an ability to swap to the other body (making your original copy your movements) to do fine tuning like that

Do rev heads who have a clone off and on station count as on?

The mind will follow the active one, making the rev considered as abandoning if it is actively using the off station clone. Either useless or forfeit, but either way they both die when the one onstation gets killed so i'm not worried!

Do spells/ gene/ ling/ body augments get carried over to the clone?

The big deliberation i've been having. Yeah, i'll make mind specific stuff carry over. I know spells already do, but lets also do genes. Lings will follow automatically. body augments won't.

going on here but these are just some interactions I thought up.

it actually helps to think of edge cases here so thank you

MMMiracles · 2021-05-23T23:56:36Z

i can't wait to play my favorite binding of isaac character, jacob & esau

Wallemations · 2021-05-24T01:29:01Z

IMAGINATION GREENTEXT!!

tralezab · 2021-05-24T01:51:19Z

So let me just say right now

This is going better than I thought it would

OceanFish1 · 2021-05-24T04:23:20Z

This is great.
If it works I won't become back my money

Colovorat · 2021-05-24T05:49:57Z

Reintroduce dullahans Pog

Farquaar · 2021-05-24T07:22:49Z

this is great

Give yourself the mutation
Line up the HoPline
Waste the HoP's time and clog up the line
Profit?

tralezab · 2021-05-24T07:29:30Z

@Farquaar
I've been messing around with the double attacks, and they're really fun. Even traversing a basic room is interesting because one of you gets stuck on some object at a certain point, and you have to line up to go through doors.

ghost · 2021-05-24T08:47:21Z

Dullahans were made by someone who sucks ass at coding so there's a bit of a difference there

Time-Green · 2021-05-24T09:28:33Z

code/datums/achievements/misc_achievements.dm

+
+/datum/award/achievement/misc/double_escape
+	name = "Double Escape"
+	desc = "Escape alive with the \"You are Two\" mutation. Not so easy now, is it?"


It is if you take the mutation three seconds before arriving on centcom. Maybe add a minimum time aswell?

Red-byte3D · 2021-05-24T09:50:26Z

how is this gonna work with radstorm / monkeys

tralezab · 2021-05-24T09:51:42Z

All mutations that happen to the other are transferred to the one, and whenever the one switches to the other, the mutations follow the one.

Red-byte3D · 2021-05-24T09:52:53Z

well if you let monkeys have this wont it allow xenobio to infinetly farm monkeys

tralezab · 2021-05-24T10:12:03Z

Yeah I can remove the mutation on monkify, if it doesn't do that already. Can... monkeys use all mutations?

.vscode/launch.json

Red-byte3D · 2021-05-24T20:56:11Z

Yeah I can remove the mutation on monkify, if it doesn't do that already. Can... monkeys use all mutations?

i dont think monkeys can use it on themselves but i meant mroe as in just get 1 monkey, twoifiey it and then kill the second one and claim it with xeno machine to get it stored on the computer and repeat

tralezab · 2021-05-24T21:15:08Z

@InsaneRed I'm pretty sure there are easier ways to get monkeys that that, but the other part is that if one of the two is gibbed the other one is too... or should be!

tralezab · 2021-05-24T22:44:36Z

heh. heheh. Ybeert Ewolram,

moocowswag · 2021-05-24T23:22:51Z

I can see one bug / anomaly that might form when a splitty slime person with this mutation activated splits.

Activated mutations are also activated on new bodies when a slime person splits so you could end up with double the bodies on each split or some sort of glitchy mess.

Also if you are controlling both bodies at the same time how does that work with spells / mutations that provide an active ability.

Take firebreath for example, will both bodies fire a fireball at the same time or will the one youre controlling fire, and if only one of them fires will both bodies go on cooldown for firebreath or only one of them?

tralezab · 2021-05-24T23:53:18Z

It is possible to lock mutations to species, I could simply lock them to roundstart species only and that'd go a long way towards preventing weird stuff with other species. Which would also fix the monkey issue.

SmArtKar · 2021-05-25T06:02:27Z

Hm, how will this work with changelings? I suspect that changeling's revival might be broken with them

tralezab · 2021-05-25T19:06:09Z

Should work as intended. One reviving revives the other... though your other will take clone damage if they cannot revive with the damage they've taken

tralezab · 2021-05-25T20:35:36Z

this was genuinely fun to work on, but there's /just/ too many variables to consider. The other body basically needs to not be able to be possessed, and into anything inhuman, be duplicated, etc etc etc. I think I could get it to be stable enough given enough time, but

get those completion marks fikou

b874284

tgstation-server added the Feature Exposes new bugs in interesting ways label May 23, 2021

This comment has been minimized.

Sign in to view

you are more complete

2d0d56f

tgstation-server added the Sprites A bikeshed full of soulless bikes. label May 23, 2021

tralezab commented May 23, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

tralezab added 2 commits May 23, 2021 22:56

achievement + more progress

b49a4e9

emote signal lint + fixes

c29edd3

lint, again. mutations now carry over to the other

f05c622

Time-Green reviewed May 24, 2021

View reviewed changes

tralezab commented May 24, 2021

View reviewed changes

.vscode/launch.json Show resolved Hide resolved

last commit

0c02a26

tralezab closed this May 25, 2021

You Are Two mutation #59278

You Are Two mutation #59278

Conversation

tralezab commented May 23, 2021 • edited

About The Pull Request

Advantages of this:

Disadvantages of this:

Why It's Good For The Game

Changelog

This comment has been minimized.

NoxVS commented May 23, 2021

tralezab commented May 23, 2021

ShibaInuLord commented May 23, 2021

maxymax13 commented May 23, 2021

tralezab commented May 23, 2021 • edited

D4C-420 commented May 23, 2021

tralezab commented May 23, 2021

TemporalOroboros commented May 23, 2021

tralezab commented May 23, 2021

optimumtact commented May 23, 2021

tralezab commented May 23, 2021

tralezab May 23, 2021

Choose a reason for hiding this comment

This comment has been minimized.

tralezab commented May 23, 2021

D4C-420 commented May 23, 2021

tralezab commented May 23, 2021

MMMiracles commented May 23, 2021

Wallemations commented May 24, 2021 • edited

tralezab commented May 24, 2021

OceanFish1 commented May 24, 2021

Colovorat commented May 24, 2021

Farquaar commented May 24, 2021

tralezab commented May 24, 2021 • edited

ghost commented May 24, 2021

Time-Green May 24, 2021

Choose a reason for hiding this comment

tralezab May 24, 2021

Choose a reason for hiding this comment

Red-byte3D commented May 24, 2021

tralezab commented May 24, 2021

Red-byte3D commented May 24, 2021 • edited

tralezab commented May 24, 2021

Red-byte3D commented May 24, 2021

tralezab commented May 24, 2021

tralezab commented May 24, 2021

moocowswag commented May 24, 2021 • edited

tralezab commented May 24, 2021

SmArtKar commented May 25, 2021

tralezab commented May 25, 2021 • edited

tralezab commented May 25, 2021

tralezab commented May 23, 2021 •

edited

tralezab commented May 23, 2021 •

edited

Wallemations commented May 24, 2021 •

edited

tralezab commented May 24, 2021 •

edited

Red-byte3D commented May 24, 2021 •

edited

moocowswag commented May 24, 2021 •

edited

tralezab commented May 25, 2021 •

edited