Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ashwalkers to have custom lungs #59413

Merged
merged 5 commits into from
Jul 11, 2021
Merged

Change ashwalkers to have custom lungs #59413

merged 5 commits into from
Jul 11, 2021

Conversation

coiax
Copy link
Member

@coiax coiax commented May 31, 2021

Ashwalkers now have lungs that are specially adapted to Lavaland
environments. However, that specialisation comes at a cost at sometimes
not being able to operate in normal human air conditions.

  • Ashwalker lungs take a gas sample of the default lavaland atmosphere
    on initialisation in order to customise themselves
  • Currently, excess O2/N2 has no functional drawback, so no maximum
    value is set on the lungs. If Lavaland rolls a higher N2/O2 mole count
    than human air, they will still struggle however.
  • Ashwalkers are no longer NOBREATH, bringing them closer
    to regular lizards.

馃啈 coiax
balance: Ashwalkers now have lungs adapted for the atmosphere of Indecipheres,
and now breathe. However, if the Indecipheres
atmosphere has miasma, they are immune to it.
/:cl:

Ashwalkers now have lungs that are specially adapted to Lavaland
environments. However, that specialisation comes at a cost at sometimes
not being able to operate in normal human air conditions.

- Ashwalker lungs take a gas sample of the default lavaland atmosphere
  on initialisation in order to customise themselves
- Currently, excess O2/N2 has no functional drawback, so no maximum
  value is set on the lungs. If Lavaland rolls a higher N2/O2 mole count
  than human air, they will still struggle however.
- Ashwalkers are no longer NOBREATH or VIRUSIMMUNE, bringing them closer
  to regular lizards.
@coiax coiax changed the title Changes ashwalkers to have custom lungs Change ashwalkers to have custom lungs May 31, 2021
@dragomagol
Copy link
Member

Shouldn't this have a changelog? Seems like something important for ghosts playing ashwalkers to know.

@rasepretep
Copy link
Contributor

Would this make it possible to get an Ashwalker (not ghost-spawned) corpse from a legion, epi it and get those lungs transplanted to gain that benefit? Alternatively, could this open a path to OOC character customization, allowing lizard players to not only pick regular/digitigrade legs, but regular/ashwalker lungs as well?

@coiax
Copy link
Member Author

coiax commented May 31, 2021

Shouldn't this have a changelog? Seems like something important for ghosts playing ashwalkers to know.

You're completely right.

@coiax coiax added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label May 31, 2021
@D4C-420
Copy link
Contributor

D4C-420 commented May 31, 2021

Don't they have VIRUSIMMUNE because they don't have any reasonable way to clean blood and gibs and as a result will get sick from walking around in it? I mean it should be miners and fauna killing ash walkers not random illness they can't cure.

@coiax
Copy link
Member Author

coiax commented May 31, 2021

As far as I understand, the sickness from gibs and blood comes from miasma buildup, which won't happen in the lavaland atmosphere, because it's constantly being reset to the normal air values.

And if miasma is normally part of the air, then they're immune to it.

@MrMelbert
Copy link
Contributor

MrMelbert commented May 31, 2021

as of #57957 , gibs / dead people no longer spit out miasma and instead try to infect you with diseases directly. Ashwalkers were given virus immunity a month or so ago because their tendril is often coated in gibs and dead bodies, which very often infected them with nasty viruses they had no means of curing or preventing.

Side question: If you take ash-walker mutation toxin on the station, will your lungs be functionally the same as normal lungs?

@coiax
Copy link
Member Author

coiax commented May 31, 2021

as of #57957 , gibs / dead people no longer spit out miasma and instead try to infect you with diseases directly. Ashwalkers were given virus immunity a month or so ago because their tendril is often coated in gibs and dead bodies, which very often infected them with nasty viruses they had no means of curing or preventing.

Did not know this, I will restore their virus immunity.

Side question: If you take ash-walker mutation toxin on the station, will your lungs be functionally the same as normal lungs?

The lungs are "prototyped" on the ideal lavaland gas that the air controller stores, ie. it's not on "first breath" or anything. Ashwalkers (or more specifically, blackened frilled lungs) created anywhere will be based on lavaland atmosphere.
Hilariously, even if the map is icebox.

@MrMelbert
Copy link
Contributor

MrMelbert commented Jun 1, 2021

The lungs are "prototyped" on the ideal lavaland gas...

Oh well, seems like gone are the days of sipping ashwalker mutation toxin in botany for nobreath and virus immunity. Still a cool change, though. 馃憤

@ATH1909
Copy link
Contributor

ATH1909 commented Jun 1, 2021

time to turn people into ash walkers as a changeling to make them suffocate 馃槑

code/modules/surgery/organs/lungs.dm Outdated Show resolved Hide resolved
code/modules/surgery/organs/lungs.dm Outdated Show resolved Hide resolved
@Mothblocks Mothblocks marked this pull request as draft June 2, 2021 06:24
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Jun 11, 2021
@github-actions github-actions bot closed this Jun 18, 2021
@coiax coiax removed the Stale Even the uncaring universe rejects you, why even go on label Jun 18, 2021
@coiax coiax reopened this Jun 18, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Jun 26, 2021
@coiax coiax removed the Stale Even the uncaring universe rejects you, why even go on label Jul 2, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Jul 10, 2021
@coiax coiax removed the Stale Even the uncaring universe rejects you, why even go on label Jul 11, 2021
@coiax
Copy link
Member Author

coiax commented Jul 11, 2021

Help the stale bot is bullying me

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Jul 11, 2021
@Mothblocks
Copy link
Member

its still drafted

@coiax
Copy link
Member Author

coiax commented Jul 11, 2021

@Mothblocks I'm in the testing stage.

@coiax coiax marked this pull request as ready for review July 11, 2021 20:20
@coiax coiax assigned coiax and Mothblocks and unassigned coiax Jul 11, 2021
@Mothblocks Mothblocks merged commit 364e2e1 into master Jul 11, 2021
@Mothblocks Mothblocks deleted the ashwalker-lungs branch July 11, 2021 23:02
github-actions bot added a commit that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants