Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Revenant, Sentient Disease, Space Pirates, and Obsessed to Dynamic #60281

Merged
merged 8 commits into from
Jul 29, 2021

Conversation

IndieanaJones
Copy link
Contributor

@IndieanaJones IndieanaJones commented Jul 17, 2021

About The Pull Request

This PR adds Revenant, Space Pirates, Sentient Disease, and Obsessed to dynamic's midround rulesets. Seeing as they are the only midround antagonists missing, it is about time they got added to the roster. Now the only one excluded is Slaughter Demon, and we can keep it that way.

And fugitives. But some elbow work has to go in there before they're ready to go.

Why It's Good For The Game

We need more variety in the midround rulesets to prevent constant repeats of the same midround antags, and they should have been here earlier, as there's no reason to exclude them from the dynamic ruleset selection.

Changelog

🆑
refactor: Revenant, Sentient Disease, Space Pirates, and Obsessed have been registered into dynamic mode.
/:cl:

@tgstation-server tgstation-server added the Refactor Makes the code harder to read label Jul 17, 2021
@Mothblocks Mothblocks self-assigned this Jul 17, 2021
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated Show resolved Hide resolved
@Mothblocks Mothblocks marked this pull request as draft July 17, 2021 07:21
@optimumtact
Copy link
Member

all the worst events

@Learner10
Copy link

all the worst events

I mean... fake virus exists.

@wraith-54321
Copy link

I think they can still trigger as a normal event, they just dont do anything to threat level, I know disease can anyway

@Mothblocks
Copy link
Member

Random events with antags still are influenced by Dynamic as per #57175

@IndieanaJones IndieanaJones changed the title Add Revenant, Sentient Disease, and Space Pirates to Dynamic Add Revenant, Sentient Disease, Space Pirates and Obsessed to Dynamic Jul 28, 2021
@IndieanaJones IndieanaJones changed the title Add Revenant, Sentient Disease, Space Pirates and Obsessed to Dynamic Add Revenant, Sentient Disease, Space Pirates, and Obsessed to Dynamic Jul 28, 2021
@IndieanaJones IndieanaJones marked this pull request as ready for review July 28, 2021 01:23
@Mothblocks Mothblocks marked this pull request as draft July 29, 2021 01:26
@IndieanaJones IndieanaJones marked this pull request as ready for review July 29, 2021 22:22
@Mothblocks Mothblocks merged commit a4a5d77 into tgstation:master Jul 29, 2021
github-actions bot added a commit that referenced this pull request Jul 29, 2021
@IndieanaJones IndieanaJones deleted the dynamic_midround_batch branch July 29, 2021 22:56
Mothblocks added a commit to Mothblocks/tgstation that referenced this pull request Aug 9, 2021
tgstation#60281)

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Makes the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants