Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tint balance #60461

Closed
wants to merge 1 commit into from
Closed

Tint balance #60461

wants to merge 1 commit into from

Conversation

Ghilker
Copy link
Contributor

@Ghilker Ghilker commented Jul 26, 2021

About The Pull Request

Rework how tint is calculated and rebalances clothes to work and behave with the system.
Everything that can cover your eyes now have a tint.

Why It's Good For The Game

Adds a small downside to several items, from flash protecting ones, to the eye covering ones. Stacking protections will have a bigger downside now.

Changelog

馃啈
balance: reworked tint calculations, items that can cover eyes and have flash protection are affected by this.
/:cl:

@tgstation-server tgstation-server added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Jul 26, 2021
@@ -10,6 +10,7 @@
permeability_coefficient = 0.01
flags_cover = MASKCOVERSEYES | MASKCOVERSMOUTH | PEPPERPROOF
resistance_flags = NONE
tint = 0.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@Time-Green
Copy link
Contributor

Can you show some examples? This seems pretty extreme

@moocowswag
Copy link
Contributor

moocowswag commented Jul 26, 2021

Can I at least spray paint eye protection items to customize the color of the tint?

@Ghilker
Copy link
Contributor Author

Ghilker commented Jul 26, 2021

Uh i might have worded it wrong since i used the name of the variable i'm touching (that is tint)
this var is the same that allows welding helmets to darken your screen, this means that sunglasses, various masks and helmets will darken your vision slightly

@Ghilker
Copy link
Contributor Author

Ghilker commented Jul 26, 2021

Normal
image

Just Sunglasses or just gas mask
image

Sunglasses + gas mask
image

@Burgermancoding
Copy link
Contributor

bad

1 similar comment
@Livrah
Copy link

Livrah commented Jul 26, 2021

bad

@Makximus
Copy link

Makximus commented Jul 26, 2021

do not do, i no like

@Fikou
Copy link
Member

Fikou commented Jul 26, 2021

sec members otw (on their way) to start the shift with vision impairment
image

@Time-Green
Copy link
Contributor

I don鈥檛 really see the point of these. These are so extremely minor they only serve to mildly annoy someone.

Especially security, who will always be wearing sunglasses, are going to walk around with their screens slightly messed up, always. Unless they take their glasses of out of frustration or because it鈥檚 hurting their actual eyes, and I don鈥檛 think that鈥檚 good content at all.

This鈥檒l just pointlessly degrade someones experience because they鈥檙e using stuff they need for their job.

@rdragan
Copy link
Contributor

rdragan commented Jul 26, 2021

Ghilker gas mask nerf PR no 8489394
Did I ever tell you what the definition of insanity is?

@Rowelll
Copy link
Contributor

Rowelll commented Jul 26, 2021

i straight give it a dislike

@necromanceranne
Copy link
Contributor

You can toggle tint on sunglasses already by alt clicking them.

There are jobs that are expected to use sunglasses as part of the job and never remove them. Namely bartenders so they can check measurements.

This is mostly balance in the form of ugly overlays. Which is a little weird and unintuitive.

@Supergrog
Copy link

This is awful.

@ghost
Copy link

ghost commented Jul 26, 2021

glass and eyeball torture

@MrStonedOne
Copy link
Member

MrStonedOne commented Jul 26, 2021

You're gonna need to add feathering (like the darker overlay has) to the light overlay so it doesn't look ugly at the center.

@81Denton
Copy link
Member

I don鈥檛 really see the point of these. These are so extremely minor they only serve to mildly annoy someone.

Especially security, who will always be wearing sunglasses, are going to walk around with their screens slightly messed up, always. Unless they take their glasses of out of frustration or because it鈥檚 hurting their actual eyes, and I don鈥檛 think that鈥檚 good content at all.

This鈥檒l just pointlessly degrade someones experience because they鈥檙e using stuff they need for their job.

@Time-Green summed up my concerns. This also appears to be the fifth or so attempt to nerf gas masks while providing little to no reasoning as to why it would be good for the game.

@81Denton 81Denton closed this Jul 26, 2021
@Ghilker Ghilker deleted the tint_balance branch October 9, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet