Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Dynamic Pirates #60669

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

IndieanaJones
Copy link
Contributor

About The Pull Request

Fixes Dynamic Pirates, as the PR that just added them didn't work properly for them. Note that they don't recycle if nobody opts to be one, it just makes spawners on the pirate ship for every slot it doesn't fill, which is sort of unfortunate for the whole recycling into sleeper agent thing, but it's the best solution we have for now.

Also, this should get the No GBP tag, as this is a bug of my own making.

Why It's Good For The Game

Unfunctional rulesets are bad.

Changelog

馃啈
fix: Dynamic's Pirate spawn will now properly trigger.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Aug 2, 2021
@Mothblocks Mothblocks added the GBP: No Update Prevent changes to the user's GBP balance from this PR label Aug 2, 2021
@Mothblocks Mothblocks merged commit 9c176e2 into tgstation:master Aug 4, 2021
@IndieanaJones IndieanaJones deleted the pirates_fix branch August 5, 2021 03:03
Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Aug 9, 2021
Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Aug 9, 2021
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
* Fixes Pirates (tgstation#60669)

* Fixes Dynamic Pirates

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants