QDEL_IN harddel prevention #60937
Merged
QDEL_IN harddel prevention #60937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
MrStonedOne
reviewed
Aug 19, 2021
BraveMole
commented
Aug 20, 2021
BraveMole
commented
Aug 20, 2021
Cyberboss
approved these changes
Aug 20, 2021
MrStonedOne
approved these changes
Aug 20, 2021
Cyberboss
requested changes
Aug 20, 2021
| @@ -1,4 +1,4 @@ | |||
| #define QDEL_IN(item, time) addtimer(CALLBACK(GLOBAL_PROC, .proc/qdel, item), time, TIMER_STOPPABLE) | |||
| #define QDEL_IN(item, time) addtimer(CALLBACK(GLOBAL_PROC, .proc/qdel, time > GC_FILTER_QUEUE ? WEAKREF(item) : item), time, TIMER_STOPPABLE) | |||
There was a problem hiding this comment.
Wait, does qdel() support dereferencing weakrefs? At a glance this seems like it'd just delete the weakref datum.
There was a problem hiding this comment.
Yes #56171
And there's an exemple in crabs.
…into qdel_hard_del
MrStonedOne
approved these changes
Aug 20, 2021
tgstation-server
added a commit
that referenced
this pull request
Aug 20, 2021
|
Your Fix/Feature pull request delta is now above zero (10). Feel free to make Feature/Balance PRs. |
LemonInTheDark
pushed a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Dec 12, 2021
* QDEL_IN harddel prevention (tgstation#60937) QDEL_IN could hardel if the timer was greater than 5 minutes (time for the qdel queue) we can use weakref to prevent this * QDEL_IN harddel prevention Co-authored-by: BraveMole <bsouchu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
QDEL_IN could hardel if the timer was greater than 5 minutes (time for the qdel queue)
we can use weakref to prevent this
Why It's Good For The Game
Changelog
🆑
code: prevent possible QDEL_IN harddel
/:cl: