Fixes some stupid behavior in computer hardware code. #61350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs post delete mannnnnnnnnnnnnnnnnn. Honestly this whole thing maybe needs ripped out, but I don't want to think about it anymore.
|
What's the draft for? |
Mothblocks
added
Fix
|
Code's bad. I'll fix it |
…ves from their computer, so we don't need to call procs with side effects on Destroy
|
Code was bad, I fixed it |
LemonInTheDark
added a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Dec 12, 2021
…tion#616) * Fixes some stupid behavior in computer hardware code. (tgstation#61350) * Fixes some stupid behavior in computer hardware code. Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
This was referenced Sep 1, 2022
Merged
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a bug mothblocks was having in #61313
Stop moving things post delete mannnnnnnnnnnnnnnnnn. Honestly this whole thing maybe needs ripped out, but I don't want to think about it anymore, and I don't like removing sane support for reacting to stuff. like, genuinely everything about how delete is handled sucks.
(I reread over #57387 while looking into this. Was wrong about that cell thing. sorry man.)
(I'll do this properly tomorrow. Maybe. Need to sleep on it)
Edit: Fixed
Why It's Good For The Game