Adds a dynamic config to cap the maximum threat level, max_threat_level #61869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mothblocks
requested changes
Oct 2, 2021
|
Does that var max out at 100? |
|
I asked what to default it to and Mothblocks said 100. |
Cyberboss
reviewed
Oct 3, 2021
|
@Cyberboss We don't need it there, there's a large amount of configuration options that aren't (considering everything that is a var is configurable). Good documentation is sound enough. |
Mothblocks
reviewed
Oct 3, 2021
tgstation-server
added a commit
that referenced
this pull request
Oct 4, 2021
LemonInTheDark
pushed a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Dec 12, 2021
…hreat_level (tgstation#948) * Adds a dynamic config to cap the maximum threat level, max_threat_level (tgstation#61869) Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com> * Adds a dynamic config to cap the maximum threat level, max_threat_level Co-authored-by: Iamgoofball <iamgoofball@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
See title.
Why It's Good For The Game
Config requested by the downstream.
Changelog
🆑
server: Dynamic now has an extra configuration value, max_threat_level. Defaults to 100 threat.
/:cl: