Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liches can no longer embed phylactery grenades inside of indestructible structures #62505

Merged
merged 3 commits into from Nov 4, 2021

Conversation

ATH1909
Copy link
Contributor

@ATH1909 ATH1909 commented Nov 1, 2021

About The Pull Request

Explosive lances can no longer embed grenades inside of indestructible objects (including structures), immortal mobs, or effects (like graffiti).

Why It's Good For The Game

persistent lich ban

I would've patched this out after the round regardless, but hey, making this PR now will make me look better in the ban appeal.

Note that the trick mentioned in that ban reason doesn't actually make you "completely unkillable". You can still die just like anyone else can, but (in theory), unless the crew has a soulstone handy, it's nigh-impossible for them to keep you down for longer than around 3 minutes. It's the difference between having the godmode flag and having free respawns (with a 3 minute cooldown, which is long enough for the crew to red alert, call the shuttle, and reach the point of no return while you're dead).

Changelog

🆑 ATHATH
fix: Liches (and mortals) can no longer use explosive lances to store grenade phylacteries inside of indestructible objects (including structures)), immortal mobs, or effects. As a side effect, you should no longer accidentally trigger your explosive lance on the wrong target by misclicking on a piece of graffiti during the heat of combat.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Nov 1, 2021
@MMMiracles
Copy link
Contributor

i think you should probably be arguing your case in the appeal and not the pr

if(mob_target.status_flags & GODMODE) //no embedding grenade phylacteries inside of ghost poly either
return
if(iseffect(AM)) //no accidentally wasting your moment of glory on graffiti
return
user.say("[war_cry]", forced="spear warcry")
explosive.forceMove(AM)
Copy link
Member

@Ghommie Ghommie Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the real problem. The grenade shouldn't be moved inside the target atom, but on its turf. This is so hacky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're driving it into them using your spear

Copy link
Member

@Ghommie Ghommie Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then have the grenade properly embedded into mobs instead of forcemoving it. As for movables and those mobs that don't support embedding, just move the grenade on the tile for the time being.

Copy link
Contributor Author

@ATH1909 ATH1909 Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that screws over advanced release grenade elances (especially anti-mech ones)

like, significantly enough to affect balance

my gbp can't take that, man

@optimumtact
Copy link
Member

when will you LEARN

@ShizCalev ShizCalev merged commit 36d33dd into tgstation:master Nov 4, 2021
github-actions bot added a commit that referenced this pull request Nov 4, 2021
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
…estructible structures (tgstation#1353)

* liches can no longer embed phylactery grenades inside of indestructible structures (tgstation#62505)

* buzzkills

* no effects either

* early return

* liches can no longer embed phylactery grenades inside of indestructible structures

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants