New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liches can no longer embed phylactery grenades inside of indestructible structures #62505
Conversation
i think you should probably be arguing your case in the appeal and not the pr |
code/game/objects/items/spear.dm
Outdated
if(mob_target.status_flags & GODMODE) //no embedding grenade phylacteries inside of ghost poly either | ||
return | ||
if(iseffect(AM)) //no accidentally wasting your moment of glory on graffiti | ||
return | ||
user.say("[war_cry]", forced="spear warcry") | ||
explosive.forceMove(AM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the real problem. The grenade shouldn't be moved inside the target atom, but on its turf. This is so hacky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're driving it into them using your spear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then have the grenade properly embedded into mobs instead of forcemoving it. As for movables and those mobs that don't support embedding, just move the grenade on the tile for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that screws over advanced release grenade elances (especially anti-mech ones)
like, significantly enough to affect balance
my gbp can't take that, man
when will you LEARN |
…estructible structures (tgstation#1353) * liches can no longer embed phylactery grenades inside of indestructible structures (tgstation#62505) * buzzkills * no effects either * early return * liches can no longer embed phylactery grenades inside of indestructible structures Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
About The Pull Request
Explosive lances can no longer embed grenades inside of indestructible objects (including structures), immortal mobs, or effects (like graffiti).
Why It's Good For The Game
I would've patched this out after the round regardless, but hey, making this PR now will make me look better in the ban appeal.
Note that the trick mentioned in that ban reason doesn't actually make you "completely unkillable". You can still die just like anyone else can, but (in theory), unless the crew has a soulstone handy, it's nigh-impossible for them to keep you down for longer than around 3 minutes. It's the difference between having the godmode flag and having free respawns (with a 3 minute cooldown, which is long enough for the crew to red alert, call the shuttle, and reach the point of no return while you're dead).
Changelog
🆑 ATHATH
fix: Liches (and mortals) can no longer use explosive lances to store grenade phylacteries inside of indestructible objects (including structures)), immortal mobs, or effects. As a side effect, you should no longer accidentally trigger your explosive lance on the wrong target by misclicking on a piece of graffiti during the heat of combat.
/:cl: