Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagonal camera sprites #62729

Merged
merged 1 commit into from Nov 12, 2021
Merged

Conversation

esainane
Copy link
Contributor

About The Pull Request

Diagonal camera sprites were flipped vertically, but not horizontally. This led to odd appearance of some diagonal cameras, mostly on TramStation.

#62601 flipped diagonal camera sprites vertically, but failed to do so horizontally. This flips the diagonal camera sprites horizontally as well.

GBP: No Update, please.

Why It's Good For The Game

TramStation in particular uses a lot of diagonal cameras, and floating cameras look wrong.

Changelog

馃啈
fix: Some diagonal cameras are back to being placed on walls, instead of floating.
/:cl:

These sprites were flipped vertically, but not horizontally. This led to
odd appearance of some diagonal cameras, mostly on TramStation.
@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Sprites A bikeshed full of soulless bikes. labels Nov 10, 2021
@Maurukas Maurukas added the GBP: No Update Prevent changes to the user's GBP balance from this PR label Nov 10, 2021
@ShizCalev ShizCalev merged commit 2935074 into tgstation:master Nov 12, 2021
@Googles-Hands
Copy link

@esainane
This did evidently not fix it
cam bug

Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Nov 22, 2021
These sprites were flipped vertically, but not horizontally. This led to
odd appearance of some diagonal cameras, mostly on TramStation.
Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants