Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowers kilo's bombcap multiplier #63750

Merged
merged 1 commit into from
Jan 27, 2022
Merged

lowers kilo's bombcap multiplier #63750

merged 1 commit into from
Jan 27, 2022

Conversation

Fikou
Copy link
Member

@Fikou Fikou commented Jan 1, 2022

About The Pull Request

uses the map json system to set kilo's bombcap multiplier to 0.7
maptainer approval:
image

Why It's Good For The Game

i think it's a creative way to nerf bombs a little on kilo

Changelog

馃啈
balance: lowers kilo's bombcap multiplier
/:cl:

@tgstation-server tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Map Edit Thank you for your tile-placing service. It's always appreciated. labels Jan 1, 2022
@Sparkezel
Copy link
Contributor

Sparkezel commented Jan 1, 2022

While its extremally hillarious I don't think that changing the balance of explosives is the right call to justify revelancy for kilo as an actual map. I understand that it was a lot of work to return Kilo back to more modern versions of tg, but it might be the time to let it go.

@IndieanaJones
Copy link
Contributor

I'd rather have Kilo than Tram.

@Pickle-Coding
Copy link
Contributor

I think it would be interesting if the bombcap multiplier was raised instead, because the station looks like it will crumble any second now.

@moocowswag
Copy link
Contributor

moocowswag commented Jan 2, 2022

Kilo has a lot of (bigger) issues and changing the balance of explosives on a single map will go wildly against consistency.

Also, will this only affect TTVs? Will it affect bomb assemblies bought from uplink? Will it affect large chemical bombs?

@Maurukas
Copy link
Member

Maurukas commented Jan 8, 2022

Based on this being tagged in so many issues, I'm assuming this is TM'd and actively being tested. Give me a ping when there's feedback.

@EOBGames
Copy link
Contributor

Based on this being tagged in so many issues, I'm assuming this is TM'd and actively being tested. Give me a ping when there's feedback.

It is being actively testmerged, I coordinated that with the keyholders prior to my current community break. I also had planned to personally observe rounds but my present situation somewhat precludes that. @Maurukas on second thought however I do wonder if this PR might be something we can't gather reasonable data on from testmerges, given its targeting quite a specific issue and will need a good sample size, and there's no guarantee we're getting Kilo running, or bombs being detonated on station, during the testmerge period. I'm thinking a full merge with a review period in a few months (let's call it 2 months from merge just for the sake of saying something concrete, with potential for extension if we've not got enough data by that point), where we can properly comb logs and quiz admins and the playerbase on whether they think it's had a positive effect might be a better way forward for this change. Your input welcomed, of course.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Jan 18, 2022
@tralezab tralezab merged commit 3ae8d94 into tgstation:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Map Edit Thank you for your tile-placing service. It's always appreciated. Stale Even the uncaring universe rejects you, why even go on Test Merge Candidate You're our unpaid test team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants