Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes adminwho report when you press it to the admins online at the time, along with to the game.txt log. #63972

Closed
wants to merge 2 commits into from

Conversation

Iamgoofball
Copy link
Contributor

@Iamgoofball Iamgoofball commented Jan 10, 2022

About The Pull Request

Makes adminwho report when you press it to the admins online at the time.

Why It's Good For The Game

Studies show that 75% of people who adminwho are about to do something they think they aren't supposed to do, and this will allow admins to catch those 75% in the act instead of before it can be stopped.
The other 25% are people about to ahelp, so this gives admins a period to mentally prepare themselves for the ahelp.

Changelog

🆑
admin: Makes adminwho report when you press it to the admins online at the time, and to the game log.
/:cl:

@tgstation-server tgstation-server added the Administration As generous gods, we have deigned to throw the jannies a bone label Jan 10, 2022
@Burgermancoding
Copy link
Contributor

Wouldn't this spam logs without a cooldown or delay or something

@JohnFulpWillard
Copy link
Member

@Kylerace
Copy link
Contributor

yes it would

@Iamgoofball
Copy link
Contributor Author

@Burgermancoding i could drop the log level to log_game() or something

@Bawhoppen
Copy link
Contributor

This is a targetted nerf towards me

@LemonInTheDark
Copy link
Member

LemonInTheDark commented Jan 10, 2022

Polling the admin team for interest on this, (I or my kyler shaped body double) will get back to you soon with results

@wesoda25
Copy link
Contributor

I do not want nor need this information, if a player wants to know who is online that is completely their own business.

@Iamgoofball Iamgoofball changed the title Makes adminwho report when you press it to the admins online at the time. Makes adminwho report when you press it to the admins online at the time, along with to the game.txt log. Jan 10, 2022
@Iamgoofball
Copy link
Contributor Author

@LemonInTheDark Worst case, I'll leave it at a log_game() for logging purposes during appeals.

@Burgermancoding
Copy link
Contributor

@Burgermancoding i could drop the log level to log_game() or something

I don't think there's any harm in it being logged, but I can't see that much of a use case for it honestly

@optimumtact
Copy link
Member

absolutely not

@Kylerace
Copy link
Contributor

i havent seen a single admin say this was wanted in any way and/or is useful information.
Screenshot_1734

@Iamgoofball
Copy link
Contributor Author

Iamgoofball commented Jan 10, 2022

so you don't want any indication of a player checking if admins are online period? alright, but i feel like you'd catch some people out in appeals with this information available

@wesoda25
Copy link
Contributor

Logging is unnecessary and guarantees false positives. The signal to noise ratio will be awful and the only usage this will see is admins guessing at the intention of a player. This is shit, if you are taking administrative action it should be by defensible metrics.

@Iamgoofball
Copy link
Contributor Author

the kinda scenario where i'd see this being useful is
toxins maxcapped science
whether or not it was accidental can be determined in this case by checking if they adminwho'd first before they blew up

@wesoda25
Copy link
Contributor

That is guessing at their intention.

@Iamgoofball
Copy link
Contributor Author

Iamgoofball commented Jan 10, 2022

You're stuck guessing at their intention anyways, science was maxcapped and not by an antag. An admin can't not act on a maxcap by a non-antag.

@wesoda25
Copy link
Contributor

And in such a situation we stick to reason. If there is obvious evidence that it was intentional we take action, otherwise it's status quo. Note/ban depending on how merciful the admin is, with a preference for documentation so that we can recognize a pattern of behavior if need be. Those bans have a much more stable foundation than a guess at intent due to someone pressing a button for what could have been many different reasons.

@ZeWaka
Copy link
Contributor

ZeWaka commented Jan 11, 2022

fun fact: goon logs this lol (admins can disable via preference)

i bet goof didn't even know that when stealing the idea from us 😎

@LemonInTheDark
Copy link
Member

Theft is the sincerest form of flattery

@PaulRitter
Copy link

/tg/ when goof actually has a good idea and they cant compute

@AffectedArc07
Copy link
Member

Commenting before reddit arrives.

@AffectedArc07
Copy link
Member

so you don't want any indication of a player checking if admins are online period? alright, but i feel like you'd catch some people out in appeals with this information available

Sidenote on this. We have a feature where we can bring the ticket window up for people, as well as tell if they close the window.

It is fucking hilarious when they say in an appeal "I didnt see a ticket window", when we have logs of them closing the window itself.

@optimumtact
Copy link
Member

Commenting before reddit arrives.

you were too late im afraid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration As generous gods, we have deigned to throw the jannies a bone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet