Skateboard content expansion pack #64269

itseasytosee · 2022-01-20T06:21:04Z

About The Pull Request

(Drafted because working on balance and looking for more rad ideas)

Makes skateboarding a hell of a lot cooler,

Lowers stamina cost for ollieing and grinding.
Makes collisions with other carbons always result in a wipeout no matter your stamina damage, colliding with a carbon will stun and knock them down for a short time (Stunned for the quarter of the length the skater is, and knockdown for have the length) The time is doubled if you collide with them while they are performing a sick grind.

Additionally grinding on top of stuff now has more functionality.
Grinding over a person that is laying down will deal significant damage with a high chance to wound at the cost of the skaters' stamina. For this to happen the person has to be laying down on the table, if they are standing they will simply collide as normal.
You can grind into a disposals bin.
Fixed action buttons always being red
fixed being able to ollie while unconscious/dead
Grinding over an object that is cuttable with a knife will lead to that item getting instantly cut! This includes cheese.

Implement further suggestions for grind functionality
Fix some known skateboard bugs
Tweak some stamina cost numbers, maybe stun times
Make a better changelog
Record a video where my character doesn't randomly turn invisible because of a memory shortage.

Why It's Good For The Game

jackass.mp4

dumped.mp4

bonk.mp4

Changelog

🆑 itseasytosee
expansion: Skateboards have been made considerably more radical
expansion: While grinding on a table with a skateboard, if you grind on top of somebody you are likely to hurt them quite badly
expansion: Colliding with another person will now always result in a crash, in which the person hit gets knocked over as well as the skater (protip: crash into someone while grind to double the stun time!)
expansion: Colliding with a disposal unit while grinding will result in you getting dunked in! Wack!
fix: fixed some skateboard related bugs, including the action button for ollieing always being red, and being able to ollie while dead
/:cl:

ArcaneMusic · 2022-01-20T06:58:18Z

"Who's ready to cut the cake?"
SPACE TONY HAWK GRINDS IN, OLLIES THROUGH THE AIR KNOCKING A CHILD DOWN, CRYING
"WooooOOOOOOOOOAH!"
THE HAWKSTER TURNS THE CAKE INTO 8 SLICES OF PERFECTLY CUT CONFECTIONARY, CHILDREN FLYING LEFT AND RIGHT TO DODGE THE ELDERLY SKATER'S REDICULOUS GRINDS
"DUUUUUUUUUUUUUDE"
THE LIVING LEGEND 360 NOSEGRINDS OUT AN AIRLOCK

timothymtorres · 2022-01-20T09:38:31Z

But can you grind inside a disposals half-pipe?

EricZilla · 2022-01-20T14:25:04Z

Always wished there was a positive skater quirk that would shorten your stuntime when you collide with walls (or even just airlocks)

Also you should make it so turning on a jetpack while on a skateboard makes it take less stamina lmao

itseasytosee · 2022-01-20T16:22:53Z

Added grinding into disposals

dumped.mp4

itseasytosee · 2022-01-20T18:41:10Z

Fixed action buttons always being red, fixed being able to ollie while unconscious/dead

bonk.mp4

Bawhoppen · 2022-01-20T19:25:05Z

Good PR, PKP would be proud 👍

itseasytosee · 2022-01-21T02:12:22Z

BadIsMyUsername · 2022-01-21T07:48:30Z

Added grinding into disposals

Can you grind OUT of disposals? Like if someone placed a table at the exit chute, would you continue on the epic grind? Imagine the skate parks possible if so...

Likteer · 2022-01-23T21:31:18Z

@itseasytosee

beauty.mp4

itseasytosee · 2022-01-23T21:47:49Z

@itseasytosee

Thank you, it was inspired

itseasytosee · 2022-01-23T21:50:10Z

This should be ready to go for maintainer review, I haven't collected any more ideas on par with the ability to cut cake by skateboarding over it. But I might come back to it and open another PR with more stuff.

as of now

tohg7 · 2022-01-23T21:54:45Z

This should be ready to go for maintainer review, I haven't collected any more ideas on par with the ability to cut cake by skateboarding over it. But I might come back to it and open another PR with more stuff.

as of now

One thing you could add is an expensive "Pro Skater" quirk that allows you to spawn with a skateboard in your bag and have reduced self-stun times when crashing into someone + increased stun times for the person you crashed into.

itseasytosee · 2022-01-23T22:07:54Z

This should be ready to go for maintainer review, I haven't collected any more ideas on par with the ability to cut cake by skateboarding over it. But I might come back to it and open another PR with more stuff.
as of now

One thing you could add is an expensive "Pro Skater" quirk that allows you to spawn with a skateboard in your bag and have reduced self-stun times when crashing into someone + increased stun times for the person you crashed into.

I thought about giving you a trait like that if you were wearing a backwards cap (or wearing a jetpack by someone's suggestion) but I think that's a PR for the future.

tohg7 · 2022-01-24T18:17:09Z

This should be ready to go for maintainer review, I haven't collected any more ideas on par with the ability to cut cake by skateboarding over it. But I might come back to it and open another PR with more stuff.
as of now

One thing you could add is an expensive "Pro Skater" quirk that allows you to spawn with a skateboard in your bag and have reduced self-stun times when crashing into someone + increased stun times for the person you crashed into.

I thought about giving you a trait like that if you were wearing a backwards cap (or wearing a jetpack by someone's suggestion) but I think that's a PR for the future.

I think there should be a crash stun-duration bonus for crashing into someone at high speeds, like from extinguisher boosting into them.

cacogen · 2022-01-26T03:38:59Z

rip
https://www.youtube.com/watch?v=NkRouk5b4ps

itseasytosee · 2022-01-26T18:26:16Z

Thanks oranges, ready for maintainer review

Rohesie

Hacky implementation, needs work.

code/modules/vehicles/vehicle_actions.dm

code/modules/vehicles/scooter.dm

code/game/atoms.dm

itseasytosee · 2022-02-07T20:28:16Z

Ok, the code is kicking my ass here. I'll clean up and get rid of the cutting feature. I promise to get back to it before I die.

code/game/atoms.dm

Rohesie · 2022-02-08T12:18:37Z

code/modules/vehicles/vehicle_actions.dm

+	. = ..()
+	if(.)


Does this completely remove the cooldown?

There was never a cooldown. The implementation of it was broken as next_ollie was never updated in relation to world.time I've removed the associated variable as well. If you are interested in adding a cooldown, although I don't see it as very necessary, it would not be difficult to implement.

code/modules/vehicles/scooter.dm

Rohesie · 2022-02-08T12:21:38Z

code/modules/vehicles/vehicle_actions.dm

 		var/obj/vehicle/ridden/scooter/skateboard/vehicle = vehicle_target
 		vehicle.obj_flags |= BLOCK_Z_OUT_DOWN
 		if (vehicle.grinding)
 			return
 		var/mob/living/rider = owner
 		var/turf/landing_turf = get_step(vehicle.loc, vehicle.dir)
-		rider.adjustStaminaLoss(vehicle.instability*2)
+		rider.adjustStaminaLoss(vehicle.instability* 0.75)


Is this buff entirely necessary? Can you explain why?

The original stamina cost was too high, the base skateboard can only grind over 4 tables maximum before having to take a break and even less if you want to chain skateboard grinds one after another because of the stamina cost of the ollie.
Makes it feel cooler, it should have always been this way.

Co-authored-by: Rohesie <rohesie@gmail.com>

Rohesie · 2022-02-08T16:05:37Z

Something tells me I'll regret this one.

skateboard stuff

c2f9269

tgstation-server added the Content Expansion label Jan 20, 2022

dumped

bc914bb

fixes + improvement

9dc66a5

balance tweak

6704607

itseasytosee marked this pull request as ready for review January 21, 2022 01:22

optimumtact closed this Jan 24, 2022

optimumtact reopened this Jan 26, 2022

Rohesie suggested changes Feb 1, 2022

View reviewed changes

Rohesie marked this pull request as draft February 1, 2022 03:17

itseasytosee added 2 commits February 4, 2022 15:25

easy fixes first

988c77b

Progress

7e215e5

github-actions bot requested a review from ninjanomnom February 5, 2022 01:33

redundincies and the like

5e060d9

and again

690e0e2

itseasytosee added 4 commits February 7, 2022 15:09

cleanup

d1aa4fa

sweep sweep sweep

8e31ff2

just the tip

32903cd

Finishing touch

793180d

itseasytosee marked this pull request as ready for review February 7, 2022 22:33

Rohesie reviewed Feb 8, 2022

View reviewed changes

code/game/atoms.dm Outdated Show resolved Hide resolved

Rohesie reviewed Feb 8, 2022

View reviewed changes

code/game/atoms.dm Outdated Show resolved Hide resolved

Rohesie reviewed Feb 8, 2022

View reviewed changes

code/modules/vehicles/scooter.dm Outdated Show resolved Hide resolved

Rohesie reviewed Feb 8, 2022

View reviewed changes

Rohesie marked this pull request as draft February 8, 2022 12:21

itseasytosee and others added 3 commits February 8, 2022 08:54

overaddition

90d4dee

mistake

e0e63d3

Apply suggestions from code review

35c7ff8

Co-authored-by: Rohesie <rohesie@gmail.com>

itseasytosee marked this pull request as ready for review February 8, 2022 15:13

Rohesie added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Feb 8, 2022

Rohesie merged commit 2468d51 into tgstation:master Feb 8, 2022

tgstation-server added a commit that referenced this pull request Feb 8, 2022

Automatic changelog generation for PR #64269 [ci skip]

f3aa49f

github-actions bot added a commit that referenced this pull request Feb 8, 2022

Updating GBP balances for #64269

b187255

SkyratBot mentioned this pull request Feb 8, 2022

[MIRROR] Skateboard content expansion pack [MDB IGNORE] Skyrat-SS13/Skyrat-tg#11382

Merged

5 tasks

Mothblocks added the Feature Exposes new bugs in interesting ways label Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skateboard content expansion pack #64269

Skateboard content expansion pack #64269

itseasytosee commented Jan 20, 2022 •

edited

ArcaneMusic commented Jan 20, 2022 •

edited

timothymtorres commented Jan 20, 2022

EricZilla commented Jan 20, 2022 •

edited

itseasytosee commented Jan 20, 2022

itseasytosee commented Jan 20, 2022

Bawhoppen commented Jan 20, 2022

itseasytosee commented Jan 21, 2022

BadIsMyUsername commented Jan 21, 2022

Likteer commented Jan 23, 2022

itseasytosee commented Jan 23, 2022

itseasytosee commented Jan 23, 2022

tohg7 commented Jan 23, 2022 •

edited

itseasytosee commented Jan 23, 2022 •

edited

tohg7 commented Jan 24, 2022

cacogen commented Jan 26, 2022

itseasytosee commented Jan 26, 2022

Rohesie left a comment

itseasytosee commented Feb 7, 2022

Rohesie Feb 8, 2022

itseasytosee Feb 8, 2022

Rohesie Feb 8, 2022

itseasytosee Feb 8, 2022

Rohesie commented Feb 8, 2022

Skateboard content expansion pack #64269

Skateboard content expansion pack #64269

Conversation

itseasytosee commented Jan 20, 2022 • edited

About The Pull Request

Why It's Good For The Game

Changelog

ArcaneMusic commented Jan 20, 2022 • edited

timothymtorres commented Jan 20, 2022

EricZilla commented Jan 20, 2022 • edited

itseasytosee commented Jan 20, 2022

itseasytosee commented Jan 20, 2022

Bawhoppen commented Jan 20, 2022

itseasytosee commented Jan 21, 2022

BadIsMyUsername commented Jan 21, 2022

Likteer commented Jan 23, 2022

itseasytosee commented Jan 23, 2022

itseasytosee commented Jan 23, 2022

tohg7 commented Jan 23, 2022 • edited

itseasytosee commented Jan 23, 2022 • edited

tohg7 commented Jan 24, 2022

cacogen commented Jan 26, 2022

itseasytosee commented Jan 26, 2022

Rohesie left a comment

Choose a reason for hiding this comment

itseasytosee commented Feb 7, 2022

Rohesie Feb 8, 2022

Choose a reason for hiding this comment

itseasytosee Feb 8, 2022

Choose a reason for hiding this comment

Rohesie Feb 8, 2022

Choose a reason for hiding this comment

itseasytosee Feb 8, 2022

Choose a reason for hiding this comment

Rohesie commented Feb 8, 2022

itseasytosee commented Jan 20, 2022 •

edited

ArcaneMusic commented Jan 20, 2022 •

edited

EricZilla commented Jan 20, 2022 •

edited

tohg7 commented Jan 23, 2022 •

edited

itseasytosee commented Jan 23, 2022 •

edited