Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooch no longer heals assistants. #64693

Merged
merged 2 commits into from Feb 8, 2022
Merged

Conversation

Iamgoofball
Copy link
Contributor

About The Pull Request

Hooch no longer heals assistants.

Why It's Good For The Game

Nerfing assistants is good, actually.

Changelog

🆑
del: Hooch no longer heals assistants.
/:cl:

@tgstation-server tgstation-server added the Removal This was too fun, too fun! I'm turning this feature around label Feb 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

You currently have a negative Fix/Feature pull request delta of -6. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@oklews
Copy link

oklews commented Feb 5, 2022

Hooch gets you shitfaced, if getting shitfaced is the cost of healing, it's hardly worth it. Especially considering the potential for a vomit stun.

@theta006
Copy link

theta006 commented Feb 5, 2022

cringe

@Sealed101
Copy link
Member

lmao

@Donpedrito
Copy link
Contributor

“Why is this PR good for the game?”
“Well, because it does a thing that’s good for the game.”
??? That’s not a reason at all. I’m not even sure whether I agree with this change but sarcastic descriptions don’t really help your case.

@MaineTheMan
Copy link

goof why have you become such a lameo

@jughu
Copy link
Contributor

jughu commented Feb 5, 2022

Ok if hooch should stop healing assistants
then banana honk shouldn't heal clowns
then blank paper shouldn't heal mimes
then wizard fizz shouldn't heal wizards
then doctor delight shouldn't heal anyone

@ExcessiveUseOfCobblestone
Copy link
Contributor

is there some sort of antihol/hooch combo or something

@jughu
Copy link
Contributor

jughu commented Feb 5, 2022

theres a quirk that makes you resistant vs drunkiness

@ATH1909
Copy link
Contributor

ATH1909 commented Feb 5, 2022

theres a quirk that makes you resistant vs drunkiness

but it's shit because it's mutually exclusive with light drinker and makes it harder to bar rp (bc it's harder to get drunk, which is what you're there at the bar for)

Copy link
Member

@Rohesie Rohesie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove TRAIT_GREYTIDE_METABOLISM entirely, else it will be dead code besides an examine message.

If no maintainers block this PR I'm merging it.
Assistants shouldn't have any in-game benefits over other jobs.

@Rohesie Rohesie marked this pull request as draft February 5, 2022 21:41
@thgvr
Copy link
Contributor

thgvr commented Feb 5, 2022

ided

@Sealed101
Copy link
Member

there's quite a few drinks that heal specific jobs, why is assistant getting left out? sure not all jobs have em, but then you have doc's delight that heals everybody, and some basic juices and milk heal you as well. plus hooch iirc is the strongest job-specific drink out there, you can barely take like a sip each 5 minutes to avoid liver failure and toxin build up

@Pickle-Coding
Copy link
Contributor

Assistants do not do anything to merit a drink that gives them an advantage that other roles won't get.

@necromanceranne
Copy link
Contributor

is there some sort of antihol/hooch combo or something

lf you can get antihol you can get anything more useful. And doubtful given antihol purges alcohol reagents.

@jughu
Copy link
Contributor

jughu commented Feb 6, 2022

image

JUst this quirk.

@Mosslick
Copy link

Mosslick commented Feb 6, 2022

Ided

@realthomas69
Copy link

What a fucking loser

@realthomas69
Copy link

assistants are just going to break into chem to make their powergame heal juice now

@AlinaStarkova
Copy link
Contributor

assistants are just going to break into chem to make their powergame heal juice now

while i do not have any opinions on this PR either way since i never used this feature, your argument here is a really bad one: "greytiders will just break into places to get what they want, so you may as well just give them it by default"..... by this logic we should have assistants spawn with the caps spare since they will just break in and steal it every round anyway, or an egun, or a maxcap, or the CEs power tools and insuls

@necromanceranne
Copy link
Contributor

There are a multitude of other ghetto healing options. Hooch is really not one of the better ones.

@realthomas69
Copy link

while i do not have any opinions on this PR either way since i never used this feature, your argument here is a really bad one: "greytiders will just break into places to get what they want, so you may as well just give them it by default"..... by this logic we should have assistants spawn with the caps spare since they will just break in and steal it every round anyway, or an egun, or a maxcap, or the CEs power tools and insuls

we do not give it to them by default, assistants do not spawn with hooch, your strawman sucks

@B00tz
Copy link

B00tz commented Feb 6, 2022

If no maintainers block this PR I'm merging it. Assistants shouldn't have any in-game benefits over other jobs.

Why not? Sec heals from donuts, there's all the other drinks that heal people based on their job why should assistants be denied their roleplay meme buff? Traitors arn't given anything to boost them why not since there is Wizz Fizz and changeling sting?

If you can't think of anything past grey man bad maybe go back to the chalkboard before merging.

@AlinaStarkova
Copy link
Contributor

while i do not have any opinions on this PR either way since i never used this feature, your argument here is a really bad one: "greytiders will just break into places to get what they want, so you may as well just give them it by default"..... by this logic we should have assistants spawn with the caps spare since they will just break in and steal it every round anyway, or an egun, or a maxcap, or the CEs power tools and insuls

we do not give it to them by default, assistants do not spawn with hooch, your strawman sucks

its not a strawman, and it doesnt matter if you spawn with hooch or not, the fact assistants have access to a healing chem without the need to actually use any chemistry is itself "having it by default"

engineers dont spawn with insuls, but they have access to them. that other jobs dont. likewise hooch only works on assistants so its unique to them, in fact its worse because insuls can be stolen, healing from hooch cannot. job specific healing is bad, it makes medbay useless and makes actual healing chems pointless. if tiders want healing they should be asking chemist to make a bunch of healing patches or pills

@AlinaStarkova
Copy link
Contributor

If no maintainers block this PR I'm merging it. Assistants shouldn't have any in-game benefits over other jobs.

Why not? Sec heals from donuts, there's all the other drinks that heal people based on their job why should assistants be denied their roleplay meme buff? Traitors arn't given anything to boost them why not since there is Wizz Fizz and changeling sting?

If you can't think of anything past grey man bad maybe go back to the chalkboard before merging.

i think the main difference there is that assistants arent supposed to be a proper job, having perks like that makes people choose assistant over actual jobs, meaning said jobs dont actually get filled. tbh i suggested once having a cap for assistant based on round pop but that was denied, not as big of an issue recently as i havent seen 20 tider rounds recently, but having perks over most other jobs would change that, hooch itself isnt a big enough perk on its own but they add up, at first its just a little perk here and there, the next its one massive list of perks thats too good to pass up (also im only aware of sec having healing foods/drinks, and on that note im against that too, it ruins the point of medbay)

@catrock31
Copy link

If no maintainers block this PR I'm merging it. Assistants shouldn't have any in-game benefits over other jobs.

Why not? Sec heals from donuts, there's all the other drinks that heal people based on their job why should assistants be denied their roleplay meme buff? Traitors arn't given anything to boost them why not since there is Wizz Fizz and changeling sting?
If you can't think of anything past grey man bad maybe go back to the chalkboard before merging.

i think the main difference there is that assistants arent supposed to be a proper job, having perks like that makes people choose assistant over actual jobs, meaning said jobs dont actually get filled. tbh i suggested once having a cap for assistant based on round pop but that was denied, not as big of an issue recently as i havent seen 20 tider rounds recently, but having perks over most other jobs would change that, hooch itself isnt a big enough perk on its own but they add up, at first its just a little perk here and there, the next its one massive list of perks thats too good to pass up (also im only aware of sec having healing foods/drinks, and on that note im against that too, it ruins the point of medbay)

what are the other perks of assistants other then this one little thing?

@Ryll-Ryll
Copy link
Contributor

Personally I prefer crewmembers being able to perform simple low-stakes healing on themselves by scavenging over forcing them to always crowd medbay for surgery. It's not like you can treat wounds or brain traumas or bloodloss with this. I'm not gonna block it but I think the game should have more improvised fixes that encourage people to scavenge rather than removing them

@Pickle-Coding
Copy link
Contributor

Personally I prefer crewmembers being able to perform simple low-stakes healing on themselves by scavenging over forcing them to always crowd medbay for surgery. It's not like you can treat wounds or brain traumas or bloodloss with this. I'm not gonna block it but I think the game should have more improvised fixes that encourage people to scavenge rather than removing them

Doesn't eating food already fill that role?

@jughu
Copy link
Contributor

jughu commented Feb 7, 2022

Food/drinks are in the same box

@drIcepop
Copy link

drIcepop commented Feb 7, 2022

Please get rid of warm donk pocket omnizine, it's letting assistants heal themselves too easily!!

@Sealed101
Copy link
Member

if you dont find it amusing that an assistant can grind a spray can with some enzyme and then drink up the resulting """ beverage""" to heal a few scratches while also drinking welding fuel im sorry for your loss

@SinfulBliss
Copy link

SinfulBliss commented Feb 7, 2022

quad sec, mime's silencer, med doc's doctor's delight, engi's screwdriver, clown's banana juice, chaplain's trappist beer - this is by no means some unique advantage assistants get. it's present for a vast variety of jobs.

@AlinaStarkova
Copy link
Contributor

Please get rid of warm donk pocket omnizine, it's letting assistants heal themselves too easily!!

difference is everyone has access to donk pockets, its not exclusive to tiders, as Rhosie stated, tiders shouldnt have perks over other jobs, even minor ones, because assistant is supposed to be a fall back job, we cant afford to have half the playerbase become greytide mains, else the jobs will never be filled

quad sec, mime's silencer, med doc's doctor's delight, engi's screwdriver, clown's banana juice, chaplain's trappist beer - this is by no means some advantage assistants get. it's present for a vast variety of jobs.

the real issue is that hooch spawns in maint, its not even a rare or even uncommon spawn from what i understand, usually multiple spawn every round

@SinfulBliss
Copy link

the real issue is that hooch spawns in maint, its not even a rare or even uncommon spawn from what i understand, usually multiple spawn every round

it actually is rare and uncommon. don't take my word for it though - go scour maints as assistant and see how long it takes to find. guarantee it will be significantly longer than it takes to make those simple drinks in the bar (unlimited btw)

@ExcessiveUseOfCobblestone
Copy link
Contributor

When ATH makes a RP post instead of a mechanical post you know it needs to be removed

@ExcessiveUseOfCobblestone
Copy link
Contributor

Also stop full quoting your text walls omg

@Mickyan
Copy link
Contributor

Mickyan commented Feb 7, 2022

Anyone who mentioned drunken resilience as being anywhere equivalent to hooch or manly dorf healing needs to go back to primary school and learn some math, your stupid takes only make me regret making those quirks and now they're going to be on the chopping block because someone is going to take you seriously

@jughu
Copy link
Contributor

jughu commented Feb 7, 2022

because they do play a factor when yknow you have healing alcohol and you get more healing from your quirk, but again quirk wouldn't be the issue still only the numbers of the drinks itself would need to be adjusted

@necromanceranne
Copy link
Contributor

I'm not gonna block it but I think the game should have more improvised fixes that encourage people to scavenge rather than removing them

I do think this still exists currently beyond just alcohol based healing. Many vendors provide access to food based healing, light as it is, and there exist places like abandoned bar to scavange bits and pieces for healing drinks/reagents.

Maybe it would be a good idea to look at a reagent like miner's salve and give it bit if a buff. Maybe even make that equivalent to the healing hooch gave assistants.

@Maurukas
Copy link
Member

Maurukas commented Feb 8, 2022

Can someone explain why I am being pinged with literal wall of text PRs about Hooch? I'm being asked to consider #64741 as an alternative to this PR, and this PR does not even have have its description filled out completely. What is this trying to accomplish and why?

This looks like a noxious removal of a minor quirk of the game without any justification.

@thgvr
Copy link
Contributor

thgvr commented Feb 8, 2022

Should also get all of the bar drinks that heal you, and engineer liver traits. :)

@Rohesie
Copy link
Member

Rohesie commented Feb 8, 2022

I let this run a little bit longer than I should, merging it now.

To clarify, this is not an attempt to buff medbay as Shaps suggested. Improvised fixes and food medicine are very good in my book (tomato juice, tea, doc's delight, donk pockets and so on).
This is not against drinks having healing or other properties either.
And definitely this is not against the theme of concocting hooch to get some benefits out of it.

The reason I am interested in the PR and see it favorably is because of the firm belief that the Assistant job should have no in-game benefits whatsoever over other jobs. If hooch healed everyone or even another job (that made sense) I'd worry less about it.
Other drinks, food and stuff are fine as well.

Hopefully if something like this is re-added, it comes in a package that works for everyone, and not just Assistants.

@qbmax32
Copy link

qbmax32 commented Feb 8, 2022

cope assistant shitters

@SethLafuente
Copy link
Contributor

I wish goof said more than a meme answer when it comes to "why this is good for the game"

then people would complain less I don't even know why maintainers dont tell him to change it

goof please give an actual reason you are only harming your reputation by giving shit answers like "Nerfing assistants is good, actually."

@Iamgoofball
Copy link
Contributor Author

we recently received a video of greytiders and common tactics they abuse to get an edge in combat over general crewmembers for the purposes of griefing their rounds

changes like the hooch healing removal and the bugfix of spears w/o craft timers are targeted changes to discourage that kind of greytide gameplay in players

@Iamgoofball
Copy link
Contributor Author

ill be honest i figured everyone had seen the video by the point the PR went up and that players were well aware of the greytide problems going on lmao

@SethLafuente
Copy link
Contributor

havent seen it maybe you should link the video to the reason why is good and the explanation you just gave me

@jughu
Copy link
Contributor

jughu commented Feb 10, 2022

just wait till goof hears about the gamermos internals which doesnt let you get stunned and heals you

optimumtact pushed a commit that referenced this pull request May 3, 2022
…ood for the Game Section (#66426)


About The Pull Request

This PR:

    Moves the part explaining why you should justify your changes to its own section in contributing.md, and expands on it greatly.
    Adjusts the pull request template to place a further emphasis on arguing for why your changes are good in the Why It's Good For The Game section.

Why It's Good For The Game

Changes that piss people off because of x, y, and z can have merit in spite of that, but that merit should be explained. Period. There is no downside to putting in a reasonable effort to justify why what you're doing will improve the game.

Lazy, low effort explanations for the merits of your changes, wholly unsuited to the level of justification needed to be considered adequate by anyone, should no longer be accepted into our codebase until they are at the very least adequate. This isn't stuff like bugfixes or tiny features no one has any problems with, this is for stuff like #58038 or #62947 or #57831 or #64693 which have either abysmal justification for their changes or are outright refusing any real attempt at a justification relative to their effects.

Proper justification for controversial PRs should be required even if you have explicit support of a maintainer, or maintainers, or a head coder, or multiple head coders, or the entirety of humanity, or God himself before the pr is even made. Because when a PR is merged, the argument for its changes become the codebases argument instead of just the authors. Thus all potentially controversial changes should have a level of effort put into their arguments proportional to their effect on the game.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal This was too fun, too fun! I'm turning this feature around
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet