-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a roundend threat log, showing player threat edits #65417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this an optional argument on create_threat
instead? Such that the "Threat +num - " part is automatic?
Bonus points if you do this for standard threat_log
too.
I tried following through with this as much as I could, I added a new log_threat thing to pass through and tried to make both threat_log and roundend_threat_log use it. Let me know if you're fine with this or wanted something else. |
About The Pull Request
Hacking comms consoles and Revs winning both edit the station's threat, but aren't listed anywhere. There's other ways to edit threat, mostly through admins, rulesets refunding themselves, and roundstart threat donating to midround. I didn't want to log literally everything on the report since I feel that would clutter it too much and make admins not want to edit threat so they wouldn't be revealed adminbussing.
What it looks like in-game to admins and players
Why It's Good For The Game
Closes #63967
Makes it obvious why there's more threat than there should have to players.
Changelog
馃啈
qol: Revs/Traitors adding more threat is now shown on the roundend report.
/:cl: