Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping Access Helpers #65580

Merged
merged 3 commits into from Mar 22, 2022
Merged

Mapping Access Helpers #65580

merged 3 commits into from Mar 22, 2022

Conversation

dragomagol
Copy link
Member

@dragomagol dragomagol commented Mar 20, 2022

About The Pull Request

image
ABOVE NOT INCLUDED IN PR (This is what your map could look like!)

Creates a series of mapping helpers that modify door access:
all -> req_access_txt
any-> req_one_access_txt

  • These are all single access, and only for station accesses (so not CentCom or space ruin accesses).
  • They're grouped by department in the same way as ID access (maintenance access is engineering, the vault is supply).
  • They can be stacked, meaning multiple access helpers on the same door will combine.

This also makes mapping airlock helpers run LateInitialize instead of Initialize. I don't expect this to make any significant changes to existing airlock helpers.

Why It's Good For The Game

These helpers are designed to reduce the amount of varediting needing to be done to station doors when mapping. Having dozens of door presets and needing to modify them slightly is CBT, especially when you're just working with numbers. This gives door access a good, visible representation when mapping.

Changelog

No player-facing changes

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Mar 20, 2022
@Ryll-Ryll Ryll-Ryll merged commit a5d6503 into tgstation:master Mar 22, 2022
github-actions bot added a commit that referenced this pull request Mar 22, 2022
@dragomagol dragomagol deleted the access-helpers branch March 22, 2022 05:09
LordVollkorn pushed a commit to LordVollkorn/ChemistryStation that referenced this pull request Apr 6, 2022
* Create mapping helpers for airlock access

* Finish implementing accesses

* you saw nothing
@timothymtorres
Copy link
Member

Amazing! This was a long overdue QoL for mappers.

@MTandi
Copy link
Contributor

MTandi commented Jun 7, 2022

@dragomagol why did you do this for obj/machinery/door/airlock rather than for obj/machinery/door? You can't use this for windoors because of this.

@dragomagol
Copy link
Member Author

@MTandi Because I made them for airlocks, not windoors.

unit0016 added a commit to unit0016/TetraStation-1 that referenced this pull request Jan 15, 2023
PORTS:
tgstation/tgstation#55799
tgstation/tgstation#60675
tgstation/tgstation#65580
tgstation/tgstation#65581
tgstation/tgstation#70861

Greyscales both access and mail helpers because I passionately hate the LAME type of RSC bloat
TamberP pushed a commit to TetraStation/TetraStation that referenced this pull request Feb 12, 2023
PORTS:
tgstation/tgstation#55799
tgstation/tgstation#60675
tgstation/tgstation#65580
tgstation/tgstation#65581
tgstation/tgstation#70861

Greyscales both access and mail helpers because I passionately hate the LAME type of RSC bloat
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Mar 12, 2023
* Create mapping helpers for airlock access

* Finish implementing accesses

* you saw nothing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants