New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping Access Helpers #65580
Merged
Merged
Mapping Access Helpers #65580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomagol
requested review from
Twaticus,
Krysonism,
Imaginos16 and
Cyberboss
as code owners
March 20, 2022 01:38
LordVollkorn
pushed a commit
to LordVollkorn/ChemistryStation
that referenced
this pull request
Apr 6, 2022
* Create mapping helpers for airlock access * Finish implementing accesses * you saw nothing
Amazing! This was a long overdue QoL for mappers. |
@dragomagol why did you do this for |
@MTandi Because I made them for airlocks, not windoors. |
unit0016
added a commit
to unit0016/TetraStation-1
that referenced
this pull request
Jan 15, 2023
PORTS: tgstation/tgstation#55799 tgstation/tgstation#60675 tgstation/tgstation#65580 tgstation/tgstation#65581 tgstation/tgstation#70861 Greyscales both access and mail helpers because I passionately hate the LAME type of RSC bloat
TamberP
pushed a commit
to TetraStation/TetraStation
that referenced
this pull request
Feb 12, 2023
PORTS: tgstation/tgstation#55799 tgstation/tgstation#60675 tgstation/tgstation#65580 tgstation/tgstation#65581 tgstation/tgstation#70861 Greyscales both access and mail helpers because I passionately hate the LAME type of RSC bloat
LemonInTheDark
pushed a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Mar 12, 2023
* Create mapping helpers for airlock access * Finish implementing accesses * you saw nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ABOVE NOT INCLUDED IN PR (This is what your map could look like!)
Creates a series of mapping helpers that modify door access:
all -> req_access_txt
any-> req_one_access_txt
This also makes mapping airlock helpers run LateInitialize instead of Initialize. I don't expect this to make any significant changes to existing airlock helpers.
Why It's Good For The Game
These helpers are designed to reduce the amount of varediting needing to be done to station doors when mapping. Having dozens of door presets and needing to modify them slightly is CBT, especially when you're just working with numbers. This gives door access a good, visible representation when mapping.
Changelog
No player-facing changes