Adds the Artifact of Kin as a station trait. #66034

TemporalOroboros · 2022-04-07T05:23:23Z

About The Pull Request

Adds a station trait that makes dynamic pick a single antagonist for roundstart, latejoin, and midround.

Why It's Good For The Game

I find the image of the station getting invaded by a steady stream of provocateurs amusing.

Changelog

🆑
expansion: Very occasionally a few types of antagonists will be chosen to be the only types of antagonists that shows up that shift.
/:cl:

IndieanaJones · 2022-04-07T05:37:55Z

I really like this. A lot of station traits don't really do much of anything except offset things at roundstart, but this is the kind of round variation I think the system could really use.

Colovorat · 2022-04-07T06:21:27Z

Shrine of Order moment

Y0SH1M4S73R · 2022-04-07T07:13:33Z

hmm yes which antags will be the only antags that can spawn during this Impending Doom round?
Roundstart? Hmm... Thief
Latejoin? How about..... Thief
Midround? Let's go with......... Thief

On a more serious note, this trait rolling a heretic-centric round would be very interesting.

SkeletalElite · 2022-04-07T07:24:08Z

What happens if the roll is something where 1 roll is hte max allowed like cult, nukies, revs? Will it allow additional rolls of those to occur?

TemporalOroboros · 2022-04-07T07:40:15Z

What happens if the roll is something where 1 roll is hte max allowed like cult, nukies, revs? Will it allow additional rolls of those to occur?

Given its current state. Yes.

TemporalOroboros · 2022-04-07T07:42:25Z

There is a slight issue that will need to be fixed before merge. If the roundstart picker doesn't roll a high impact ruleset it's possible for latejoin or midround to roll one and lock itself out of spending threat. I'll need to figure out a way to prevent that from happening.

TemporalOroboros · 2022-04-07T07:44:15Z

Basically:

Artifact of Kin station trait is enabled.
Threat generates too low to allow multiple high impact rulesets.
Roundstart picks traitors. All roundstart threat is spent on traitors. Since they are not a high impact ruleset latejoin and midrounds can roll high impact rulesets.
Midrounds roll wizard.
Midrounds continue to try to roll wizard. As it is a high impact ruleset, a high impact ruleset was already picked (the first wizard), and the threat is too low to make multiple high impacts possible normally the wizard is blocked.
No more midround antags.

TemporalOroboros · 2022-04-07T07:48:34Z

Fat fingered close trying to comment. Ignore that.

TemporalOroboros · 2022-04-07T09:42:31Z

That should make midrounds and latejoins picking high impact rulesets not lock themselves out.

Mothblocks · 2022-04-07T10:08:15Z

Labelling DNM until Dynamic 2022 Part 1 is merged

Mothblocks

Does this respect LONE_RULESET?

This needs to be split out into a datum handler or similar that listens to signals so that we don't have all this code in Dynamic.

Also, depending on how this works, this is not going to function well with Dynamic 2022 at all, since Dynamic 2022's first midround is basically always a sleeper agent.

This needs some marker in the dynamic.json log output so I know to completely throw these out when analyzing rounds.

Mothblocks · 2022-04-07T10:08:43Z

code/game/gamemodes/dynamic/dynamic.dm

@@ -63,7 +63,7 @@ GLOBAL_VAR_INIT(dynamic_forced_threat_level, -1)
 	/// How many percent of the rounds are more peaceful.
 	var/peaceful_percentage = 50
 	/// If a high impact ruleset was executed. Only one will run at a time in most circumstances.
-	var/high_impact_ruleset_executed = FALSE
+	var/high_impact_ruleset_executed = NONE


You need to change the documentation for this to include that it is a bitfield, and then link to the flags it can use.

Mothblocks · 2022-04-07T10:09:06Z

code/game/gamemodes/dynamic/dynamic.dm

-						continue
+				if (rule.flags & HIGH_IMPACT_RULESET)
+					if (threat_level < GLOB.dynamic_stacking_limit && GLOB.dynamic_no_stacking)
+						if (high_impact_ruleset_executed & (HAS_TRAIT(SSstation, STATION_TRAIT_ARTIFACT_OF_KIN) ? ~EXECUTED_LATEJOIN_HIGH_IMPACT_RULESET : ALL))


Combine these into one.

Mothblocks · 2022-04-07T10:12:38Z

There's also a huge chance this just makes Dynamic code more annoying to deal with and manage and I might just scrap it entirely, but I'm not there yet.

Wallemations · 2022-04-07T15:52:55Z

Soon we'll get Artifact of Command
Choose Your Own Antag adventure

D4C-420 · 2022-04-07T16:38:58Z

Artifact of swarms
Twice the Antags

Fikou · 2022-04-08T07:43:02Z

can we name it something that makes sense to people who didnt play a video game

TemporalOroboros · 2022-04-11T04:03:24Z

I'm honestly going to wait on this until Dynamic 2022 is merged. Then I'll see where I can go with it.

Mothblocks · 2022-04-11T04:08:42Z

Gonna anti-stale this until Dynamic 2022 part 1 is in

Mothblocks · 2022-04-29T21:15:22Z

Artifact of kin PR is that way #66034

Mothblocks · 2022-05-02T20:51:22Z

God damnit

TheSilverNuke · 2022-05-05T08:04:32Z

can we name it something that makes sense to people who didnt play a video game

What game is this even from

Annihilit · 2022-05-13T06:02:19Z

God damnit

Well now you hopefully see how i managed to mess it up in the first place lol

private-tristan · 2022-05-16T02:13:59Z

What game is this even from

Risk of Rain

TemporalOroboros · 2022-05-19T10:37:49Z

Alright. Let's give this another go.

TemporalOroboros · 2022-05-19T10:42:17Z

Needs mapping and spriting.

Mothblocks · 2022-05-19T16:14:44Z

Also, depending on how this works, this is not going to function well with Dynamic 2022 at all, since Dynamic 2022's first midround is basically always a sleeper agent.

This is still a pretty nasty gotcha I think

TemporalOroboros · 2022-05-19T17:19:38Z

Also, depending on how this works, this is not going to function well with Dynamic 2022 at all, since Dynamic 2022's first midround is basically always a sleeper agent.

This is still a pretty nasty gotcha I think

Yeah. I've set it to just pick a ruleset for midrounds and then ensure that only that midround can spawn. The result should be less weighted towards sleeper agents than locking in the first picked ruleset. This is still not optimal, since it's possible for it to pick something like nuke ops and then the station has to sit around for the heavy chance to build up high enough for it to roll. Haven't put much thought into how the middle ground would be implemented, but I'm sure there is one.

TemporalOroboros · 2022-05-19T17:20:29Z

On the other hand. Rolling something expensive and waiting for the director to roll it does line up pretty nicely with the RoR experience.

github-actions · 2022-05-31T00:26:06Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

TemporalOroboros requested a review from Mothblocks as a code owner April 7, 2022 05:23

tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Content Expansion labels Apr 7, 2022

TemporalOroboros closed this Apr 7, 2022

TemporalOroboros reopened this Apr 7, 2022

Mothblocks added the Do Not Merge You must have really upset someone label Apr 7, 2022

Mothblocks requested changes Apr 7, 2022

View reviewed changes

Mothblocks marked this pull request as draft April 7, 2022 10:12

Mothblocks self-assigned this Apr 7, 2022

Mothblocks added the RED LABEL This PR will not auto stale, this label should be green at all times. label Apr 11, 2022

Mothblocks added Feature Exposes new bugs in interesting ways and removed Content Expansion labels Apr 24, 2022

TemporalOroboros mentioned this pull request May 2, 2022

Dynamic 2022, Part 1 - Redesigning midround rolls (Midrounds happen far more frequently now, and scale their power over time) #65997

Merged

7 tasks

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 19, 2022

TemporalOroboros closed this May 19, 2022

TemporalOroboros force-pushed the artifact-of-kin branch from 56b41e0 to afd2fc7 Compare May 19, 2022 07:53

TemporalOroboros added 5 commits May 19, 2022 01:15

mapping signals

0b6c3d4

ruin spawn station trait

3a7bd2e

As anything map template preloads

bad3c62

Artifact of Kin

31d3497

One more hook

124aa3e

TemporalOroboros reopened this May 19, 2022

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 19, 2022

github-actions bot requested review from Cyberboss, Mothblocks and ninjanomnom May 19, 2022 10:38

=

78e31ce

Mothblocks removed Do Not Merge You must have really upset someone RED LABEL This PR will not auto stale, this label should be green at all times. labels May 19, 2022

Merge branch 'master' into artifact-of-kin

bc513c3

github-actions bot added Stale Even the uncaring universe rejects you, why even go on Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts labels May 31, 2022

optimumtact closed this Jun 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds the Artifact of Kin as a station trait. #66034

Adds the Artifact of Kin as a station trait. #66034

TemporalOroboros commented Apr 7, 2022 •

edited

IndieanaJones commented Apr 7, 2022

Colovorat commented Apr 7, 2022

Y0SH1M4S73R commented Apr 7, 2022

SkeletalElite commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022 •

edited

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

Mothblocks commented Apr 7, 2022

Mothblocks left a comment

Mothblocks Apr 7, 2022

Mothblocks Apr 7, 2022

Mothblocks commented Apr 7, 2022

Wallemations commented Apr 7, 2022

D4C-420 commented Apr 7, 2022

Fikou commented Apr 8, 2022

TemporalOroboros commented Apr 11, 2022

Mothblocks commented Apr 11, 2022 •

edited

Mothblocks commented Apr 29, 2022

Mothblocks commented May 2, 2022

TheSilverNuke commented May 5, 2022

Annihilit commented May 13, 2022

private-tristan commented May 16, 2022

TemporalOroboros commented May 19, 2022

TemporalOroboros commented May 19, 2022

Mothblocks commented May 19, 2022

TemporalOroboros commented May 19, 2022

TemporalOroboros commented May 19, 2022

github-actions bot commented May 31, 2022

Adds the Artifact of Kin as a station trait. #66034

Adds the Artifact of Kin as a station trait. #66034

Conversation

TemporalOroboros commented Apr 7, 2022 • edited

About The Pull Request

Why It's Good For The Game

Changelog

IndieanaJones commented Apr 7, 2022

Colovorat commented Apr 7, 2022

Y0SH1M4S73R commented Apr 7, 2022

SkeletalElite commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022 • edited

TemporalOroboros commented Apr 7, 2022

TemporalOroboros commented Apr 7, 2022

Mothblocks commented Apr 7, 2022

Mothblocks left a comment

Choose a reason for hiding this comment

Mothblocks Apr 7, 2022

Choose a reason for hiding this comment

Mothblocks Apr 7, 2022

Choose a reason for hiding this comment

Mothblocks commented Apr 7, 2022

Wallemations commented Apr 7, 2022

D4C-420 commented Apr 7, 2022

Fikou commented Apr 8, 2022

TemporalOroboros commented Apr 11, 2022

Mothblocks commented Apr 11, 2022 • edited

Mothblocks commented Apr 29, 2022

Mothblocks commented May 2, 2022

TheSilverNuke commented May 5, 2022

Annihilit commented May 13, 2022

private-tristan commented May 16, 2022

TemporalOroboros commented May 19, 2022

TemporalOroboros commented May 19, 2022

Mothblocks commented May 19, 2022

TemporalOroboros commented May 19, 2022

TemporalOroboros commented May 19, 2022

github-actions bot commented May 31, 2022

TemporalOroboros commented Apr 7, 2022 •

edited

TemporalOroboros commented Apr 7, 2022 •

edited

Mothblocks commented Apr 11, 2022 •

edited