Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kilostation] Command gets Rockier #66356

Merged
merged 6 commits into from May 7, 2022
Merged

[Kilostation] Command gets Rockier #66356

merged 6 commits into from May 7, 2022

Conversation

Zytolg
Copy link
Contributor

@Zytolg Zytolg commented Apr 20, 2022

About The Pull Request

Given that just about the rest of the station features a significant portion of rock, It's fairly inconsistent that the central portion of Kilostation does not.

Why It's Good For The Game

Command players are stoners

Changelog

馃啈
fix: Kilostation's command section now accurately reflects that command staff are, in fact, commanding a hollowed out asteroid.
/:cl:

rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks rocks
@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. labels Apr 20, 2022
Copy link
Member

@Maurukas Maurukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a mix of tiles with atmos, airless tiles, space tiles, and plants (which nominally can't exist in a vacuum). The other enclosed asteroid areas on Kilo have atmosphere in them.

image

@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Apr 23, 2022
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Apr 24, 2022
@github-actions github-actions bot requested a review from Maurukas April 24, 2022 06:08
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Apr 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label May 3, 2022
@Zytolg
Copy link
Contributor Author

Zytolg commented May 3, 2022

Bwah, I'll get to this sometime tomorrow murkle darned conflicts

@github-actions github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label May 4, 2022
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 6, 2022
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 6, 2022
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 7, 2022
Copy link
Member

@Maurukas Maurukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active turfs snuck back in.

Copy link
Member

@Maurukas Maurukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard, my local broke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants