Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icebox Brig usability fixes #66511

Merged
merged 1 commit into from Apr 26, 2022
Merged

Icebox Brig usability fixes #66511

merged 1 commit into from Apr 26, 2022

Conversation

Pandarsenic
Copy link
Contributor

@Pandarsenic Pandarsenic commented Apr 25, 2022

About The Pull Request

Adds vent+scrubber to the Warden's passage to the Armory and the entryway airlocks.
image

Adds a wire line running to the Brig Medical area.
image to image

Why It's Good For The Game

The Brig Medical APC giving power alarms every round on IceBox was annoying as hell to AIs.
The scrubber/vents can now use the Warden's office and Security office to fix air problems there without having to leave weird doors or windoors jacked open to other places for air supply.

(I did NOT put any on on the bridge because the bridge just feels, to me, like it's supposed to be sketchy, precarious, and prone to problems. Nothing but R-glass to each side and below you separating you from a swim in the plasma lake, and all that.)

Changelog

馃啈
qol: Added vent/scrubber pair to the Icebox security entryway and the warden's backdoor to the armory.
fix: Icebox Brig Medical now has a wire connecting it to the powernet.
/:cl:

Adds vent+scrubber to the Warden's passage to the Armory and the entryway airlocks. Adds a wire to the Brig Medical area.
@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Quality of Life Increasing esword damage is not a quality of life for traitors labels Apr 25, 2022
@Zytolg
Copy link
Contributor

Zytolg commented Apr 25, 2022

This PR likely conflicts with #66462 to some degree

@Pandarsenic
Copy link
Contributor Author

This PR likely conflicts with #66462 to some degree

Shockingly, it appears not to, from a glance at Map Difference Bot friend. Most of their changes are on other levels.

@san7890
Copy link
Member

san7890 commented Apr 25, 2022

This PR likely conflicts with #66462 to some degree

Shockingly, it appears not to, from a glance at Map Difference Bot friend. Most of their changes are on other levels.

It will not directly conflict with the tiles changed in the aforementioned PR, but it's likely that there may be a lurking key change that has to be forced by someone (tends to happen even if someone touches tiles on the exact polar opposite position of the same map). Depending on the order-of-operations on how we merge the PRs, it'll likely just have to be a merge conflict resolution to handle the key change rather than have to remap stuff entirely. Merge Conflicts are easy when you have git hooks, and if you manage to get sniped by one, please let me know on Discord so I can help you figure that out (tends to be hard the first time around).

Copy link
Member

@san7890 san7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Quality of Life Increasing esword damage is not a quality of life for traitors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants