Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic midrounds spawning heavies significantly earlier than they're supposed to #67615

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

Mothblocks
Copy link
Member

About The Pull Request

This is the code for determining whether a heavy should spawn.

image

It works by making heavies more and more likely the longer the round goes on.

However, it is currently ran after the following code:

image

...which means that it is actually judging based off the next roll, rather than the current one.

This fixes that. Untested, you know how it is with Dynamic.

Changelog

🆑
fix: Fixed Dynamic midrounds spawning heavies significantly earlier than they're supposed to
/:cl:

@Mothblocks Mothblocks added the Verified ✔️ Yeah, i'm a coder. What about it? label Jun 8, 2022
@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Jun 8, 2022
@Colovorat
Copy link
Contributor

Feature

@moocowswag
Copy link
Contributor

Finally, shuttle being called over a 14 minute space dragon is annoying.

@ShizCalev ShizCalev merged commit 3401804 into master Jun 12, 2022
@ShizCalev ShizCalev deleted the Mothblocks-patch-1 branch June 12, 2022 00:46
github-actions bot added a commit that referenced this pull request Jun 12, 2022
Jacquerel pushed a commit to Jacquerel/orbstation that referenced this pull request Jun 27, 2022
…y're supposed to (tgstation#67615)

Fix Dynamic midrounds spawning heaviers significantly earlier than they're supposed to
Jacquerel pushed a commit to Jacquerel/orbstation that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Verified ✔️ Yeah, i'm a coder. What about it?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants