Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining Outpost Overhaul: Island Living Edition #67796

Merged
merged 22 commits into from Jul 12, 2022

Conversation

Thunder12345
Copy link
Contributor

@Thunder12345 Thunder12345 commented Jun 15, 2022

About The Pull Request

Replaced the old mining outpost with a new base consisting of separate buildings on islands in the middle of lava. Added a few new areas and decorations to fill out the outpost. Changed the underfloor accessibility of lava so cables and pipes don't mysteriously disappear as they cross catwalks over lava.

Mining Operations Contains everything needed to be a miner. Connects to the Living Quarters to the west.

image

Public Outpost Public lounges, gear room, basic medical facility and xenobotany (hydroponics) lab. Connects to the Living Quarters to the north, and Gulag Guard Post to the west.

image

Living Quarters Bedrooms bathrooms and cafeteria, everything you need to live in hell. Connects to Mining Operations to the east, the Gulag Guard Post to the west, and the Public Outpost to the south.

image

Service Building Hosts the outpost's power, air, and comms systems. Disposals ends in a shack outside, with a manually operated, lava based trash incinerator. Connects to the Living Quarters to the south via maintenance.

image

Gulag Guard Post A basic security outpost from which to monitor the Gulag. Theoretically the only entrance and exit to the gulag by land, in practice this is not strictly true. Connects to the Gulag to the west, and the Living Quarters and Public Outpost to the east.

image

Gulag You work for your freedom here, prisoner. Don't try to escape by sprinting across narrow spots in the lava river, and definitely don't use your hydroponics area to grow illegal plants hidden on the island by your predecessors. Connects to the Gulag Guard Post to the east.

image

Why It's Good For The Game

The current mining station is fairly boring and dated. In addition, the general layout of the outpost was bland and uninspired, about as exciting as any other hallway. This replacement offers a new and unique take with an interesting layout and new dangers to be aware of.

The bridges between buildings are exposed to the weather, meaning you could find yourself forced to choose between waiting out a storm in an isolated building with a potentially unfriendly roommate, or running through the storm to get back to a shuttle.

Power and communications are also more vulnerable in the new base, placed in a building on the mainland where ne'er-do-wells could gain access unnoticed and sabotage them, making the mining outpost less of a safe space with little risk of anything going seriously wrong. You don't get access to these just for having mining access, better call the relevant portion of engineering to help you.

Gulag prisoners also get a few new options to keep security on their toes, with a few different options for escape routes that encourage the warden to keep an eye on their charges instead of ignoring the gulag while waiting for the prisoners to do their sentences or kill themselves.

Changelog

🆑
add: The mining outpost was unfortunately destroyed in an industrial accident. A replacement has been constructed on a group of islands in the magma sea.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. Sprites A bikeshed full of soulless bikes. labels Jun 15, 2022
@TrashDoxx
Copy link

Double bed? SkyRat vibes.

@Thunder12345
Copy link
Contributor Author

Double bed? SkyRat vibes.

Shush it's for an extra comfortable sleeping experience in the luxury bedroom for important miners only

@private-tristan
Copy link
Contributor

is the exit just catwalks? would anyone be able to just... wirecut it and make miner's jobs much, MUCH harder
image

@Thunder12345
Copy link
Contributor Author

is the exit just catwalks? would anyone be able to just... wirecut it and make miner's jobs much, MUCH harder

The catwalks over lava are a subtype, currently just plain indestructible unless I can come up with a good solution to make them breakable but not ridiculously easy to grief

@Son-of-Space
Copy link
Contributor

Just to point out for those reviewing that both this and #67475 redo the same area and thus only one can be added.

I obviously have more to say than just that but I will refrain.

@Maurukas Maurukas added this to the Lavaland milestone Jun 16, 2022
@G0nTar
Copy link

G0nTar commented Jun 17, 2022

Nice, can't wait to check this whole new complex out, getting such SUS vives from the layout, and getting trapped or risking running thru the storm and using that as an ANTAG or prisoner extra options, makes it feel so much alive than the old one

@github-actions github-actions bot requested a review from san7890 June 22, 2022 18:24
@newfren
Copy link
Contributor

newfren commented Jun 23, 2022

The central gimmick of the lava bridges is really annoying when you're walking around down there because of how slow you walk across them. It also feels like this depowers worse than the old lavaland base (but I don't actually have any strong feeling on this it might just be that I had a few longer rounds with it).

@Hamcha
Copy link
Contributor

Hamcha commented Jun 24, 2022

Please fix the airlocks permissions in the Service Building (and maybe others if they have the same problem), you can get stuck inside and never get out if you run through the airlock, had to break the window to escape as a Shaft miner

@VladinXXV
Copy link
Contributor

The bridges are a nightmare, not only because you're going slow as balls over them at all times, but because they're exposed to the elements. I get that's part of the gimmick, but it sucks. When you've got someone in critical condition in a part of the base with no shuttle, you just have to sit around and cry about it until the storm passes, because you KNOW they won't survive crossing the slow bridge in the storm.

Having so many more airlocks directly interacting with the outdoors also increases how much lavaland atmos is getting in. This is more dangerous, annoying, and causes scrubbers to have to do more work, which I believe does result in a higher power drain.

Not having access to your own comms or power equipment as a miner sucks. No one wants to come down there and help you fix it. As a miner, you're more dangerous to them than they are to you. Engineering has better ways to spend their time (cleaning up the mess of bombings, SM delam, dragon, etc) than risk their life to put you back on the radio.

@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jun 27, 2022
@rasepretep
Copy link
Contributor

It's never been there before, so I'm guessing this is what brought it: There is now at least one corpse right outside the mining base that has standard Shaft Miner gear, everything a player normally spawns with when they pick Shaft Miner. Feels like an oversight to have freely available PDA, Shaft Miner ID, explorer gas mask, and mining voucher for anyone who can use/misuse them.

Whether it's an issue that needs fixing, or it can do more good than harm, that's up to you to decide. Just pointing it out.

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 2, 2022
Copy link
Member

@san7890 san7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Time

Images Within

image

heavy breathing this could work but one day the decal order will fuck up. you could make an orange subtype of every decal but if you don't care enough that's fine too.

image

Passive Vent Here please, put it in the Mining Explore area. Also catwalks on floors EWWW

image

Move vents and scrubbers out from under lockers.

image

Move vent out from under locker.

image

Move the vent out from under the stool.

image

Erratic disposals pipe.

image

If this is a public area, unrestricted access into this hallway. Doesn't particularly make sense to have it terminate in maintenance, unless that's the discrete effect you're going for.

More rooms and hallways need intercoms in general, I would advise doing Intercom-Range-Display in Debug Mapping Verbs (too many to list here, but like mech bay, central hallways, some gulag rooms, eastern mining lounge room, etc.). More fire extinguishers would be nice too, but I understand if you don't really wanna add too many.

Overall, strong mapping work. I've probably missed something so I'll do another pass when the above is rectified.

code/game/area/areas/mining.dm Outdated Show resolved Hide resolved
code/game/objects/structures/lattice.dm Show resolved Hide resolved
@san7890 san7890 marked this pull request as draft July 5, 2022 23:33
@github-actions github-actions bot requested a review from san7890 July 7, 2022 11:06
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 11, 2022
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 12, 2022
@Thunder12345 Thunder12345 marked this pull request as ready for review July 12, 2022 08:38
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet