Removes requirements from most midround rulesets, and lowers their minimum population to run, because nobody knows what it means #68571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimum population to run, because nobody knows what it means
Mothblocks
added
Code Improvement
tgstation-server
added
Balance
Mothblocks
commented
Jul 18, 2022
| @@ -270,9 +270,9 @@ | |||
| exclusive_roles = list(JOB_AI) | |||
| required_enemies = list(4,4,4,4,4,4,2,2,2,0) | |||
| required_candidates = 1 | |||
| weight = 3 | |||
| minimum_players = 25 | |||
| weight = 2 | |||
There was a problem hiding this comment.
Lowered because their requirements were a lot higher
|
This is a huge blow to me, after dedicating so much blood, sweat, and tears to learning what the requirements var did In seriousness, having a minimum_pop var is great. I'm assuming requirements is still customizable on a per-ruleset basis in a server's dynamic.json file? |
|
Yeah, the var still exists, and all vars are configurable. This just makes the defaults significantly easier to read. |
|
thanks for this |
Profakos
reviewed
Jul 19, 2022
tgstation-server
added a commit
that referenced
this pull request
Jul 26, 2022
This was referenced Aug 9, 2022
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
requirementsis a var that nobody but me understands because it's completely unreadable.This removes most uses of it in midround rulesets, and replaces it with a dead simple to understand
minimum_pop.For the most part, this lowers the requirements across the board, as the only thing that tried to actually use requirements was xenos, which were lower in requirement than most other rulesets. Fixes #68568.
Changelog
🆑
balance: Heavily adjusted how much population impacts the chances of midround rulesets, mostly lowering them.
/:cl: