Fixes SaturnX #69765
Fixes SaturnX #69765
Conversation
* Fixes SaturnX not making you invisible, because the new code needed for it to work was removed during Kapu's limb refactor (I assume because the downstream they were from didn't have SaturnX).
tgstation-server
added
the
Fix
|
Moths, Plasmamen, and Monkeys all have unique icons that don't have invisibility limbs (which do have unique animations), which means this fix isn't fully complete yet. Unless a spriter is willing to add species-unique invisibility limbs, I think I'm gonna have to make them all share the same human icon. (under some 'invisibility limbs' dmi) |
|
it would be awesome if this had screenshot tests |
here's the image of it in action |
Added one, have to make it consistent though so it'll take a few mins to finish it up. |
|
erm, they don't look very invisible to me |
|
That's the first frame of the animation, they start blue and fade out. |
|
oh |
|
might be good idea to remove |
yes good idea, done now |
About The Pull Request
Fixes SaturnX not making you invisible, because the new code needed for it to work was removed during Kapu's limb refactor (I assume because the downstream they were from didn't have SaturnX), but it did need some work to work with the new system.
This time there's less snowflake checks (like just removing greyscale/gender/some other thing I already forgot because I'm suppressing it from my memory, from the user's body.
Video of it in-game (ignore the lag spike near the end, I had a breakpoint):
https://user-images.githubusercontent.com/53777086/188973251-26610e50-964a-4ce0-97b7-c86159a947d6.mov
Why It's Good For The Game
SaturnX works again, awesome!
Closes #66377
Closes https://tgstation13.org/phpBB/viewtopic.php?f=5&t=32421
Changelog
馃啈
fix: SaturnX now properly turns you invisible again.
/:cl: