MODsuit: unhardcoded parts #70061

Fikou · 2022-09-21T22:19:39Z

About The Pull Request

This is drafted to make me finish it because its long overdue
unhardcodes modsuit parts - instead of helmet chestplate gauntlets boots, they will be able to be any parts, and everything is handled by a mod part datum interfacing between the modsuit and the part.
fixes #69933

Why It's Good For The Game

This + making modules linked to the unhardcoded parts (this is coming next) lets us later do these:

making suits that dont work on helmet chestplate etc, something like scarf glasses suit will be possible
making the suits able to extend/retract parts while active without being a fucking mistake (skyrat moment)
making the suits not turn off when you get delimbed

Changelog

not player facing

ghost · 2022-09-22T15:12:12Z

THE LAWYER TIE SUIT IS COMING

github-actions · 2022-10-03T00:24:56Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

…lunacy

Mothblocks · 2022-10-19T04:18:56Z

It's been nearly a week since last commit and this is still drafted and failing tests, we have over 100 PRs up right now so I am closing this

Feel free to reopen when ready

…lunacy

github-actions · 2023-11-16T21:21:18Z

Screenshot tests failed!

Download zip file of new screenshots.

Diffs

See snapshot diffs

Name	Expected image	Produced image	Diff
cardboard_cutouts_nukie_cutout			None produced.
screenshot_antag_icons_loneoperative
screenshot_dynamic_human_icons_syndicate_commando

Help

What is this?

Screenshot tests make sure that specific icons look the same as they did before.
This is important for elements that often mistakenly change, such as alien species.

If the produced image looks broken, then it is possible your code caused a bug.
Make sure to test in game to see if you can fix it.

I am changing sprites, it's supposed to look different.

If the newly produced sprites are correct, then the tests should be updated.

You can either:

Right-click the "produced image", and save it in code/modules/unit_tests/screenshots/NAME.png.
Download and extract this zip file in the root of your repository, and commit.

If you need help, you can ask maintainers either on Discord or on this pull request.

This is a false positive.

If you are sure your code did not cause this failure, especially if it's inconsistent,
then you may have found a false positive.

Ask maintainers to rerun the test.

If you need help, you can ask maintainers either on Discord or on this pull request.

…lunacy

Fikou · 2023-11-17T01:55:07Z

almost done, needs a rework of how we do some clothing rendering, ui fixes and implementing all the modules that modify your parts, but the backend for that is finished

github-actions · 2023-11-17T07:07:13Z

Screenshot tests failed!

Download zip file of new screenshots.

Diffs

See snapshot diffs

Name	Expected image	Produced image	Diff
cardboard_cutouts_nukie_cutout			None produced.
screenshot_antag_icons_loneoperative
screenshot_dynamic_human_icons_syndicate_commando

Help

What is this?

Screenshot tests make sure that specific icons look the same as they did before.
This is important for elements that often mistakenly change, such as alien species.

If the produced image looks broken, then it is possible your code caused a bug.
Make sure to test in game to see if you can fix it.

I am changing sprites, it's supposed to look different.

If the newly produced sprites are correct, then the tests should be updated.

You can either:

Right-click the "produced image", and save it in code/modules/unit_tests/screenshots/NAME.png.
Download and extract this zip file in the root of your repository, and commit.

If you need help, you can ask maintainers either on Discord or on this pull request.

This is a false positive.

If you are sure your code did not cause this failure, especially if it's inconsistent,
then you may have found a false positive.

Ask maintainers to rerun the test.

If you need help, you can ask maintainers either on Discord or on this pull request.

github-actions · 2023-11-20T21:34:29Z

Screenshot tests failed!

Download zip file of new screenshots.

Diffs

See snapshot diffs

Name	Expected image	Produced image	Diff
cardboard_cutouts_nukie_cutout			None produced.
screenshot_antag_icons_loneoperative
screenshot_dynamic_human_icons_syndicate_commando

Help

What is this?

Screenshot tests make sure that specific icons look the same as they did before.
This is important for elements that often mistakenly change, such as alien species.

If the produced image looks broken, then it is possible your code caused a bug.
Make sure to test in game to see if you can fix it.

I am changing sprites, it's supposed to look different.

If the newly produced sprites are correct, then the tests should be updated.

You can either:

Right-click the "produced image", and save it in code/modules/unit_tests/screenshots/NAME.png.
Download and extract this zip file in the root of your repository, and commit.

If you need help, you can ask maintainers either on Discord or on this pull request.

This is a false positive.

If you are sure your code did not cause this failure, especially if it's inconsistent,
then you may have found a false positive.

Ask maintainers to rerun the test.

If you need help, you can ask maintainers either on Discord or on this pull request.

github-actions · 2023-11-28T00:05:44Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

deathrobotpunch · 2023-11-29T00:32:08Z

good PR yesterday I died as a miner to gibtonite and my mining modsuit turned off stopping the GPS from working

Fikou · 2023-11-29T05:26:45Z

good PR yesterday I died as a miner to gibtonite and my mining modsuit turned off stopping the GPS from working

that module should work when the suit is off tbh

github-actions · 2023-12-08T00:06:05Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

## About The Pull Request see #70061 but i almost finished it, i only need to go through every single module and assign it a fitting part ## Changelog :cl: refactor: modsuits have been refactored if you see bugs report them fix: admin cargo tech modsuit outfit now works correctly /:cl: --------- Co-authored-by: Andrew <mt.forspam@gmail.com>

Part one of unhardcoded parts

c54a271

Fikou added the Refactor Makes the code harder to read label Sep 21, 2022

github-actions bot requested a review from Mothblocks September 21, 2022 22:21

This comment was marked as off-topic.

Sign in to view

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Sep 25, 2022

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Oct 3, 2022

Fikou mentioned this pull request Oct 5, 2022

Fixes modsuit qdel loop #70326

Closed

Fikou added 2 commits October 8, 2022 14:13

Merge branch 'master' of https://github.com/tgstation/tgstation into …

720acc1

…lunacy

the biddling

45bae08

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Oct 8, 2022

Fikou removed the Stale Even the uncaring universe rejects you, why even go on label Oct 8, 2022

Fikou added 5 commits October 8, 2022 15:53

fuck me up

5c2bbad

actual lunacy

45171ed

who you gonna call

1d017eb

who you gonna call

ebe1f06

Merge branch 'master' of https://github.com/tgstation/tgstation into …

2752802

…lunacy

github-actions bot requested a review from ninjanomnom October 8, 2022 22:20

sshhhh

c010cb2

Mothblocks closed this Oct 19, 2022

Fikou added 4 commits October 22, 2022 16:38

forming son

2e1af08

Merge branch 'master' of https://github.com/tgstation/tgstation into …

8584577

…lunacy

bitc

056e60c

Merge branch 'master' of https://github.com/tgstation/tgstation into …

5f522ca

…lunacy

Fikou reopened this Nov 16, 2023

upstream merge

b5fd963

tgstation-server added the Sprites A bikeshed full of soulless bikes. label Nov 16, 2023

e

390a14c

fix

1079b39

Fikou added 3 commits November 17, 2023 02:04

we're almost so back

b29c5c1

Merge branch 'master' of https://github.com/tgstation/tgstation into …

eb5684b

…lunacy

why

a056328

This comment was marked as off-topic.

Sign in to view

try to fix issues

6de2f5c

parts display (#18)

91845ed

tgstation-server added the UI We make the game less playable, but with round edges label Nov 20, 2023

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Nov 28, 2023

github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label Nov 30, 2023

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Dec 8, 2023

github-actions bot closed this Dec 15, 2023

Fikou mentioned this pull request Apr 26, 2024

unhardcodes modsuit parts #82905

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MODsuit: unhardcoded parts #70061

MODsuit: unhardcoded parts #70061

Fikou commented Sep 21, 2022 •

edited

ghost commented Sep 22, 2022

This comment was marked as off-topic.

github-actions bot commented Oct 3, 2022

Mothblocks commented Oct 19, 2022

github-actions bot commented Nov 16, 2023

Fikou commented Nov 17, 2023

This comment was marked as off-topic.

github-actions bot commented Nov 17, 2023

github-actions bot commented Nov 20, 2023

github-actions bot commented Nov 28, 2023

deathrobotpunch commented Nov 29, 2023

Fikou commented Nov 29, 2023

github-actions bot commented Dec 8, 2023

MODsuit: unhardcoded parts #70061

MODsuit: unhardcoded parts #70061

Conversation

Fikou commented Sep 21, 2022 • edited

About The Pull Request

Why It's Good For The Game

Changelog

ghost commented Sep 22, 2022

This comment was marked as off-topic.

github-actions bot commented Oct 3, 2022

Mothblocks commented Oct 19, 2022

github-actions bot commented Nov 16, 2023

Diffs

Help

Fikou commented Nov 17, 2023

This comment was marked as off-topic.

github-actions bot commented Nov 17, 2023

Diffs

Help

github-actions bot commented Nov 20, 2023

Diffs

Help

github-actions bot commented Nov 28, 2023

deathrobotpunch commented Nov 29, 2023

Fikou commented Nov 29, 2023

github-actions bot commented Dec 8, 2023

Fikou commented Sep 21, 2022 •

edited