Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the beer nuke use scrubber overflow #70929

Merged

Conversation

Thunder12345
Copy link
Contributor

About The Pull Request

Refactors the beer nuke's detonation to use a scrubber overflow subtype instead of its own snowflake code. Adds some new functionality to scrubber overflows to support changing the per-scrubber probability of being involved, and forcing a specific reagent.

Why It's Good For The Game

Removes largely duplicated code in favour of extending existing functionality.

Changelog

馃啈
refactor: The beer nuke detonation is now a special type of scrubber overflow event.
/:cl:

@tgstation-server tgstation-server added the Refactor Makes the code harder to read label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Makes the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants