Removes tablets (not PDAs) entirely. #71507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the tablet subtype because it was mostly just bloat, PDAs now replaces them entirely. Nukie and Silicon tablets are now subtypes of the PDA instead, while contractor ones were removed entirely as they didn't do anything and were unused (though it wouldn't be hard to re-add). Nukie PDAs are now the only type of PDA that uses modular_tablets.dmi, which is just larger icons of modular_pda. Each application requires an icon state in both of these, for 2 different sizes, which makes it annoying to make new applications, especially if it can also run on computers/laptops.
JohnFulpWillard
requested review from
Ryll-Ryll,
Imaginos16,
Krysonism,
Twaticus,
ninjanomnom,
Mothblocks and
Fikou
as code owners
tgstation-server
added
Removal
JohnFulpWillard
requested review from
EOBGames,
Maurukas,
san7890 and
ShizCalev
as code owners
tgstation-server
added
the
Map Edit
Mothblocks
reviewed
Nov 25, 2022
|
okay i should leave tablets alone for now in my refactor lmao |
|
Sad, but the removal of modular parts pretty much smashed any reason to have the two be different. We should just replace the nukie tablet with a PDA (or, really, just give it a PDA sprite because that's about the extent of the change). |
|
RIP PDAs I'll always remember you |
|
there's something hilarious to be said about an entire modular computer system being merged only for it to be basically rolled back over the coming months. |
|
How was it rolled back? We just integrated one into the other |
7 tasks
comfyorange
added a commit
that referenced
this pull request
Dec 2, 2022
i was referring to removing the "modular" part of modular computers. No, the programs aren't the modular part. Lmfao. |
|
yes they are |
jlsnow301
pushed a commit
that referenced
this pull request
Jan 1, 2023
## About The Pull Request Replaces the nuclear operative tablet icon with a GAGS PDA one, entirely deleting the modular tablet DMI file as this was the last place it was ever used. Looks like this  tablet for reference  ## Why It's Good For The Game Follow up to #71507 - Removes a DMI file and the need to resprite apps yet another time (down to 3 now) for every NTos program, replacing it with the tablet instead. ## Changelog :cl: imageadd: Nukie tablets are now using PDA sprites w/ GAGS instead of tablets. /:cl: Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
TaleStationBot
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 1, 2023
## About The Pull Request Replaces the nuclear operative tablet icon with a GAGS PDA one, entirely deleting the modular tablet DMI file as this was the last place it was ever used. Looks like this  tablet for reference  ## Why It's Good For The Game Follow up to tgstation/tgstation#71507 - Removes a DMI file and the need to resprite apps yet another time (down to 3 now) for every NTos program, replacing it with the tablet instead. ## Changelog :cl: imageadd: Nukie tablets are now using PDA sprites w/ GAGS instead of tablets. /:cl: Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
SkyratBot
pushed a commit
to Skyrat-SS13/Skyrat-tg
that referenced
this pull request
Jan 1, 2023
## About The Pull Request Replaces the nuclear operative tablet icon with a GAGS PDA one, entirely deleting the modular tablet DMI file as this was the last place it was ever used. Looks like this  tablet for reference  ## Why It's Good For The Game Follow up to tgstation/tgstation#71507 - Removes a DMI file and the need to resprite apps yet another time (down to 3 now) for every NTos program, replacing it with the tablet instead. ## Changelog :cl: imageadd: Nukie tablets are now using PDA sprites w/ GAGS instead of tablets. /:cl: Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Zonespace27
pushed a commit
to Skyrat-SS13/Skyrat-tg
that referenced
this pull request
Jan 2, 2023
* replaces nukie tablet sprite with PDA (#72285) ## About The Pull Request Replaces the nuclear operative tablet icon with a GAGS PDA one, entirely deleting the modular tablet DMI file as this was the last place it was ever used. Looks like this  tablet for reference  ## Why It's Good For The Game Follow up to tgstation/tgstation#71507 - Removes a DMI file and the need to resprite apps yet another time (down to 3 now) for every NTos program, replacing it with the tablet instead. ## Changelog :cl: imageadd: Nukie tablets are now using PDA sprites w/ GAGS instead of tablets. /:cl: Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com> * replaces nukie tablet sprite with PDA Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 3, 2023
* replaces nukie tablet sprite with PDA (#72285) ## About The Pull Request Replaces the nuclear operative tablet icon with a GAGS PDA one, entirely deleting the modular tablet DMI file as this was the last place it was ever used. Looks like this  tablet for reference  ## Why It's Good For The Game Follow up to tgstation/tgstation#71507 - Removes a DMI file and the need to resprite apps yet another time (down to 3 now) for every NTos program, replacing it with the tablet instead. ## Changelog :cl: imageadd: Nukie tablets are now using PDA sprites w/ GAGS instead of tablets. /:cl: Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> * replaces nukie tablet sprite with PDA Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Comes with an UpdatePaths!
Removes the tablet subtype, PDAs now replaces them entirely.
Nukie and Silicon tablets are now subtypes of the PDA instead, while contractor ones were removed entirely as they didn't do anything and were unused (though it wouldn't be hard to re-add).
Nukie PDAs are now the only type of PDA that uses modular_tablets.dmi, which is just larger icons of modular_pda. Each application requires an icon state in both of these, for 2 different sizes, which makes it annoying to make new applications, especially if it can also run on computers/laptops.
Icons
Because Silicon tablets are now a subtype of PDA, they use PDA icons instead of tablet ones. Luckily for us, they already exist in code.
AI's don't use a tablet icon though, so they aren't affected.
Why It's Good For The Game
There's very little difference between tablets and PDAs, PDAs overshadow them in every single way, so at this point I don't see why we should have both of these, and if you compare the two in usefulness and actual in-game use by players, it's a no-brainer than the item all players get roundstart and comes with a messenger should be the one we go with.
Also as said in the about section, when making an app you would need to make icon states for the program running for all hardware it can run on, which is Computer, Laptop, PDA, and Tablet.
Laptop is just a smaller computer icon
PDA is just a smaller tablet icon
However, you can't simply shrink the size of the icon, instead you have to completely resprite the same app icon FOUR TIMES for it to not bluescreen on all these different devices.
Here's examples of it
Computer (NOTE: *They share the same icon file as regular computers*)If we wish to help in simplifying this, we should remove tablet icons entirely, which means 1 less icon to worry about. To do this, we'd need to resprite nukie PDAs, however I am very much not a spriter and never tried GAGS, so I'll leave it to someone else to do.
Changelog
🆑
del: Tablets are now removed, PDAs are now the base 'tablet'. Silicon and nukie tablets are now PDAs.
/:cl: