Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds reagents splashing animation #72231

Merged
merged 13 commits into from Jan 4, 2023

Conversation

kawoppi
Copy link
Contributor

@kawoppi kawoppi commented Dec 25, 2022

About The Pull Request

Adds animations for splashing reagents on stuff. Both when combat mode + right clicking something, and when throwing the reagent container at something. The slosh sound now also plays in both these cases, because it seemed weird that these were lacking sounds. There's also an animation for splashing reagents into hydroponics trays.

default splash animation: default
splash animation when targeting turfs: floor
animation for pouring reagents into hydroponics trays: hydroponics
(they all get recolored by the reagents)

new demo video!

old demo video
old extra demo because i forgot to record it the first time

Why It's Good For The Game

Visual and auditory feedback for splashing things and getting splashed (with potentially dangerous chemicals). Also looks neat when watering your plants.

Changelog

🆑
add: added reagent splashing animation for spilling reagents on things
add: added reagent splashing animation for spilling reagents onto floors
add: added reagent splashing animation for pouring reagents into hydroponics trays
soundadd: slosh sound now plays when spilling reagents on things, both directly and by throwing
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes. labels Dec 25, 2022
@Jacquerel
Copy link
Contributor

The offset makes this look great on hydroponics trays but less great on random other turfs, it's a really good idea though.

@kawoppi
Copy link
Contributor Author

kawoppi commented Dec 25, 2022

The offset makes this look great on hydroponics trays but less great on random other turfs, it's a really good idea though.

Thanks! There's a seperate offset for hydroponics trays. I lined up the normal animation with the middle of a floor tile since I thought it would make the most sense in terms of perspective. It's a bit late so I've lost my grasp of perspective, I'll give it another look later and see if I can improve it. I could probably have different sprites for splashing on mobs/floors so they make more sense with their perspectives.

@kawoppi kawoppi marked this pull request as draft December 25, 2022 01:21
Hydroponics is the old default. Really happy with how the floor splash turned out. The new default not so much however...
might as well if i'm not using it for other splishy sploshies anymore
@ChungusGamer666

This comment was marked as off-topic.

i threw a cup of water on the bathroom wall for this
@kawoppi kawoppi marked this pull request as ready for review December 26, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants