Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a stamp sound effect when stamping papers #72367

Merged
merged 4 commits into from
Jan 2, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions code/modules/paperwork/paper.dm
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@
add_stamp(writing_stats["stamp_class"], rand(0, 400), rand(0, 500), rand(0, 360), writing_stats["stamp_icon_state"])
user.visible_message(span_notice("[user] blindly stamps [src] with \the [attacking_item]!"))
to_chat(user, span_notice("You stamp [src] with \the [attacking_item] the best you can!"))
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, vary = TRUE)

else
to_chat(user, span_notice("You ready your stamp over the paper! "))
ui_interact(user)
Expand Down Expand Up @@ -540,6 +541,7 @@

add_stamp(stamp_class, stamp_x, stamp_y, stamp_rotation, stamp_icon_state)
user.visible_message(span_notice("[user] stamps [src] with \the [holding.name]!"), span_notice("You stamp [src] with \the [holding.name]!"))
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, vary = TRUE)


update_appearance()
update_static_data(user, ui)
Expand Down
1 change: 1 addition & 0 deletions code/modules/paperwork/stamps.dm
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

/obj/item/stamp/suicide_act(mob/living/user)
user.visible_message(span_suicide("[user] stamps 'VOID' on [user.p_their()] forehead, then promptly falls over, dead."))
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, TRUE)
playsound(src, 'sound/items/handling/standard_stamp.ogg', 50, vary = TRUE)

return OXYLOSS

/obj/item/stamp/get_writing_implement_details()
Expand Down
2 changes: 2 additions & 0 deletions sound/attributions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ eject.ogg is by magedu, adapted from https://freesound.org/people/magedu/sounds/
alien_explode.ogg is adapted from zimbot's Frozen Lettuce upload https://freesound.org/people/zimbot/sounds/89378/ and little_dog4000's balloon pop https://freesound.org/people/little_dog4000/sounds/478764/

alien_organ_cut.ogg is adapted from some CC 0 flesh sound, lesaucisson's swoosh https://freesound.org/people/lesaucisson/sounds/585256/, and a snippet of EminYILDIRIM's tree cutting clip https://freesound.org/people/EminYILDIRIM/sounds/608343/

standard_stamp.ogg is adapted from tom_woysky's "Stamp.wav" https://freesound.org/people/tom_woysky/sounds/348316/
Binary file added sound/items/handling/standard_stamp.ogg
Binary file not shown.