New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMB Multitooling tcomms machines unlinks or links from buffer #72801
Conversation
Can you also make it to where AltClicking will set the buffer to the machine |
yeah uhh dunno how |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
if(QDELETED(multitool.buffer)||!multitool.buffer || !istype(telecomms_machine) || telecomms_machine == src) //sanity + user sanity | ||
return FALSE | ||
if(multitool.buffer in links) | ||
to_chat(user, span_notice("Unlinked [telecomms_machine] ([telecomms_machine.id]) from the [src].")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they aren't going through some UI, maybe these would be better as balloon alerts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not happening for the reasons in the previous "Requested Changes"
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
About The Pull Request
Adds a contextual multitool tooltip saying "Link/Unlink from multitool buffer" to tcomms machines
Rightclicking a tcomms machine with a multitool (with a tcomms machine in the buffer);
Links if the buffer was not found in the targets links
Unlinks if the buffer was found in the targets links
Why It's Good For The Game
Way smoother and easier to connect tcomms machines instead of opening tgui like 15 times and pressing a button
Changelog
馃啈
qol: Multitooling a telecommunications machine with RMB links or unlinks it to the machine in the multitools buffer
/:cl: