Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilds Luxury Shuttle (mostly), makes it emag-only #72940

Merged
merged 12 commits into from Feb 8, 2023

Conversation

mc-oofert
Copy link
Contributor

@mc-oofert mc-oofert commented Jan 24, 2023

About The Pull Request

2023 02 07-06 49 54
Changes the really goofy old lux shuttle to a cooler layout with some additions to make it a luxury and not just
"anti-poor-people protection + food"

Shuttle was made bigger to make it less cramped for the luxury class, pool was moved to its own room, added an arcade
and a bar corner, has real lasers to shoot poors with (20c each shot), has fire extinguishers now
Adds a new preopen variant of hardened shutters
Adds a paywall pin subtype for the luxury shuttle, and a laser gun subtype

Made emag-only at a price of 10000 credits

Why It's Good For The Game

The old luxury shuttle looked REALLY awful with its pool, was pretty cramped even in the luxury section and BARELY resembled a luxury..
This luxury shuttle provides luxuries such as a less poorly designed pool, more space for legs, arcade, to make it resemble a luxury unlike the old one

Changelog

🆑
add: Luxury Shuttle is now bigger, and less ugly! Poor people still get it rough though...
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. labels Jan 24, 2023
@CRITAWAKETS
Copy link
Contributor

redesign no. 2 (or is it 3?) lets goooo

@unit0016
Copy link
Contributor

Why remove shuttle rotation on the shutters instead of just... rotating the shutters? Would definitely shaft other shuttles where these are rotated, especially with wallening in the picture.

@mc-oofert
Copy link
Contributor Author

Why remove shuttle rotation on the shutters instead of just... rotating the shutters? Would definitely shaft other shuttles where these are rotated, especially with wallening in the picture.

all my homies hate wallening and horizontal shutters are an eyesore

@unit0016
Copy link
Contributor

unit0016 commented Jan 24, 2023

all my homies hate wallening and horizontal shutters are an eyesore

I just feel that the stations on /tg/ widely using horizontal shutters everywhere while shuttles are hardcoded to not be able to is incredibly goofy.

@mc-oofert
Copy link
Contributor Author

mc-oofert commented Jan 24, 2023

all my homies hate wallening and horizontal shutters are an eyesore

I just feel that the stations on /tg/ widely using horizontal shutters everywhere while shuttles are hardcoded to not be able to is incredibly goofy.

i have literally never seen a station with horizontal shutters

dont you mean blast doors?

@unit0016
Copy link
Contributor

unit0016 commented Jan 24, 2023

i have literally never seen a station with horizontal shutters

dont you mean blast doors?

Current /tg/ Deltastation Robotics:
image

These were applied systematically to every map in #68056 and #68464 respectively.

@mc-oofert
Copy link
Contributor Author

i have literally never seen a station with horizontal shutters
dont you mean blast doors?

Current /tg/ Deltastation Robotics: image

These were applied systematically to every map in #68056 and #68464 respectively.

imagine playing deltastation

code/modules/shuttle/shuttle_rotate.dm Outdated Show resolved Hide resolved
@mc-oofert mc-oofert changed the title Rebuilds Luxury Shuttle (mostly), prevent shutters from rotating during shuttle rotation Rebuilds Luxury Shuttle (mostly) Jan 24, 2023
@VladinXXV
Copy link
Contributor

Maybe it just isn't showing on the screenshot or something, but you seem to have a lot of empty wall space and zero fire extinguishers. Might be a luxury worth adding? For the people with money, of course.

Copy link
Member

@san7890 san7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a cool concept designwise but this won't get it back into the server configuration as it doesn't really fulfill anything outlined here: https://tgstation13.org/phpBB/viewtopic.php?p=662250#p662250

If you were to make it emag-only, I would be perfectly satisfied with it from the headmin standpoint. I'm wondering if you could lean more into making it so that you didn't have to pay as much credits to get onboard, but all of the amenities would be marked up higher (i.e. you purchase caviar "on demand" for a steep price).

Mappingwise, great job. I'll review that part as days go past, do remind me if it's been a bit. Feel free to mark it as "Ready for Review" when you address this in some capacity.

@san7890 san7890 marked this pull request as draft January 24, 2023 22:43
@blackdav123
Copy link

did you put fire extinguishers anywhere or am I just blind

@mc-oofert
Copy link
Contributor Author

this is a cool concept designwise but this won't get it back into the server configuration as it doesn't really fulfill anything outlined here: https://tgstation13.org/phpBB/viewtopic.php?p=662250#p662250

If you were to make it emag-only, I would be perfectly satisfied with it from the headmin standpoint. I'm wondering if you could lean more into making it so that you didn't have to pay as much credits to get onboard, but all of the amenities would be marked up higher (i.e. you purchase caviar "on demand" for a steep price).

Mappingwise, great job. I'll review that part as days go past, do remind me if it's been a bit. Feel free to mark it as "Ready for Review" when you address this in some capacity.

made it emag-only at 10000 credits now

@mc-oofert mc-oofert marked this pull request as ready for review January 25, 2023 05:46
@github-actions github-actions bot requested a review from san7890 January 25, 2023 05:48
@Draggeru
Copy link
Contributor

I think it would be really funny to have a pay gate at the bathroom and charge people every time they enter it. I feel like the shuttle would benefit from having a lot of weird "rich person" bullshit instead of it having a pay to enter system

@Draggeru
Copy link
Contributor

Draggeru commented Jan 25, 2023

Nameless mentioned a shooting range where the rich could shoot at the poor, I fully support this idea as well

Edit: Yes I see the guns. Make it an actual shooting range. Make the guns real guns or you're a coward

@mc-oofert
Copy link
Contributor Author

Edit: Yes I see the guns. Make it an actual shooting range. Make the guns real guns or you're a coward

i dont think giving people guns for free is a good idea on a shuttle

@MrrFiish
Copy link

Edit: Yes I see the guns. Make it an actual shooting range. Make the guns real guns or you're a coward

i dont think giving people guns for free is a good idea on a shuttle

They ARE making it an emag shuttle, honestly I could see them being real.

@mc-oofert
Copy link
Contributor Author

Edit: Yes I see the guns. Make it an actual shooting range. Make the guns real guns or you're a coward

i dont think giving people guns for free is a good idea on a shuttle

They ARE making it an emag shuttle, honestly I could see them being real.

its an emag-only shuttle on the basis of being covered in fuck-off-indestructible walls

@san7890 san7890 added this to the Shuttles milestone Jan 26, 2023
@Draggeru
Copy link
Contributor

Draggeru commented Jan 26, 2023

Edit: Yes I see the guns. Make it an actual shooting range. Make the guns real guns or you're a coward

i dont think giving people guns for free is a good idea on a shuttle

They ARE making it an emag shuttle, honestly I could see them being real.

its an emag-only shuttle on the basis of being covered in fuck-off-indestructible walls

But we don't want the shuttle to be indestructible anymore.

Edit: My source of this being I talked to San about it. One of the largest grievances with the shuttle is BECAUSE its indestructible

@mc-oofert
Copy link
Contributor Author

Edit: My source of this being I talked to San about it. One of the largest grievances with the shuttle is BECAUSE its indestructible

image
the arena shuttle is indestructible too so

@san7890
Copy link
Member

san7890 commented Jan 26, 2023

But we don't want the shuttle to be indestructible anymore.

Edit: My source of this being I talked to San about it. One of the largest grievances with the shuttle is BECAUSE its indestructible

you're right in one way, and it's my fault you're wrong otherwise. the best case scenario would be making it not indestructible somehow, but the more I think on it and the more people who try and tackle this problem, the more I am convinced that there are two different spheres. Here's a diagram to illustrate:

image

A would be the concept behind the map: a great and silly critique of capitalism and other money-grinding tendencies, while rewarding certain player behaviors or being a good fuckin talk on society. i love the idea of people choking down caviar as they see the "poors" slum around a pigpen. It appeals to me.

However, the "B" Sphere is... everything else about this game. It's a sandbox game, anything that shows up on the station z-level should be able to be messed with somehow. Walls are meant to be broken, and you're supposed to be able to do anything you want in some way. If someone makes a five-foot tall wall, you get a six-foot long ladder through some game mechanic. One thing that I've really disliked about this shuttle's maintainability is that in order to keep the "A" sphere's message intact, you have to attach yourself to a complete disconnect to what the rest of the game should stand for (in my opinion). Some player finally cracks out a way to bypass it somehow? Well now you've got to wonder if their ingenuity should be rewarded, but also if it's a "bug" or "oversight" that must be patched in order to create a more perfect codebase. It's.. blaugh.

However, they remain inextricably linked. I got sick of it back in August 2022 (see the forum post I linked earlier in this PR), and I got sick of people getting sick of it, so I removed it from the servers. Since that point, I've remained in hope that one of the twelve people who said they wanted to try and rework some aspect of it could finally find that perfect balance (the ???? zone in the diagram), but I think that as time goes on we'll never get that.

This is why I'm okay with it dropping down to emag-only status. I can't get everything I want in life, and no one really can. I just want to be less sick of it, and I want to be less sick of seeing it (this was the second most purchased emergency shuttle, excluding purpose-built station shuttles):

image

This chart was data collected from all servers between March 2022 to early January 2023, you can read more about the data preparation and get the source for yourself from this maintainerbus in the tgstation discord: https://discord.com/channels/326822144233439242/808425762217656330/1065790372925677609

If it's on emag only status, it locks it behind some (hopefully) fun traitor interactions or a way to chain Crab-17 and the shuttle to troll the crew in a funny way (unless it becomes a complete bore due to overuse)... at least I know that someone who could have just as easily murdered the crew had some part in bringing about such a griefy shuttle. I want more of course, and I think that you could re-adapt the entire concept to spin it on its head to bring about a much better concept that does a much better job of linking our "A" and "B" spheres... but I'm okay with it being emag only for now.

i hope that clarifies in a way that i poorly attempted to address in either forum post, speaking from a purely design perspective. I'm already interested in incorporating this new shuttle design (broadly, haven't reviewed it yet), I just desperately wanted something in the status quo to change rather than be stuck in mediocrity.

@mc-oofert
Copy link
Contributor Author

i have replaced the laser practice guns with real lasers that cost 20 credits each shot

@github-actions github-actions bot requested a review from san7890 January 27, 2023 05:39
@Redrover1760
Copy link

Redrover1760 commented Jan 30, 2023

i have replaced the laser practice guns with real lasers that cost 20 credits each shot

If I may suggest something, you should replace some of the walls of the poor medbay with windows, and maybe replace the southern cargo area with windows as well, to give the poors worse cover and less obvious places to hide if they are getting shot up from the Luxury side. Making it harder to hide, in general.

And to allow the rich to laugh at the poor easier, without anywhere to hide from the scorn of being a poor person.

Copy link
Member

@san7890 san7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

fix this weird floating light

@mc-oofert
Copy link
Contributor Author

fix this weird floating light

ok

@github-actions github-actions bot requested a review from san7890 February 7, 2023 05:51
@san7890 san7890 merged commit 3f61c4c into tgstation:master Feb 8, 2023
comfyorange added a commit that referenced this pull request Feb 8, 2023
github-actions bot added a commit that referenced this pull request Feb 8, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Feb 8, 2023
…-only (#4469)

Original PR: tgstation/tgstation#72940
-----
## About The Pull Request
![2023 02 07-06 49
54](https://user-images.githubusercontent.com/70376633/217159751-790e6ded-8525-4d13-a5b5-6a3d8076a00e.png)
Changes the really goofy old lux shuttle to a cooler layout with some
additions to make it a luxury and not just
"anti-poor-people protection + food"

Shuttle was made bigger to make it less cramped for the luxury class,
pool was moved to its own room, added an arcade
and a bar corner, has real lasers to shoot poors with (20c each shot),
has fire extinguishers now
Adds a new preopen variant of hardened shutters
Adds a paywall pin subtype for the luxury shuttle, and a laser gun
subtype

Made emag-only at a price of 10000 credits
## Why It's Good For The Game

The old luxury shuttle looked REALLY awful with its pool, was pretty
cramped even in the luxury section and BARELY resembled a luxury..
This luxury shuttle provides luxuries such as a less poorly designed
pool, more space for legs, arcade, to make it resemble a luxury unlike
the old one

## Changelog
:cl:
add: Luxury Shuttle is now bigger, and less ugly! Poor people still get
it rough though...
/:cl:

---------

Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet