Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Party Alarm and slows down the animation #73703

Merged
merged 2 commits into from Mar 8, 2023

Conversation

NamelessFairy
Copy link
Member

@NamelessFairy NamelessFairy commented Feb 28, 2023

About The Pull Request

#66726 deleted the icon state for the party alarm overlay, I've re-added it.

Concerns were brought up on discord about the speed in which the colors changed being a potential seizure risk so I've slowed down the speed of the animation.

Why It's Good For The Game

Without a working party alarm the game is unplayable.

Changelog

🆑
fix: The party alarm now works again!
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Fix Rewrites a bug so it appears in different circumstances labels Feb 28, 2023
@NamelessFairy NamelessFairy changed the title Fixes the Party Alarm Fixes the Party Alarm and slows down the animation Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Mar 8, 2023
@san7890 san7890 merged commit 9ba0046 into tgstation:master Mar 8, 2023
comfyorange added a commit that referenced this pull request Mar 8, 2023
github-actions bot added a commit that referenced this pull request Mar 8, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Mar 8, 2023
…ion (#4796)

Original PR: tgstation/tgstation#73703
-----
## About The Pull Request

#66726 deleted the icon state for the party alarm overlay, I've re-added
it.

Concerns were brought up on discord about the speed in which the colors
changed being a potential seizure risk so I've slowed down the speed of
the animation.
## Why It's Good For The Game

Without a working party alarm the game is unplayable.
## Changelog
:cl:
fix: The party alarm now works again!
/:cl:

---------

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
## About The Pull Request

tgstation#66726 deleted the icon state for the party alarm overlay, I've re-added
it.

Concerns were brought up on discord about the speed in which the colors
changed being a potential seizure risk so I've slowed down the speed of
the animation.
## Why It's Good For The Game

Without a working party alarm the game is unplayable.
## Changelog
:cl:
fix: The party alarm now works again!
/:cl:
scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Sprites A bikeshed full of soulless bikes. Stale Even the uncaring universe rejects you, why even go on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants