Adds the Janitor access keyring

[JohnFulpWillard]

About The Pull Request

HackMD for this can be found here: https://hackmd.io/VEbjO1kaQJarao4KqGfzgw?view

Basically, this gives the first Janitor an access key that they can use to enter departments. This requires a Head of Staff to approve it through the keycard authenticator, and only holds one department at a time, and will clear itself out after 10 minutes.
This gives departmental AA, including the head of staff's office, adding a tradeoff.

The Janitor is alerted when access is given to their key (as their keyring will say such) and everyone can see janitors trying to open a door when they use it (with a cool sound, too).
You can't bump open airlocks with it, I limited it to directly using it on the door, because I thought it made it feel more realistic to a keyring.

I had an earlier version of this that gave the key it's own access, which allowed bumping open, but it also allowed things like locking RD consoles, and I dunno how strong I want this key to be.

I also wanted to limit how easy this is to greytide/steal, currently only the first Janitor spawns with the key. I thought it would be too easy to exploit otherwise, or essentially stolen roundstart if there were no Janitors. Maybe this can also fit as a Traitor objective after melon's new objective PR is done?

Minor detail

While adding icons, I realized inhands don't actually set its icon state to the default if it's null, so I removed that LYING comment.

Why It's Good For The Game

Alternatively, https://youtu.be/dlkSbQ-IkRM?t=182 (timestamp)

Changelog

🆑 JohnFulpWillard, sprites by BalkyGoat
add: The Janitor Access key: Janitors can now be given departmental AA (one at a time) using the Keycard authentication device in Command offices. Use it if you need cleaning!
fix: HoP's trim is no longer set to edit Supply access.
/:cl:

[ATH1909]

I don't see why letting latejoiner janitors spawn with it would make it significantly easier to tide?

[GuillaumePrata]

As Command has access to airlock remotes and can bolt down their office, they can still give access to their department while keeping their own office off limits if desired.
But that is just smart planning and encourages using the remote more, they can even use it on other airlocks they don't want the janitor to mess with.

The PR is good on 2 fronts.

[BlueMemesauce]

The head of staff of a department could just open the doors for them while they clean, I don't think it's really worth it for them to go all the way back to their office to give them access.
In my opinion, it should be hop content as the they doesn't have much to do anymore, plus the hop is the head of the janitor's department.
edit: But I guess that's kind of a pointless idea cause the HoP can already make a new "access id" that the janitor can hold to open doors

[VladinXXV]

#janitorsweep

[OverwatchVoice]

Honestly, I feel like this adds unneeded complexity. giving temporary EA is quicker and more convenient.

[san7890]

Honestly, I feel like this adds unneeded complexity. giving temporary EA is quicker and more convenient.

complexity is fun and the spice of life

[san7890]

should be a way to remove the access from the keychain in hand IMO... doesn't feel fair to be gimped out of getting access to another department through this nifty system in case you finish cleaning up early or something

[JohnFulpWillard]

should be a way to remove the access from the keychain in hand IMO... doesn't feel fair to be gimped out of getting access to another department through this nifty system in case you finish cleaning up early or something

You can get access to more departments, it'll overwrite.

[ZephyrTFA]

Code looks good, only minor thing I can see is someone trapping the janitor in another department "accidentally" by giving them access to their department while they're inside a different one, (which is hilarious)

[san7890]

should be a way to remove the access from the keychain in hand IMO... doesn't feel fair to be gimped out of getting access to another department through this nifty system in case you finish cleaning up early or something

You can get access to more departments, it'll overwrite.

well doesn't that mean you could be trapped inside of a department (oh zephyr brought that up i have tunnel vision)

[EricZilla]

Does this tell the jannie when they get access? Because this would be a really cool way to beep them and let them know the genetics lab has become ground zero
(I feel like I read that it DOES that but cant find it anymore)

[ZephyrTFA]

should be a way to remove the access from the keychain in hand IMO... doesn't feel fair to be gimped out of getting access to another department through this nifty system in case you finish cleaning up early or something

You can get access to more departments, it'll overwrite.

well doesn't that mean you could be trapped inside of a department (oh zephyr brought that up i have tunnel vision)

@JohnFulpWillard could you address this just so we know if it's intended or unintended.

Outdated

[JohnFulpWillard]

Does this tell the jannie when they get access?

Their keyring will buzz at them that they got access

could you address this just so we know if it's intended or unintended.

It's easier to get out of a department than it is to get in, so I wouldn't consider this a problem. It's unintended, but funny enough that I'll keep it in, and not disruptive enough to make it unfun for players.

[RedBaronFlyer]

Honestly, assuming the worst-case scenario and you're trapped deep in a department, you can just ask the AI to guide you out of the department.

Plus, if I recall right if there are any maint doors in a department, you can just take those to get out of a department as janitors have maint access.