-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds TTS to announcements made by the Captain and silicons #73967
Conversation
…ages matter when hearing tts messages and various other changes
… shit. (#12) * Update documentation.md * Intel accelerated python. Fileless python ffmpeg handling.
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
sounds awful in game |
Even when the option is ticked off, I'm still hearing the TTS in game. I have no idea why. |
Can you upload an example recording of this |
It's supposedly testmerged on many servers but, for example, in Manuel its testmerging the old closed PR and it just. doesn't work. |
When in the lobby, you can hear any TTS announcements the captain/AI makes. |
I'll look into this, this shouldn't be the case |
https://user-images.githubusercontent.com/37270891/225313437-5cdde27b-225a-40ef-a9fe-c25ab2d0e3b6.mp4 I'm probably going to work on it a bit more to add more reverb since it doesn't have that intercom feel right now and it sounds like it's coming from inside your head. It needs reverb/echo and the filters make it sound robotic more than anything. |
Quite confused about this, because my TTS preferences are ticked on and I can't hear any announcements. |
The test merge was only fixed on one of the servers it got test merged to, the other still had the version that had the inverted preferences bug. |
I know our limitations but I really wish these sounded magnitudes better, I am hesitant to call this acceptable |
These sound bad right now because there's a lack of reverb and the filters are not as good as they could be. I'm not a sound engineer so I'll need to do some more research in order to get them to a good state. |
They speak extremely fast and stumble over their words, we can't fix that with filters but I understand that we're extremely limited with the requirements we have for TTS |
I'm pretty sure tempo can be messed with in the python script. |
You can also mess with tempo using the filters from ffmpeg. It's just that ffmpeg sucks at providing good reverb effects and you basically need another library if you want to apply reverb effects. |
…ures/game_preferences/sounds.tsx Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
…ures/game_preferences/sounds.tsx Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Can't really find the motivation to work on this, I may end up opening it up again in the future, but I'm not really a sound engineer, I haven't got a clue on how to make it sound good and like an intercom. |
re-opening since I'm working on this again + need to respond to threads |
We are SO back.... |
Damn OK, nevermind. |
Copy from #72300
About The Pull Request
TTS currently can't handle every client having their own voice, so it's been limited to announcements made by the Captain and silicon players.
In the future, if we get a GPU server, it may become a more viable option to implement every client having their own voice because GPUs are great at concurrency.
It's all handled via python http requests to a local server. Docker is required to set up, but the container can be held on a separate linux server as it's only used to process text into audio and send it back via http requests.
TTS engine used in python script:
VITS: https://arxiv.org/pdf/2106.06103
coqui: https://github.com/coqui-ai/TTS
Base image is debian.
This is all handled locally. There are no calls to a third-party service.
Why It's Good For The Game
TTS is cool.
Changelog
🆑 Watermelon914, Iamgoofball, MrStonedOne
add: Adds TTS to announcements made by the Captain and silicon players.
/:cl: