-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDB Ignore] Fixes Tiles On All Maps (mea culpa edition) #74250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically the dirs weren't actually correct lol
san7890
added
the
GBP: No Update
Prevent changes to the user's GBP balance from this PR
label
Mar 25, 2023
san7890
requested review from
EOBGames,
Maurukas,
MMMiracles and
ShizCalev
as code owners
March 25, 2023 19:41
tgstation-server
added
Fix
Rewrites a bug so it appears in different circumstances
Tools
We pretend to be a real development community
Map Edit
Thank you for your tile-placing service. It's always appreciated.
labels
Mar 25, 2023
comfyorange
added a commit
that referenced
this pull request
Mar 25, 2023
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Mar 25, 2023
… edition) (#5058) Original PR: tgstation/tgstation#74250 ----- ## About The Pull Request ![image](https://user-images.githubusercontent.com/34697715/227738092-33b699f1-f388-491e-8eea-a71c9df98ec1.png) I actually noticed this in my testing and fixed it, but the changes somehow disappeared and I continued to assume that they were fixed without checking. fuck. It's all good now. ## Why It's Good For The Game ![image](https://user-images.githubusercontent.com/34697715/227738109-fd6afe23-85b5-48c0-9db2-b54275180cbb.png) yeah this was fucked everywhere. all good now though promise. ## Changelog :cl: fix: Tile decals are no longer fucked on all stations. /:cl: The diff might seem a bit weird but I reverted all of the maps to a state before the script was ran, and then re-ran the fixed script. Makes sense to me. --------- Co-authored-by: san7890 <the@san7890.com>
scriptis
pushed a commit
to scriptis/tgstation
that referenced
this pull request
Apr 1, 2023
…4250) ## About The Pull Request ![image](https://user-images.githubusercontent.com/34697715/227738092-33b699f1-f388-491e-8eea-a71c9df98ec1.png) I actually noticed this in my testing and fixed it, but the changes somehow disappeared and I continued to assume that they were fixed without checking. fuck. It's all good now. ## Why It's Good For The Game ![image](https://user-images.githubusercontent.com/34697715/227738109-fd6afe23-85b5-48c0-9db2-b54275180cbb.png) yeah this was fucked everywhere. all good now though promise. ## Changelog :cl: fix: Tile decals are no longer fucked on all stations. /:cl: The diff might seem a bit weird but I reverted all of the maps to a state before the script was ran, and then re-ran the fixed script. Makes sense to me.
scriptis
pushed a commit
to scriptis/tgstation
that referenced
this pull request
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fix
Rewrites a bug so it appears in different circumstances
GBP: No Update
Prevent changes to the user's GBP balance from this PR
Map Edit
Thank you for your tile-placing service. It's always appreciated.
Tools
We pretend to be a real development community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I actually noticed this in my testing and fixed it, but the changes somehow disappeared and I continued to assume that they were fixed without checking. fuck. It's all good now.
Why It's Good For The Game
yeah this was fucked everywhere. all good now though promise.
Changelog
🆑
fix: Tile decals are no longer fucked on all stations.
/:cl:
The diff might seem a bit weird but I reverted all of the maps to a state before the script was ran, and then re-ran the fixed script. Makes sense to me.