Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB Ignore] Fixes Tiles On All Maps (mea culpa edition) #74250

Merged
merged 4 commits into from
Mar 25, 2023

Conversation

san7890
Copy link
Member

@san7890 san7890 commented Mar 25, 2023

About The Pull Request

image

I actually noticed this in my testing and fixed it, but the changes somehow disappeared and I continued to assume that they were fixed without checking. fuck. It's all good now.

Why It's Good For The Game

image

yeah this was fucked everywhere. all good now though promise.

Changelog

🆑
fix: Tile decals are no longer fucked on all stations.
/:cl:
The diff might seem a bit weird but I reverted all of the maps to a state before the script was ran, and then re-ran the fixed script. Makes sense to me.

@san7890 san7890 added the GBP: No Update Prevent changes to the user's GBP balance from this PR label Mar 25, 2023
@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Tools We pretend to be a real development community Map Edit Thank you for your tile-placing service. It's always appreciated. labels Mar 25, 2023
@san7890 san7890 added this to the Mega-Mega-Map-Reworks milestone Mar 25, 2023
@Fikou Fikou enabled auto-merge (squash) March 25, 2023 19:44
@Fikou Fikou merged commit a42765a into tgstation:master Mar 25, 2023
comfyorange added a commit that referenced this pull request Mar 25, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Mar 25, 2023
… edition) (#5058)

Original PR: tgstation/tgstation#74250
-----

## About The Pull Request


![image](https://user-images.githubusercontent.com/34697715/227738092-33b699f1-f388-491e-8eea-a71c9df98ec1.png)

I actually noticed this in my testing and fixed it, but the changes
somehow disappeared and I continued to assume that they were fixed
without checking. fuck. It's all good now.

## Why It's Good For The Game


![image](https://user-images.githubusercontent.com/34697715/227738109-fd6afe23-85b5-48c0-9db2-b54275180cbb.png)

yeah this was fucked everywhere. all good now though promise.
## Changelog
:cl:
fix: Tile decals are no longer fucked on all stations.
/:cl:
The diff might seem a bit weird but I reverted all of the maps to a
state before the script was ran, and then re-ran the fixed script. Makes
sense to me.

---------

Co-authored-by: san7890 <the@san7890.com>
@itsmeow
Copy link
Contributor

itsmeow commented Mar 27, 2023

Holy shit, they finally discovered the source of the anomalous spelling phenomenon "Nanotracen". This is them!
image

scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
…4250)

## About The Pull Request


![image](https://user-images.githubusercontent.com/34697715/227738092-33b699f1-f388-491e-8eea-a71c9df98ec1.png)

I actually noticed this in my testing and fixed it, but the changes
somehow disappeared and I continued to assume that they were fixed
without checking. fuck. It's all good now.

## Why It's Good For The Game


![image](https://user-images.githubusercontent.com/34697715/227738109-fd6afe23-85b5-48c0-9db2-b54275180cbb.png)

yeah this was fucked everywhere. all good now though promise.
## Changelog
:cl:
fix: Tile decals are no longer fucked on all stations.
/:cl:
The diff might seem a bit weird but I reverted all of the maps to a
state before the script was ran, and then re-ran the fixed script. Makes
sense to me.
scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR Map Edit Thank you for your tile-placing service. It's always appreciated. Tools We pretend to be a real development community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants