Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desouls the Roboticist Jumpsuit, and adds new Roboticist Boilersuit #74352

Merged
merged 11 commits into from Apr 10, 2023

Conversation

Moth-lantern
Copy link
Contributor

@Moth-lantern Moth-lantern commented Mar 29, 2023

About The Pull Request

So with the lovely work of my partner Alchemyandmagic, I present new bespoke and soulless roboticist jumpsuit and skirt resprites, along with a new more mechanic-esque roboticist boilersuit as an alternate costume for the job
Roboticist_Jfront
Roboticist_jskf
boilersuit_front
Boilerskirt_front
Roboticist_inhands

Why It's Good For The Game

Visual upgrades are generally good and the roboticist jumpsuit was poorly shaded and out of date with the current direction the artstyle of ss13 is heading, as for the new outfit, roboticist and research in general is one of the jobs with very very few alternate costumes for player customization, and some may wish for their roboticists to have a more mechanic-like aesthetic

Changelog

🆑
imageadd: Nanotransen has made uniform changes to the robotics lab, modernizing their wardrobe.
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Feature Exposes new bugs in interesting ways labels Mar 29, 2023
@Fikou
Copy link
Member

Fikou commented Mar 29, 2023

roboticist and research in general is one of the jobs with very very few alternate costumes for player customization

the 4 unique jumpsuits roboticists can get:

@dragomagol
Copy link
Member

The boilersuit outfits scream "security" to me more than "robotics"

@AtomTheProphet
Copy link
Contributor

They do look a bit like security, but they look absolutely wonderful!

@san7890
Copy link
Member

san7890 commented Mar 30, 2023

image

what are these supposed to be, i don't really understand

@Moth-lantern
Copy link
Contributor Author

image

what are these supposed to be, i don't really understand

Camera that I used to take pics of the ingame sprites with, sorry lol

@san7890
Copy link
Member

san7890 commented Mar 30, 2023

lol just hit f5 to adminghost and then use your screenshot tool

@Moth-lantern
Copy link
Contributor Author

lol just hit f5 to adminghost and then use your screenshot tool

...oh.

@san7890
Copy link
Member

san7890 commented Mar 30, 2023

it's okay not many people are aware of the number of debug tools we have and how they can be leveraged

@EricZilla
Copy link
Contributor

Never liked the roboticists suit, but I like these much more, big fan of the new one.

(You can also windows + shift + S to take a screengrab)

@Moth-lantern
Copy link
Contributor Author

oh yeah all these are valid options they just don't give nice zoomed in screenshots

@VladinXXV
Copy link
Contributor

VladinXXV commented Mar 31, 2023

oh yeah all these are valid options they just don't give nice zoomed in screenshots

I take these kinda screenshots all the time. Here's my advice:

Preferences > Open Game Preferences > Gameplay. Disable ambient occlusion.
image
Note: Ambient occlusion doesn't seem to update automatically. After you disable it, try aghosting then re-entering your body.

Move to the "UI" section of the preferences now. In the "Pixel Scaling" dropdown, select "Pixel Perfect 3x". If this is too zoomed in, you can also try using 2x, but I wouldn't recommend lower than that.
image

The "photobooth" holodeck has a completely textureless white floor. This is my personal favorite, but on a case-by-case basis you may prefer using a more natural setting on the station.

Admin ghost (F5 should work, but there's also a verb for it in the Admin tab). You'll probably want fullbright, but this can vary too. You can do this by clicking "Toggle Darkness" in the Ghost tab until you don't see any more shadows.
image

For actually taking the picture, I just use Win + Shift + S. You can paste the result directly to your PR from the clipboard using Ctrl + V.

Additional tips:
For mob sprites (item inhands, clothing, etc), I like to show them all off in one picture. While a ghost, if you Ctrl + Shift + LMB yourself, you'll spawn in as your character, naked. You can use this to make quick clones of yourself. If you don't care about having pretty test dummies, you can also spawn /obj/item/debug/human_spawner, which will spawn a random naked human wherever you click.

You can see an example of this combined with the rest of the tips in #70784. Or any of my PRs with screenshots, really.

@JohnFulpWillard
Copy link
Member

Roboticists already get a ton more alternative costumes than Scientist/Geneticist, do we really want to be adding more?

@Moth-lantern
Copy link
Contributor Author

Roboticists already get a ton more alternative costumes than Scientist/Geneticist, do we really want to be adding more?

Roboticist has four costumes if you for some reason count the skirt and suit as completely different clothing items. A lot of security jobs have up to 6 or 7 alternate costume sets. If job disparity in clothing mattered security would have half as many outfits. But as it stands I think its fine if roboticist gets one more set. Also to be clear scientist can wear these just as well as roboticist. its not particularly hard for a scientist to get into robotics.

Minor text fix.

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Copy link
Contributor

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its… Okay. Certainly better than the old one though.

@Jacquerel
Copy link
Contributor

image
Unless you are both talking about something I am missing this really doesn't look unreasonably bloated to me, so unless someone actually wants to block adding more outfits on those grounds I will merge it
@Fikou @JohnFulpWillard

Also I like the practical boiler suit more than the anime plug suit to be honest

@Moth-lantern
Copy link
Contributor Author

Yea originally the scope of this was going to be changing the default to the boilersuit, but there was a noticeable contingent of players who still liked the plugsuit at the downstream I was originally pring for.

Copy link
Contributor

@Twaticus Twaticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i'd rather not have an alt robo outfit at this time
the resprites fine just not the boilersuit

@Moth-lantern
Copy link
Contributor Author

sorry i'd rather not have an alt robo outfit at this time the resprites fine just not the boilersuit

Could I ask for clarification on this comment? I would like to know specifically why it is a point of concern/contention for the future.

@san7890 san7890 marked this pull request as draft April 9, 2023 23:09
@Moth-lantern Moth-lantern marked this pull request as ready for review April 9, 2023 23:38
@san7890 san7890 removed the Feature Exposes new bugs in interesting ways label Apr 9, 2023
@san7890
Copy link
Member

san7890 commented Apr 9, 2023

fwiw i really enjoy the thought of a boilersuit but i think maybe with some stylistic alterations it could definitely fill some other niche in the game (aside from being yet another alt outfit for a job)

i also removed the changelog entry in your PR body

@san7890 san7890 enabled auto-merge (squash) April 9, 2023 23:44
@san7890 san7890 disabled auto-merge April 9, 2023 23:44
@san7890 san7890 enabled auto-merge (squash) April 9, 2023 23:45
auto-merge was automatically disabled April 9, 2023 23:46

Head branch was pushed to by a user without write access

@Moth-lantern
Copy link
Contributor Author

I am not going to pr another sprite for a different job to wait two weeks and then get told no without context, I'm sorry. but thank you for merging the jumpsuit updates.

@Jacquerel Jacquerel enabled auto-merge (squash) April 9, 2023 23:52
@san7890
Copy link
Member

san7890 commented Apr 10, 2023

I am not going to pr another sprite for a different job to wait two weeks and then get told no without context, I'm sorry. but thank you for merging the jumpsuit updates.

I don't see why no one quoted this but it's from https://hackmd.io/@tgstation/HyOAnhDPI#Alternate-job-uniforms

Alternate job uniforms
Jobs do not need multiple alternate uniforms in their closets, If you want to add a alternate uniform, you can put it in a cargo crate, or put it in costume vendors that are public access.

Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Apr 10, 2023
…oboticist Boilersuit (#5305)

Original PR: tgstation/tgstation#74352
-----
## About The Pull Request
So with the lovely work of my partner Alchemyandmagic, I present new
bespoke and soulless roboticist jumpsuit and skirt resprites, along with
a new more mechanic-esque roboticist boilersuit as an alternate costume
for the job

![Roboticist_Jfront](https://user-images.githubusercontent.com/122066083/228681372-0e4f5f8d-c29d-41ec-b106-f960a1020b27.png)

![Roboticist_jskf](https://user-images.githubusercontent.com/122066083/228681386-7530cdc8-9325-4701-9251-345960a69fa8.png)

![boilersuit_front](https://user-images.githubusercontent.com/122066083/228681402-a001f6ff-8c71-4419-ac8f-41de64ee54c2.png)

![Boilerskirt_front](https://user-images.githubusercontent.com/122066083/228681414-23d92d43-7ac7-49cf-a58e-58d3bc986165.png)

![Roboticist_inhands](https://user-images.githubusercontent.com/122066083/228681426-b7049856-2c3c-40ed-b004-72502cb8cde7.png)
## Why It's Good For The Game
Visual upgrades are generally good and the roboticist jumpsuit was
poorly shaded and out of date with the current direction the artstyle of
ss13 is heading, as for the new outfit, roboticist and research in
general is one of the jobs with very very few alternate costumes for
player customization, and some may wish for their roboticists to have a
more mechanic-like aesthetic
## Changelog
:cl:
imageadd: Nanotransen has made uniform changes to the robotics lab,
modernizing their wardrobe.
/:cl:

---------

Co-authored-by: Moth-lantern <122066083+Moth-lantern@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet