Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

resprites salt and pepper shakers #74890

Merged
merged 2 commits into from Apr 23, 2023
Merged

Conversation

CoiledLamb
Copy link
Contributor

@CoiledLamb CoiledLamb commented Apr 21, 2023

About The Pull Request

Resprites the empty, salt, and pepper shakers to have a more modern sprite. you can see the comparison below.
saltnpepperbeforenafter2
and in game screenshot here.
Screenshot (2630)

Why It's Good For The Game

Salt and pepper are a staple in every kitchen, so why not make 'em look a bit nicer?

Changelog

馃啈

imageadd: added new salt, pepper, and empty shaker sprites.

/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Removal This was too fun, too fun! I'm turning this feature around labels Apr 21, 2023
@Farquaar
Copy link
Contributor

Farquaar commented Apr 21, 2023

The sprites look good but I kinda don't like how they're bigger than the old sprites. While I get that more pixels gives you more detail, I feel like there's been a lot of scale creep with respect to sprites recently.

If you so choose, I think you could make these new sprites a pixel shorter without sacrificing any quality, however.

@CoiledLamb
Copy link
Contributor Author

i don't think scale creep is a huge problem here. the additional pixel of height gives them a nicer silhouette in my eyes, and better readability, so i don't think there's really any reason to hold on to the scale of the old shakers past what i already have.

someone else requested in discord suggested i make them 3/4ths, so i wanna preemptively say here i don't think that's a good idea due to the actual scale creep that would cause. if someone else wants to sprite it that's fine, but i'm satisfied with these, past some tweaks to the empty one i'm working on presently (to make the base more readable)

@zxaber
Copy link
Contributor

zxaber commented Apr 23, 2023

Actual salt PR

@Imaginos16
Copy link
Contributor

A subtle, but welcome change.

@Imaginos16 Imaginos16 merged commit 7ec204f into tgstation:master Apr 23, 2023
18 checks passed
github-actions bot added a commit that referenced this pull request Apr 23, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Apr 23, 2023
Original PR: tgstation/tgstation#74890
-----
## About The Pull Request
Resprites the empty, salt, and pepper shakers to have a more modern
sprite. you can see the comparison below.

![saltnpepperbeforenafter2](https://user-images.githubusercontent.com/110322848/233579218-103240c9-8941-425b-9581-f9ca297133ee.png)
and in game screenshot here.
![Screenshot
(2630)](https://user-images.githubusercontent.com/110322848/233580054-1906c9ad-c3f7-46d9-ba64-c73f2c1e3360.png)
## Why It's Good For The Game


Salt and pepper are a staple in every kitchen, so why not make 'em look
a bit nicer?

## Changelog


:cl:

imageadd: added new salt, pepper, and empty shaker sprites. 

/:cl:

---------

Co-authored-by: Lamb <110322848+CoiledLamb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal This was too fun, too fun! I'm turning this feature around Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants