New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
resprites salt and pepper shakers #74890
Conversation
The sprites look good but I kinda don't like how they're bigger than the old sprites. While I get that more pixels gives you more detail, I feel like there's been a lot of scale creep with respect to sprites recently. If you so choose, I think you could make these new sprites a pixel shorter without sacrificing any quality, however. |
i don't think scale creep is a huge problem here. the additional pixel of height gives them a nicer silhouette in my eyes, and better readability, so i don't think there's really any reason to hold on to the scale of the old shakers past what i already have. someone else requested in discord suggested i make them 3/4ths, so i wanna preemptively say here i don't think that's a good idea due to the actual scale creep that would cause. if someone else wants to sprite it that's fine, but i'm satisfied with these, past some tweaks to the empty one i'm working on presently (to make the base more readable) |
Actual salt PR |
A subtle, but welcome change. |
Original PR: tgstation/tgstation#74890 ----- ## About The Pull Request Resprites the empty, salt, and pepper shakers to have a more modern sprite. you can see the comparison below. ![saltnpepperbeforenafter2](https://user-images.githubusercontent.com/110322848/233579218-103240c9-8941-425b-9581-f9ca297133ee.png) and in game screenshot here. ![Screenshot (2630)](https://user-images.githubusercontent.com/110322848/233580054-1906c9ad-c3f7-46d9-ba64-c73f2c1e3360.png) ## Why It's Good For The Game Salt and pepper are a staple in every kitchen, so why not make 'em look a bit nicer? ## Changelog :cl: imageadd: added new salt, pepper, and empty shaker sprites. /:cl: --------- Co-authored-by: Lamb <110322848+CoiledLamb@users.noreply.github.com>
About The Pull Request
Resprites the empty, salt, and pepper shakers to have a more modern sprite. you can see the comparison below.
and in game screenshot here.
Why It's Good For The Game
Salt and pepper are a staple in every kitchen, so why not make 'em look a bit nicer?
Changelog
馃啈
imageadd: added new salt, pepper, and empty shaker sprites.
/:cl: