Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

North Star AI SAT rework #75006

Merged
merged 9 commits into from May 2, 2023
Merged

North Star AI SAT rework #75006

merged 9 commits into from May 2, 2023

Conversation

Cheshify
Copy link
Contributor

@Cheshify Cheshify commented Apr 27, 2023 •
edited

About The Pull Request

Redoes the AI SAT so the AI is better protected and command can actually access it.
aisat

Why It's Good For The Game

AI is as protected as it is on other maps + fair to malf AI + command can reach SAT

Changelog

🆑
fix: Command can actually enter the AI SAT on the North Star.
add: The North Star AI SAT has been redone.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. labels Apr 27, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@Farquaar
Copy link
Contributor

Farquaar commented Apr 27, 2023 •
edited

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

how alarming
ban he

@MTandi
Copy link
Contributor

MTandi commented Apr 27, 2023

Is it really ok to leave all SMES unprotected?

@Cheshify
Copy link
Contributor Author

Is it really ok to leave all SMES unprotected?

Y'know, looking at it. It's probably fine? I think I'd need more info in the future to see if it's an actual issue.

@MTandi
Copy link
Contributor

MTandi commented Apr 27, 2023

Y'know, looking at it. It's probably fine? I think I'd need more info in the future to see if it's an actual issue.

Really? Imagine if you're malf. Then all they need to do is to come break those SMES and wait until your APC discharges. And turrets won't help you.

@Cheshify
Copy link
Contributor Author

Y'know, looking at it. It's probably fine? I think I'd need more info in the future to see if it's an actual issue.

Really? Imagine if you're malf. Then all they need to do is to come break those SMES and wait until your APC discharges. And turrets won't help you.

Good point, updated.

@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Apr 28, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Apr 29, 2023
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 1, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 1, 2023
@Cheshify
Copy link
Contributor Author

Cheshify commented May 2, 2023

redid power so it only has an input and a power sink can't murder the AI

@Maurukas Maurukas added this to the NorthStar milestone May 2, 2023
@Maurukas Maurukas merged commit 6c1c6ea into tgstation:master May 2, 2023
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Your Fix/Feature pull request is currently below zero (-5). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request May 3, 2023
@github-actions
Updating GBP balances for #75006
4179493
comfyorange added a commit that referenced this pull request May 3, 2023
@comfyorange
Automatic changelog for PR #75006 [ci skip]
dfecc43
@SkyratBot SkyratBot mentioned this pull request May 3, 2023
Closed
@TaleStationBot TaleStationBot mentioned this pull request May 3, 2023
Merged
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request May 3, 2023
@TaleStationBot @Cheshify
[MIRROR] [MDB IGNORE] North Star AI SAT rework (#5602)
7c0ae16 
Original PR: tgstation/tgstation#75006
-----
## About The Pull Request

Redoes the AI SAT so the AI is better protected and command can actually
access it.

![aisat](https://user-images.githubusercontent.com/73589390/235808212-4e987c34-37de-4c90-8271-26a30b271fac.png)


## Why It's Good For The Game
AI is as protected as it is on other maps + fair to malf AI + command
can reach SAT
## Changelog
:cl:
fix: Command can actually enter the AI SAT on the North Star.
add: The North Star AI SAT has been redone.
/:cl:

---------

Co-authored-by: Cheshify <73589390+Cheshify@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maurukas Maurukas Maurukas approved these changes

@EOBGames EOBGames Awaiting requested review from EOBGames EOBGames is a code owner

@MMMiracles MMMiracles Awaiting requested review from MMMiracles MMMiracles is a code owner

@san7890 san7890 Awaiting requested review from san7890 san7890 is a code owner

@ShizCalev ShizCalev Awaiting requested review from ShizCalev ShizCalev is a code owner

Assignees
No one assigned
Labels
Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Milestone
NorthStar
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Cheshify @Farquaar @MTandi @Maurukas @tgstation-server