Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

North Star Large Fix Quantity (And Also Some Design) #75024

Merged
merged 8 commits into from May 6, 2023

Conversation

Cheshify
Copy link
Contributor

@Cheshify Cheshify commented Apr 28, 2023

About The Pull Request

aisat
carg

I was just going to fix the cargo shuttle but I noticed that there were more minor issues I could easily fix

  • Opens the cargo bay up slightly
  • fixes and reworks broken conveyors on the cargo shuttles
  • moves a floating camera in atmos
  • adds the correct exoscanner boards to the drone bay
  • adds missing restaurant and bar portals
  • gives the warden their desk and crew monitor
  • gives virology more signage and the public quarantine room starts open
  • gives medbay an organ storage fridge
  • vault bolted roundstart
  • AI upload bolted roundstart
  • adds more monkey cubes to encourate alternate xenobio playstyle (specific goals instead of broad goals)

Why It's Good For The Game

Well they're all just change to further make the map more enjoyable while staying in-line with design elements I had in mind.

  • The big cargo ones just make it more streamlined for miners to interact with the station and fix some issues with the shuttle.
  • Exoscanners having the right boards is good for that side content.
  • Floating cameras are bad and ugly
  • The warden having a front desk and crew monitor help them interact with both sec and the crew more often.
  • Virology was apparently a little hard to find, and to further encourage people to use the public isolation room, it's shutters start up so people can see it.
  • Medbay should probably have a place to store gibbed things.
  • The xenobio changes are probably going to be the most controversial ones. XB is small, not to discourage it's use, but to encourage (experiment with?) an alternate style of play where xenobiologists target down specific slimes/crossbreeds and then move on to interact with the crew (whether that be antagonizing the crew, or helping them out with neat slime stuff). I think these changes can possibly remedy the issue of "wahh wahhh xenobio small" by making it more effective at it's intended alternate design. (random slime now a part of One Random Slime on the North Star #75126)

Changelog

🆑
fix: The North Star's cargo shuttle has working conveyors.
fix: The North Star has had a slew of missing and improperly done content added and reworked, see the PR for more!
/:cl:

@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. labels Apr 28, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@Timonkeyn
Copy link

From what I can tell, the slime spawner can currently spawn the rainbow slime too if i am not mistaken. It is supposed to be a rare curated slime and as such it can spawn any extract, which would go against your design philosophy (on top of being supposed to be rarer than the other ones)

Also 3 monkey boxes is the most of any map(?)

@Cheshify
Copy link
Contributor Author

Cheshify commented May 2, 2023

Added some discussion in the thread but basically trying to make a T1 random slime spawner seems to be a little out of scope, so I've removed the random slime spawn for now. If anyone has any ideas on how to keep the design choice without altering code too much, I'd love to hear it.

@Cheshify
Copy link
Contributor Author

Cheshify commented May 2, 2023

#75126

@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 3, 2023
@github-actions github-actions bot added Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts and removed Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts labels May 3, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 4, 2023
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 6, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 6, 2023
Copy link
Member

@Maurukas Maurukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your cargo shuttle docking port is broken:
image

Other than that I see no issues.

@Cheshify
Copy link
Contributor Author

Cheshify commented May 6, 2023

Update: I also redid the cargo shuttle AGAIN because it just wasn't as cool as I wanted it to be
aisat

@github-actions github-actions bot requested a review from Maurukas May 6, 2023 14:59
@Cheshify
Copy link
Contributor Author

Cheshify commented May 6, 2023

Oh yeah the Dwidth issue was fixed as well

@Maurukas Maurukas added this to the NorthStar milestone May 6, 2023
@Maurukas Maurukas merged commit bfcbc6c into tgstation:master May 6, 2023
18 checks passed
comfyorange added a commit that referenced this pull request May 6, 2023
github-actions bot added a commit that referenced this pull request May 6, 2023
Jolly-66 added a commit to TaleStation/TaleStation that referenced this pull request May 6, 2023
…sign) (#5657)

Original PR: tgstation/tgstation#75024
-----
## About The Pull Request

![aisat](https://user-images.githubusercontent.com/73589390/235265428-55b72f54-8011-4a09-a761-f979944aa925.png)

![carg](https://user-images.githubusercontent.com/73589390/235265435-7d6b3233-5e30-421a-830e-9393450b2488.png)

I was just going to fix the cargo shuttle but I noticed that there were
more minor issues I could easily fix
- Opens the cargo bay up slightly
- fixes and reworks broken conveyors on the cargo shuttles
- moves a floating camera in atmos
- adds the correct exoscanner boards to the drone bay
- adds missing restaurant and bar portals
- gives the warden their desk and crew monitor
- gives virology more signage and the public quarantine room starts open
- gives medbay an organ storage fridge
- vault bolted roundstart
- AI upload bolted roundstart
- adds more monkey cubes to encourate alternate xenobio playstyle
(specific goals instead of broad goals)
## Why It's Good For The Game
Well they're all just change to further make the map more enjoyable
while staying in-line with design elements I had in mind.
- The big cargo ones just make it more streamlined for miners to
interact with the station and fix some issues with the shuttle.
- Exoscanners having the right boards is good for that side content.
- Floating cameras are bad and ugly
- The warden having a front desk and crew monitor help them interact
with both sec and the crew more often.
- Virology was apparently a little hard to find, and to further
encourage people to use the public isolation room, it's shutters start
up so people can see it.
- Medbay should probably have a place to store gibbed things.
- The xenobio changes are probably going to be the most controversial
ones. XB is small, not to discourage it's use, but to encourage
(experiment with?) an alternate style of play where xenobiologists
target down specific slimes/crossbreeds and then move on to interact
with the crew (whether that be antagonizing the crew, or helping them
out with neat slime stuff). I think these changes can possibly remedy
the issue of "wahh wahhh xenobio small" by making it more effective at
it's intended alternate design. (random slime now a part of #75126)
## Changelog
:cl:
fix: The North Star's cargo shuttle has working conveyors.
fix: The North Star has had a slew of missing and improperly done
content added and reworked, see the PR for more!
/:cl:

Co-authored-by: Cheshify <73589390+Cheshify@users.noreply.github.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants