Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for small problem #7503

Closed
wants to merge 1 commit into from
Closed

Small fix for small problem #7503

wants to merge 1 commit into from

Conversation

volas
Copy link
Contributor

@volas volas commented Feb 1, 2015

No description provided.

@Menshin
Copy link
Contributor

Menshin commented Feb 1, 2015

What was the non-standard character ?

Was there any proc that was affected by this infinite loop ? (I think this old sanitizing proc is still used somewhere in the code)

@volas
Copy link
Contributor Author

volas commented Feb 1, 2015

What was the non-standard character ?

Maybe once it was a russian "я" letter ("я" = "Я"), but due to problems with encodings at some point it was "broken". Or maybe someone left it specially. Who knows.

Was there any proc that was affected by this infinite loop ? (I think this old sanitizing proc is still used somewhere in the code)

sanitize() use it, and sanitize() is used in many places. https://github.com/tgstation/-tg-station/search?utf8=%E2%9C%93&q=sanitize%28

@Menshin
Copy link
Contributor

Menshin commented Feb 1, 2015

Yeah, apparently it's still used a lot...
I've a PR dealing with sanitizing procs opened already (#7471), to avoid merge conflicts i'll add your fix to it.

Thanks for pointing this out.

@volas
Copy link
Contributor Author

volas commented Feb 1, 2015

Yeah, well, then I close my PR

@volas volas closed this Feb 1, 2015
@Deantwo
Copy link
Contributor

Deantwo commented Feb 2, 2015

What about goimg back in the commit history and see what the symbol was.
That is one of the reasons to use version-control after all.

But yeah I had been wondering what it was too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants