Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Medical job: The Coroner #75065

Merged
merged 80 commits into from May 6, 2023
Merged

Conversation

JohnFulpWillard
Copy link
Member

@JohnFulpWillard JohnFulpWillard commented Apr 30, 2023

About The Pull Request

HackMD: https://hackmd.io/RE9uRwSYSjCch17-OQ4pjQ?view

Feedback link: https://tgstation13.org/phpBB/viewtopic.php?f=10&t=33972

Adds a Coroner job to the game, they work in the Medical department and have their office in the Morgue.
I was inspired to make this after I had played my first round on Paradise and messed around in there. The analyzer is copied from there (ParadiseSS13/Paradise#20957), and their jumpsuit is also mostly stolen from it (i just copied the color scheme onto our own suits).

Coroners can perform autopsies on people to see their stats, like this
image

They have access to Medbay, and on lowpop will get Pharmacy (to make their own formaldehyde). They also have their own Secure Morgue access for their office (doubles as a surgery room because they are edgelords or whatever) and the secure morgue trays.

Secure Morgue trays spawn with their beepers off and is only accessible by them, the CMO, and HoS. It's used to morgue Antagonists. Security's own morgue trays have been removed.

The job in action

https://cdn.discordapp.com/attachments/950489581151735849/1102297675669442570/2023-04-30_14-16-06.mp4

Surgery changes

Autopsies are a Surgery, and I tried to intertwine this with the Dissection surgery.
Dissections and Autopsies both require the Autopsy scanner to perform them, however you can only perform one on any given body. Dissections are for experiments, Autopsies is for the paper of information.

Dissected bodies now also give a ~20% surgery speed boost, this was added at the request of Fikou as a way to encourage Doctors to let the Coroner do their job before reviving a body.
I also remember the Medical skill, which allowed Doctors to do surgery faster on people, and I hope that this can do something like that WITHOUT adding the potential for exploiting, which led to the skill's downfall.

Morgue Improvements

Morgue trays are no longer named with pens, they instead will steal the name of the last bodybag to be put in them.

Morgue trays are also removed from Brig Medical areas and Robotics, now they have to bring their corpses to the Morgue where the Coroner can keep track and ensure records are properly updated.

Sprite credits

I can't fit it all in the Changelog, so this is who made what

McRamon

  • Autopsy scanner

Tattax

  • Table clock sprites and in-hands

CoiledLamb

  • Coroner jumpsuits & labcoats (inhand, on sprite, and their respective alternatives)
  • Coroner gloves
  • CoronerDrobe (the vending machine)

Why It's Good For The Game

This is mostly explained in the hackmd, but the goal of this is:

  1. Increase the use of the Medical Records console.
  2. Add a new and interesting way for Detectives to uncover mysteries.
  3. Add a more RP-flavored role in Medical that still has mechanics tied behind it.

Changelog

🆑 JohnFulpWillard, sprites by McRamon, tattax, and Lamb
add: The Coroner, a new Medical role revolving around dead corpses and autopsies.
add: The Coroner's Autopsy Scanner, used for discovering the cause for someone's death, listing their wounds, the causes of them, their reagents, and diseases (including stealth ones!)
qol: Morgue Trays are now named after the bodybags inside of them.
balance: The morgue now has 'Secure' morgue trays which by default don't beep.
balance: Security Medical area and Robotics no longer have their own morgue trays.
balance: Dissected bodies now have faster surgery speed. Autopsies also count as dissections, however they're mutually exclusive.
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges Map Edit Thank you for your tile-placing service. It's always appreciated. Quality of Life Increasing esword damage is not a quality of life for traitors labels Apr 30, 2023
@Cheshify
Copy link
Contributor

Well shit, no idea how this is going to fit into the North Star morgue without significant tweaks. How much space/new machines do they need?

@JohnFulpWillard
Copy link
Member Author

They have a secure morgue area with ~4 morgue trays behind a windoor
An office with surgery kit, organ fridge, medical records laptop, and a filing cabinet to store their papers in

Everything else is just normal morgue stuff

@Helg2
Copy link
Contributor

Helg2 commented Apr 30, 2023

I'm quite sure this will just be lawyer like job.
Also shouldn't there be an envirosuit version for coroner plasmamen?

@JohnFulpWillard
Copy link
Member Author

I'm quite sure this will just be lawyer like job.

I'd be happy if it's the case, I love lawyer.

Also shouldn't there be an envirosuit version for coroner plasmamen?

They currently use the Medical envirosuit, I'm not spriter so I don't think I can do better.

@Striders13
Copy link
Contributor

imo it would be better to integrate this into detective instead, he doesn't have a ton of content outside of clicking on sus things and acting as officer. Cool stuff tho.

@SpaceVampire
Copy link
Contributor

This is a cool idea, but I agree with the person above.
It feels like this could be a good way to expand the already existing investigative role.
Not sure if this is really enough context to hold up as it's own thing.

@Mothblocks
Copy link
Member

imo it would be better to integrate this into detective instead, he doesn't have a ton of content outside of clicking on sus things and acting as officer. Cool stuff tho.

Exactly my thoughts reading the doc. Detective already doesn't have too much, why are we denying it this content?

@JohnFulpWillard
Copy link
Member Author

JohnFulpWillard commented Apr 30, 2023

I didn't want to put this to the Detective because he's a Security job. I want this role to be active to taking dead bodies, performing the autopsy, morguing, and updating medical records. If it's a security job, I feel like they won't do it unless they know some antag killed them, and Detective being unable to roll antag means there's no use in this new 'secure' morgue area.

If it's moved to a Service job I'd be fine with it, moving Detective away from 'hunting antags' and more into this type of stuff.

I have it briefly mentioned in the alternatives section but it it's not really explained much
image

@saprasam
Copy link

an autopsy machine would be far better in the detective's hands for sniffing out crime

@MMMiracles
Copy link
Contributor

time to remake tram med again

@DATA-xPUNGED
Copy link
Contributor

I also agree with the others, Dets don't have many tools right now, this should be a neat one

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 5, 2023
@JohnFulpWillard JohnFulpWillard marked this pull request as ready for review May 5, 2023 05:26
JohnFulpWillard and others added 4 commits May 5, 2023 11:55
Now that dissections require an autopsy scanner, and because there's only 1 scanner mapped in which could be lost, I would like there to have an alternative to get a scanner so the station won't be blocked from literally ever getting dissection experiments done.
Copy link
Member

@Fikou Fikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its good to merge

@msgerbs
Copy link
Contributor

msgerbs commented May 5, 2023

Would it be too much to give the detective coroner access (and vice versa?) on lowpop at least?

@JohnFulpWillard
Copy link
Member Author

The detective already has coroner access by default why would i need to give it on lowpop
And why would a medical job be getting brig access on lowpop either

@MMMiracles MMMiracles merged commit 1674f25 into tgstation:master May 6, 2023
18 checks passed
github-actions bot added a commit that referenced this pull request May 6, 2023
comfyorange added a commit that referenced this pull request May 6, 2023
@Kubisopplay
Copy link
Contributor

So you made cyborgs unable to get their own experiments now. Neat.

Jolly-66 added a commit to TaleStation/TaleStation that referenced this pull request May 6, 2023
Original PR: tgstation/tgstation#75065
-----
## About The Pull Request

HackMD: https://hackmd.io/RE9uRwSYSjCch17-OQ4pjQ?view

Feedback link: https://tgstation13.org/phpBB/viewtopic.php?f=10&t=33972

Adds a Coroner job to the game, they work in the Medical department and
have their office in the Morgue.
I was inspired to make this after I had played my first round on
Paradise and messed around in there. The analyzer is copied from there
(ParadiseSS13/Paradise#20957), and their
jumpsuit is also mostly stolen from it (i just copied the color scheme
onto our own suits).

Coroners can perform autopsies on people to see their stats, like this

![image](https://user-images.githubusercontent.com/53777086/235369225-805d482c-56c0-441c-9ef8-a42d0a0192bc.png)

They have access to Medbay, and on lowpop will get Pharmacy (to make
their own formaldehyde). They also have their own Secure Morgue access
for their office (doubles as a surgery room because they are edgelords
or whatever) and the secure morgue trays.

Secure Morgue trays spawn with their beepers off and is only accessible
by them, the CMO, and HoS. It's used to morgue Antagonists. Security's
own morgue trays have been removed.

The job in action


https://cdn.discordapp.com/attachments/950489581151735849/1102297675669442570/2023-04-30_14-16-06.mp4

### Surgery changes

Autopsies are a Surgery, and I tried to intertwine this with the
Dissection surgery.
Dissections and Autopsies both require the Autopsy scanner to perform
them, however you can only perform one on any given body. Dissections
are for experiments, Autopsies is for the paper of information.

Dissected bodies now also give a ~20% surgery speed boost, this was
added at the request of Fikou as a way to encourage Doctors to let the
Coroner do their job before reviving a body.
I also remember the Medical skill, which allowed Doctors to do surgery
faster on people, and I hope that this can do something like that
WITHOUT adding the potential for exploiting, which led to the skill's
downfall.

### Morgue Improvements

Morgue trays are no longer named with pens, they instead will steal the
name of the last bodybag to be put in them.

Morgue trays are also removed from Brig Medical areas and Robotics, now
they have to bring their corpses to the Morgue where the Coroner can
keep track and ensure records are properly updated.

### Sprite credits

I can't fit it all in the Changelog, so this is who made what

McRamon
- Autopsy scanner

Tattax 
- Table clock sprites and in-hands

CoiledLamb
- Coroner jumpsuits & labcoats (inhand, on sprite, and their respective
alternatives)
- Coroner gloves
- CoronerDrobe (the vending machine)

## Why It's Good For The Game

This is mostly explained in the hackmd, but the goal of this is:

1. Increase the use of the Medical Records console.
2. Add a new and interesting way for Detectives to uncover mysteries.
3. Add a more RP-flavored role in Medical that still has mechanics tied
behind it.

## Changelog

:cl: JohnFulpWillard, sprites by McRamon, tattax, and Lamb
add: The Coroner, a new Medical role revolving around dead corpses and
autopsies.
add: The Coroner's Autopsy Scanner, used for discovering the cause for
someone's death, listing their wounds, the causes of them, their
reagents, and diseases (including stealth ones!)
qol: Morgue Trays are now named after the bodybags inside of them.
balance: The morgue now has 'Secure' morgue trays which by default don't
beep.
balance: Security Medical area and Robotics no longer have their own
morgue trays.
balance: Dissected bodies now have faster surgery speed. Autopsies also
count as dissections, however they're mutually exclusive.
/:cl:

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
@JohnFulpWillard JohnFulpWillard deleted the coroner branch June 25, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Config Update Time to bother the headadmins for three months to get your config applied Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. Quality of Life Increasing esword damage is not a quality of life for traitors Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes. UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet