Adds proper armor for security plasmamen. #75156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Balance
|
#58318 Gave better helmets for the Atmos/CE plasmamen so they don't need to swap their clothing to keep up with the job's standard protection. Any security plasmamen has easy access to swap their armorless clothing for the default armored version, this mostly lets them keep their plasmamen uniform on so medbay realize they can't be fully stripped, which end in round removal for most plasmamen that end up like that at medbay... |
|
At the end of the day an armored plasmameme sec officer will be much worse off against someone who is using any decent amount of armor penetration so I dont see anything wrong with this pr. The pr only makes a difference in situations where armor should matter regardless how fragile you are underneath (ghetto weapons) |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
ExcessiveUseOfCobblestone
requested changes
May 16, 2023
There was a problem hiding this comment.
tgstation/code/modules/clothing/head/jobs.dm
Lines 182 to 191 in 54523c8
Please subtype from the respective sec armor datum so we
- can visually tell whats being changed from normal HoS
- do not have to change both values if we ever decide to mess with say hos melee for instance.
ExcessiveUseOfCobblestone
removed
the
Stale
|
i just need to look at the det sprites you gave it to see if im ok with it looking like that but having det armor |
Maybe i should just make it subtype of white envirousuit but dunno |
|
my concern is related to "this looks no different than X suit but has detective tier armor" so i just need to check out the sprite itself unless its used exclusively for sec already |
|
It's used for bartender and psychologist. |
|
Your Fix/Feature pull request is currently below zero (-16). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
comfyorange
added a commit
that referenced
this pull request
May 17, 2023
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
May 17, 2023
Original PR: tgstation/tgstation#75156 ----- ## About The Pull Request It's kinda strange that security plasmamen has no proper armor and you can just bully them with bottlesmashes. Literally. Also suits had no wound armor for some reason, which considering that mold dies without hand kinda silly too. And helmets just had no armor besides 1 melee armor. ## Why It's Good For The Game Plasmamen security won't die that easilly. I mean, still easy to kill them, but not that much. ## Changelog :cl: balance: Security Plasmamen now have Security armor. No bullying them with bottlesmashes anymore. /:cl: --------- Co-authored-by: Helg2 <93882977+Helg2@users.noreply.github.com>
Peliex
added a commit
to Peliex/tgstation
that referenced
this pull request
May 20, 2023
commit be71408 Merge: 6415708 6f13ac6 Author: Niko <20830349+Peliex@users.noreply.github.com> Date: Fri May 19 22:11:07 2023 -0700 Merge branch 'beebetter' of https://github.com/Peliex/tgstation into beebetter commit 6415708 Author: Niko <20830349+Peliex@users.noreply.github.com> Date: Fri May 19 22:10:33 2023 -0700 fixed relative path issues commit 6f13ac6 Merge: 2b89615 8d00ac1 Author: Oreo <20830349+Peliex@users.noreply.github.com> Date: Fri May 19 18:14:19 2023 -0700 Merge branch 'master' into beebetter commit 2b89615 Author: Niko <20830349+Peliex@users.noreply.github.com> Date: Fri May 19 17:55:11 2023 -0700 changed honeycomb to a food item honeycomb refactor changed all references of /obj/item/reagent_containers/honeycomb to /obj/item/food/honeycomb allow reagent grinder to skip processing if the bag is empty reagent grinder now accepts honeycomb commit 8d00ac1 Author: Changelogs <action@github.com> Date: Sat May 20 00:21:54 2023 +0000 Automatic changelog compile [ci skip] commit a14b490 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Fri May 19 18:31:54 2023 -0400 Fixes master (tgstation#75546) ## About The Pull Request Fixes skew between tgstation#75440 & tgstation#75389 - Due to a repathing. ## Why It's Good For The Game ## Changelog commit 127276b Author: san7890 <the@san7890.com> Date: Fri May 19 15:58:39 2023 -0600 Fixes needless area placements on Lavaland (tgstation#75514) We don't need cameras to be placed in the area as long as they're connected to a wall in the area, this was just an old workaround that never got cleaned up. commit bef4e10 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Sat May 20 09:56:23 2023 +1200 Automatic changelog for PR tgstation#75516 [ci skip] commit 9ae0802 Author: san7890 <the@san7890.com> Date: Fri May 19 15:55:59 2023 -0600 Converts Killer Tomatoes to Basic Mobs (tgstation#75516) Just another lightweight PR porting over a simple animal to the basic mob framework with zero additional AI implementation (it's a killer tomato- it spawns into the world to maul you. how much more intricate does it need to be?). commit 8eb354a Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Sat May 20 09:01:22 2023 +1200 Automatic changelog for PR tgstation#75389 [ci skip] commit 199c250 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Fri May 19 17:01:01 2023 -0400 Reworks gym equipment (tgstation#75389) ## About The Pull Request Gym equipment are currently ported from Goon code, and I didn't like how it currently worked as it was buggy and the code was a mess. I decided to just rework how they worked entirely. I left the parts that weren't Goon code (like tooltips & deconstruction) alone because it's not goon code and I think it's fine that way. - Now you buckle yourself to it (like a chair, I didn't like how it didn't work like one) and can work out with an action button you get on buckle, you can do as many sets as you want, then unbuckle & go. - You aren't hardstunned for 8 seconds for clicking on it anymore, you aren't flying around because the stun doesn't even last the duration of the animation anymore. Video demonstration https://github.com/tgstation/tgstation/assets/53777086/f5ae86f1-65fb-46c6-8a5f-8f9d9f0548b3 ## Why It's Good For The Game Reworks old code Removes un-documented Goon code Makes gym equipment less broken than it currently is. ## Changelog 馃啈 qol: Gym equipment was reworked. You now buckle yourself to weight machines to use them, rather than clicking on it and getting stunned for a few seconds. It also means it works like a chair now. qol: Gym equipment no longer breaks a sweat in no gravity. /馃啈 --------- Co-authored-by: san7890 <the@san7890.com> commit 4bfaba5 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Sat May 20 06:52:51 2023 +1200 Automatic changelog for PR tgstation#75488 [ci skip] commit dfed295 Author: ShizCalev <ShizCalev@users.noreply.github.com> Date: Fri May 19 14:52:31 2023 -0400 Turf Icons Unit Test (tgstation#75488) unit tests turf icons to find... well, missing icons. honk. fixes tgstation#75372 corrects a bunch of things messed up in tgstation#65504 馃啈 ShizCalev code: Made a new unit test to find turfs with broken/missing icons! Rejoice! fix: Fixed a bunch of incorrect and missing turf icons. /馃啈 commit cb24c10 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 17:18:04 2023 +1200 Automatic changelog for PR tgstation#75360 [ci skip] commit e2d4263 Author: Tim <timothymtorres@gmail.com> Date: Fri May 19 00:17:27 2023 -0500 Add extra clothing options to equip mob outfits (tgstation#75360) ## About The Pull Request This adds some extra clothing categories as options when selecting custom uniforms to equip a mob with. There was also a change of one letter vars to be more descriptive. ## Why It's Good For The Game More customization for uniforms. ## Changelog 馃啈 code: Add extra clothing options to equip mob outfits. Replaced many one-letter vars in file with better descriptions. /馃啈 commit 20e26e9 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 13:32:39 2023 +1200 Automatic changelog for PR tgstation#75458 [ci skip] commit cf50ba3 Author: Charlotte <98856144+orthography@users.noreply.github.com> Date: Thu May 18 18:31:27 2023 -0700 Fixes Tramstation Genetics Pen Chasm Dirt (tgstation#75458) commit ad4a199 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 13:00:30 2023 +1200 Automatic changelog for PR tgstation#75503 [ci skip] commit 033e1b4 Author: Jordan Dominion <Cyberboss@users.noreply.github.com> Date: Thu May 18 21:00:08 2023 -0400 Fix SHOULD_NOT_SLEEP hit in borg adjustable tracer bolts (tgstation#75512) See tgstation#75232 commit 1c1f15f Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 12:56:32 2023 +1200 Automatic changelog for PR tgstation#75515 [ci skip] commit 8c70ff2 Author: Profakos <profakos@gmail.com> Date: Fri May 19 02:54:00 2023 +0200 [NO GBP] Adds missing wrappers to request consoles messages (tgstation#75503) ## About The Pull Request Request consoles messages and announcement were not trimmed and sanitized properly. This PR fixes this, sorry about that. Sadly, does not solve tgstation#75494. Is there a proc that trims excess whitespace _inside_ messages? There are many places that needs this. ## Why It's Good For The Game Whitespace after and before texts should be trimmed, and HTML stuff should be encoded and stripped properly for safety. ## Changelog 馃啈 fix: fixes request console messages not being trimmed and encoded properly /馃啈 commit e2bc712 Author: san7890 <the@san7890.com> Date: Thu May 18 18:52:20 2023 -0600 Converts Lizards to Basic Mobs (tgstation#75515) This was pretty simple since they didn't have too much custom behavior, and whatever they did have already had AI behavior. I got really burned out the last two times I wrote intricate AI action/decision behaviors so I'm just taking it light and doing the bare minimum. one day our shackles will be free of the simple animal scourge. they're also a bit more intelligent, and i daresay a bit cuter too now. also that lizard gib animation has been sitting there for god knows how long completely unseen, so let's actually hook it into the mob. commit bb15a56 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 12:52:10 2023 +1200 Automatic changelog for PR tgstation#75473 [ci skip] commit f992460 Author: Andrew <mt.forspam@gmail.com> Date: Fri May 19 03:51:49 2023 +0300 [NO GBP] Runtimes in mapping helpers (tgstation#75473) ## About The Pull Request There were some attempts to get an area of an object that is confirmed to be null in the condition, which resulted in runtimes when the helper couldn't find an object. Also ensures that the window spawner places window before the helper tries to find it. And updates damaged window integrity roll thresholds to guarantee cracks. ## Why It's Good For The Game No runtimes ## Changelog 馃啈 fix: fixed possible issues with apc, airalarm and damaged machinery/windows helpers /馃啈 commit 5974d6d Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 12:51:31 2023 +1200 Automatic changelog for PR tgstation#75509 [ci skip] commit 67b19f0 Author: DaydreamIQ <62606051+DaydreamIQ@users.noreply.github.com> Date: Fri May 19 01:51:11 2023 +0100 Dragon can no longer place their portals outside the station on Tram (tgstation#75509) ## About The Pull Request So because of some area flag nonsense, space dragon could put down their portals pretty much ANYWHERE that was classed as 'The station asteroid'. Despite those places also including the little asteroids dotted around the edges of the map, this PR removes that possibility. ## Why It's Good For The Game I don't think it was intended at all for dragon to be able to fly all the way to the southwest of tram and hide their portal miles away from the station. ## Changelog 馃啈 fix: Space Dragon can no longer place their portals outside the station on Tramstation /馃啈 commit 77e5880 Author: Changelogs <action@github.com> Date: Fri May 19 00:19:26 2023 +0000 Automatic changelog compile [ci skip] commit aec0124 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 10:12:24 2023 +1200 Automatic changelog for PR tgstation#75263 [ci skip] commit 642722a Author: Thunder12345 <Thunder12345@users.noreply.github.com> Date: Thu May 18 23:04:36 2023 +0100 Adds a blacklist for putting guns in turrets (tgstation#75263) ## About The Pull Request Fixes tgstation#75197 Adds a global list of gun types banned from being added to turrets. Adds dueling pistols to the banned list as they can freely round remove people when in turrets without the usual restrictions. ## Why It's Good For The Game Instakill turrets are an undesirable outcome. ## Changelog 馃啈 fix: Dueling pistols can no longer be fitted in turrets to instantly kill people. /馃啈 commit e6275a1 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 10:04:00 2023 +1200 Automatic changelog for PR tgstation#75505 [ci skip] commit c9f0917 Author: Thunder12345 <Thunder12345@users.noreply.github.com> Date: Thu May 18 23:02:10 2023 +0100 Double clicking on your corpse (or something containing it) no longer makes you automatically re-enter it (tgstation#75505) ## About The Pull Request Removes the check for reentering your body when double clicking on things as a ghost. ## Why It's Good For The Game Perhaps my experience is not universal, but I have never found an occasion where I did this and wanted to re-enter my corpse, and conversely many occasions where I want to orbit my corpse and find myself re-entering it instead. Any form of revival will pull you back into your body automatically these days and there's no real benefit to being in your corpse, and in the rare circumstance someone wants to do this the verb is still available. ## Changelog 馃啈 qol: Double clicking your corpse or something containing it as a ghost will now orbit as in other cases instead of re-entering your corpse. /馃啈 commit 442c303 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 09:56:36 2023 +1200 Automatic changelog for PR tgstation#75499 [ci skip] commit 02b32b8 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 09:56:31 2023 +1200 Automatic changelog for PR tgstation#75508 [ci skip] commit 7b6635c Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 09:56:13 2023 +1200 Automatic changelog for PR tgstation#75490 [ci skip] commit 914d344 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Thu May 18 23:54:44 2023 +0200 fixes clown planet report (tgstation#75508) ## About The Pull Request it looked if a typepath was in the list of station traits instead of an instance ## Why It's Good For The Game we did it ## Changelog 馃啈 fix: fixes clown planet report /馃啈 commit d8dcac2 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Thu May 18 14:53:46 2023 -0700 Adjust stowaway changeling requirements to look more like roundstart Changelings (tgstation#75499) Copies the weights of roundstart changelings, these were too low and I was linked some reasonably low threat rounds on low pop getting them. ## Changelog 馃啈 balance: Adjusted stowaway changeling requirements to be closer to roundstart Changelings. /馃啈 commit 3b5b5bf Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Thu May 18 16:53:34 2023 -0500 Fixes bad call to heretic on research + outdated signal (tgstation#75490) ## About The Pull Request - This never got updated from the fully heal refactor - Second arg to on research needs to be the heretic datum it's being called on ## Why It's Good For The Game Runtimes ## Changelog 馃啈 Melbert fix: Ahealing a heretic now properly gives them their heart back /馃啈 commit 2565063 Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Date: Thu May 18 10:59:34 2023 -0700 Fixes a tgui say runtime (tgstation#75502) ## About The Pull Request Oopsie doopsie: Need to send the object, not just a boolean ## Why It's Good For The Game Fixes a runtime ## Changelog N/A no player facing commit d054832 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Thu May 18 19:53:23 2023 +0200 Deletes an unused defines file (tgstation#75504) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request unused <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- Both 馃啈's are required for the changelog to work! You can put your name to the right of the first 馃啈 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com> commit 05cd93e Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 05:48:30 2023 +1200 Automatic changelog for PR tgstation#75496 [ci skip] commit 4a2df9b Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Thu May 18 12:48:09 2023 -0500 Fixes Request Console Announcements (tgstation#75496) ## About The Pull Request Fixes tgstation#75495 and Fixes tgstation#75492 (?) `treat_message` had its arguments changed in tgstation#74775 which skewed with tgstation#75067 ## Why It's Good For The Game Bugfix ## Changelog 馃啈 Melbert fix: Request Console Announcements breaking and reporting "/list" /馃啈 commit c6b291b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Fri May 19 03:34:10 2023 +1200 Automatic changelog for PR tgstation#75501 [ci skip] commit ff6102a Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Thu May 18 17:33:00 2023 +0200 Fixes some TTS setup (tgstation#75501) ## About The Pull Request Fixes the api not working + instructions 馃啈 fix: fixed TTS not working when used by local servers /馃啈 Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com> commit d25e096 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 12:52:00 2023 +1200 Automatic changelog for PR tgstation#75470 [ci skip] commit a056a2a Author: YakumoChen <king_yoshi42@yahoo.com> Date: Thu May 18 00:51:06 2023 +0000 Glass bottles can be used as ghetto rolling pins (tgstation#75470) ## About The Pull Request Glass bottles are long cylinders and functionally identical to a rolling pin, so they work as one just in case you're too lazy to go find some wood planks, or you're multitasking as the Bartender. Ever so slightly slower to use than just getting a normal rolling pin. ## Why It's Good For The Game Ghetto alternative just in case the librarian is threatening to gut you if you keep trying to crowbar the shelves. Makes sense from a realistic standpoint and I don't think it'll cause any issues with reagents since rollingpin tool use is pretty niche. ## Changelog 馃啈 qol: Bar bottles now work as makeshift rolling pins /馃啈 commit 551c357 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 12:47:59 2023 +1200 Automatic changelog for PR tgstation#75477 [ci skip] commit d439808 Author: Jacquerel <hnevard@gmail.com> Date: Thu May 18 01:47:36 2023 +0100 Cursed quirk doesn't go away after triggering a single time (tgstation#75477) ## About The Pull Request Fixes tgstation#75471 Someone added some optional initialise arguments and forgot to make an important one optional, leading to it always setting the "permanent" value to "null", which of course evaluates falsily to FALSE. ## Why It's Good For The Game If you take this quirk you _want_ to be repeatedly pulverised by vending machines until your skull pops. We shouldn't deny people their agency. ## Changelog 馃啈 fix: The Cursed quirk will once more plague you with bad luck for your entire shift rather than just once. /馃啈 commit d57719d Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 12:21:36 2023 +1200 Automatic changelog for PR tgstation#75489 [ci skip] commit 82766b7 Author: Changelogs <action@github.com> Date: Thu May 18 00:21:13 2023 +0000 Automatic changelog compile [ci skip] commit 303cfa3 Author: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> Date: Wed May 17 20:20:08 2023 -0400 Fixes is_station_level() sometimes behaving erratically if the value provided is more complex than just a variable (tgstation#75489) ## About The Pull Request I have been debugging this stupid macro for the past nearly five hours, to finally figure out why it was breaking. If you had something like `a ||聽0` in what you called the macro with, it would somehow manage to break the cache. This makes it far more foolproof, and will ensure that it doesn't break here anymore, because debugging this has to be one of the biggest pains in my ass I've ever had. ## Why It's Good For The Game So shit like this  Doesn't end up breaking your CI (or even worse, the game in prod), in places unrelated. At least now it shouldn't be overwriting values in the cache. It shouldn't have to do verification that you're doing the right thing, that should be left on the person using the macro because it was meant to be faster than a proc call, adding too much verification overhead kind of just loses some of that speed. ## Changelog 馃啈 GoldenAlpharex fix: Makes checks for the station z level more robust against coders doing less intuitive stuff, thus protecting it from breaking in weirdly difficult and seemingly unrelated places (I'm looking at you, nuke cinematic unit test). /馃啈 commit c6eaefe Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 08:46:14 2023 +1200 Automatic changelog for PR tgstation#75156 [ci skip] commit bc22fef Author: Helg2 <93882977+Helg2@users.noreply.github.com> Date: Wed May 17 23:45:54 2023 +0300 Adds proper armor for security plasmamen. (tgstation#75156) ## About The Pull Request It's kinda strange that security plasmamen has no proper armor and you can just bully them with bottlesmashes. Literally. Also suits had no wound armor for some reason, which considering that mold dies without hand kinda silly too. And helmets just had no armor besides 1 melee armor. ## Why It's Good For The Game Plasmamen security won't die that easilly. I mean, still easy to kill them, but not that much. ## Changelog 馃啈 balance: Security Plasmamen now have Security armor. No bullying them with bottlesmashes anymore. /馃啈 commit 857fd68 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 06:45:12 2023 +1200 Automatic changelog for PR tgstation#75474 [ci skip] commit 2a06092 Author: RealityOverseer <76832653+RealityOverseer@users.noreply.github.com> Date: Wed May 17 13:44:51 2023 -0500 Fix Photographs (tgstation#75474) ## About The Pull Request Fixes tgstation#74869 by adding a 1 to the width and height for the borders of photos which fixes the bug. Upon examining the code it seems like clone_area is found via size_x/y * 2 + 1 while the height and width of the photos were only set to size_x/y * 2. ## Why It's Good For The Game When you take a photo you expect to be able to see the content of the things in the photo. ## Changelog 馃啈Reality Overseer fix: fixed photographs having black borders in photos /馃啈 commit 22917e4 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Thu May 18 01:52:39 2023 +1200 Automatic changelog for PR tgstation#75475 [ci skip] commit 475d5b9 Author: RealityOverseer <76832653+RealityOverseer@users.noreply.github.com> Date: Wed May 17 08:52:18 2023 -0500 Makes elder atmosian statue craftable (tgstation#75475) ## About The Pull Request Fixes tgstation#74534 by making elder atmosian statue craftable. I am not 100% sure if this is the intended way for it to be able to be made or if it's even the right amount of materials but if I need to change it please let me know. ## Why It's Good For The Game Fixing issues is good, having uncraftable things is bad. ## Changelog 馃啈Reality Overseer fix: makes elder atmosian statue craftable /馃啈 --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 487d535 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 15:42:08 2023 +1200 Automatic changelog for PR tgstation#75493 [ci skip] commit 3be0032 Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Tue May 16 22:41:46 2023 -0500 Fixes screwed up latejoin roll checks (tgstation#75493) ## About The Pull Request Messed up changing this to an early returns, results in latejoins triggering much earlier than they should be. ## Why It's Good For The Game Oops ## Changelog 馃啈 Melbert fix: Latejoins triggering before the minimum time set /馃啈 commit f526f45 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 14:27:53 2023 +1200 Automatic changelog for PR tgstation#75002 [ci skip] commit 2845c98 Author: Rhials <Datguy33456@gmail.com> Date: Tue May 16 22:26:40 2023 -0400 Adds a revolutionary conversion stinger (tgstation#75002) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds an antagonist gain stinger for Revolutionaries, created with inspiration from the obsessed/traitor conversion sounds. https://user-images.githubusercontent.com/28870487/235028674-170a4f9e-a873-4938-a700-536f005e539f.mp4 Raw audio: https://cdn.discordapp.com/attachments/440978216484732934/1101964419203862548/revolutionary_tide.ogg _A distant, hypnotic whistling. The heavy footfalls and clamoring voices of an approaching crowd. The unstoppable revolutionary tide breaks its waves upon an unsuspecting station._ I wanted to try and make something that felt like it fit in with the other antagonist stingers we already have. Let me know what you think! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Gives a bit more flavor, and helps set the mood for the upcoming bloodbath. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 馃啈 sound: Revolutionaries now have their own stinger that plays upon becoming that antagonist. /馃啈 <!-- Both 馃啈's are required for the changelog to work! You can put your name to the right of the first 馃啈 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> commit 1cc5859 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 14:19:26 2023 +1200 Automatic changelog for PR tgstation#75431 [ci skip] commit aa74657 Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Date: Tue May 16 19:19:04 2023 -0700 Tgui say v1.1 (tgstation#75431) ## About The Pull Request "It's better! I promise!" When I wrote it, I was inexperienced and pretty angry. Not that I'm any better of a person now, but the code should be. I consolidated instead of relying on heavy abstractions. I simplified logic and wrote more tests. The result should look and feel much more like intended. The bundle size is reduced by ~43%. Types are much stricter. The logic and css classes are much more precise. No major style changes yet  ## Why It's Good For The Game Less javascript is better, and being even a few fractions of a second faster might make better gameplay ## Changelog 馃啈 refactor: Tgui Say is rewritten, becoming "much more performant". Hey, that's what it says on the tin! I'm not from marketing! fix: Tguisay drag zones are now ever so slightly larger around the corner of the window fix: Pressing one of the chat open keys (T/Y/M/O) will no longer change channels if it's already open /馃啈 commit ec7b9fe Author: Changelogs <action@github.com> Date: Wed May 17 00:22:13 2023 +0000 Automatic changelog compile [ci skip] commit 2e85cb1 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:58:43 2023 +1200 Automatic changelog for PR tgstation#75381 [ci skip] commit dd51161 Author: Hoolny <84478872+SethLafuente@users.noreply.github.com> Date: Tue May 16 16:58:22 2023 -0700 Fixes spiderlings having no density (tgstation#75381) Basically making it so they stop other big creatures and each other from moving ## About The Pull Request they block each other and bigger mobs they arent meant to structure spiderlings didn't do this for a reason ## Why It's Good For The Game @san7890 made spiderlings from a structure to a mob great change but they forgot a few things such as 1.Make it so spiderlings don't get tangled on webs (not fixed) 2. Make it so spiderlings speak spider and not galactic common ( fixed) 3. Make it so spiders don't have density ( This PR) This is good for the game because creatures that are floor critters much like roaches and mice shouldn't block full big mobs like humans other spiders or each other (Also this is literary how it was before San just forgot to add it)   ## Changelog 馃啈 fix: fixes spiderlings having density /馃啈 commit aacada3 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:21:45 2023 +1200 Automatic changelog for PR tgstation#75392 [ci skip] commit eb16b39 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:21:09 2023 +1200 Automatic changelog for PR tgstation#75469 [ci skip] commit 54523c8 Author: Helg2 <93882977+Helg2@users.noreply.github.com> Date: Wed May 17 02:15:12 2023 +0300 Makes fire blossoms glowy. (tgstation#75392) ## About The Pull Request They have bioluminescence trait as endershrooms, but don't glow like endershrooms. That's how it looks when grown:  And it has a weaker light when it's harvested:  ## Why It's Good For The Game It's cool. ## Changelog 馃啈 add: Fire Blossoms are now glowy. /馃啈 commit d2d46ec Author: Jacquerel <hnevard@gmail.com> Date: Wed May 17 00:13:01 2023 +0100 Blobs and Kudzu are killed by chasms. (tgstation#75469) ## About The Pull Request Fixes tgstation#75451 Originally I just whitelisted them because they're structures that are supported by their surroundings... but there's still the theoretical scenario where it has expanded over a reasonably large chasm and then becomes almost impossible to remove because you can't easily get at the ones in the middle, and it would be "levitating" after you cut off everything around the edge. So instead this adds a trait which restores the original behaviour of chasms where they delete stuff which falls into them and applies it to Blobs and Kudzu. ## Why It's Good For The Game It's a very niche scenario but "expanding structure falls into abstract chasm storage" causes issues where it potentially keeps processing in there and there isn't much you can do about it. Maybe there's other stuff that commonly falls into chasms we'll decide that we want to delete instead of keeping in pools now that you can just slap a trait onto something to do it, future consideration. ## Changelog 馃啈 fix: Blob and Kudzu tiles which expand into chasms will now be correctly destroyed by the chasm. /馃啈 commit 6937b88 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:11:40 2023 +1200 Automatic changelog for PR tgstation#75463 [ci skip] commit 5a830ab Author: Yaroslav Nurkov <78199449+AnywayFarus@users.noreply.github.com> Date: Wed May 17 02:11:12 2023 +0300 Russian(and another) chat keybindings fix. (tgstation#75463) ## About The Pull Request This PR solves the problem with entering a server with a different (from English) layout and not being able to use chat binds. so far, alas, you need to re-login with the English layout. https://i.imgur.com/WjixRVv.mp4 ## Why It's Good For The Game Resolves an issue for servers based on this build. ## Changelog 馃啈 Vishenka0704 fix: fixed different from english keyboard layout to use tgui chat /馃啈 commit b9cf465 Author: ShizCalev <ShizCalev@users.noreply.github.com> Date: Tue May 16 19:09:55 2023 -0400 uses correct helper for light_cameras() sanity check (tgstation#75455) Touched it in tgstation#75302, just being explicit about what's intended here. commit 7523885 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:08:44 2023 +1200 Automatic changelog for PR tgstation#75457 [ci skip] commit cb62fe8 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Wed May 17 01:08:24 2023 +0200 morgue trays can now be emagged (tgstation#75457) ## About The Pull Request you can emag morgue trays disabling the alarm system ## Why It's Good For The Game keeps your enemies dead :J ## Changelog 馃啈 add: You can emag morgue trays to disable their life alerts. /馃啈 commit 3f926a6 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 11:02:30 2023 +1200 Automatic changelog for PR tgstation#75459 [ci skip] commit 835952c Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Tue May 16 18:02:10 2023 -0500 Drunk slurring scales based on how drunk you are (tgstation#75459) ## About The Pull Request The strength of the slurring effect drunkness applies on you now scales based on how drunk you are. Being "a little" drunk still changes your saymod, and makes you occasionally slur your words...  But being "a lot" drunk kicks it up to 11  Additionally, drunk slurring was separated into "generic slurring" and "drunk slurring", the former which does not scale but less closely resembles drunkness. Generic slurring is used in places such as concussions, so this is an added bonus. As a result of the split, I had to update mind restoration. Now it heals all types of slurring, which does include cult slurs. ## Why It's Good For The Game I, and many other people, always found it very annoying when you became completely illegible from taking one sip of a drink. This seeks to amend that by making low levels of drunkness still for the most part be legible and sane. Average drunkness is roughly the same / equal to the old slurring effect, while "very drunk" is even more illegible and silly (which I find funny). This has the added bonus of separating out "drunk slurring" and "generic slurring", allowing effects to slur your words without going full ham on drunkness (burping and "huhh"s). ## Changelog 馃啈 Melbert add: When you are drunk, the strength of your slurring now varies based on how drunk you are. Being "a little drunk" only rarely slurs your words, being average drunk is the same as the old effect, while being very drunk now slurs your words even more. add: Some non-alcohol sources of slurring, such as concussions, now give "generic slurring" rather than "drunk slurring", which less resemble being drunk (ie, no burping). add: Mind restoration now heals ALL slurring, rather than only drunk slurring (which includes cult / heretic slurring). /馃啈 commit 0ed67b2 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 06:01:06 2023 +1200 Automatic changelog for PR tgstation#75450 [ci skip] commit 562f522 Author: ShizCalev <ShizCalev@users.noreply.github.com> Date: Tue May 16 14:00:01 2023 -0400 Recharger refactor (tgstation#75450) fixes  also better varedit support 馃啈 ShizCalev refactor: Recharger code was modernized a little & will now properly say how much charge you have in a power pack. /馃啈 commit 144aa25 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 05:57:37 2023 +1200 Automatic changelog for PR tgstation#75465 [ci skip] commit 32784db Author: BlueMemesauce <47338680+BlueMemesauce@users.noreply.github.com> Date: Tue May 16 13:57:17 2023 -0400 Fixes "There's a tree in space" adventure (tgstation#75465) ## About The Pull Request Removes the enter effect that set your confusion to 9999 on the epilogue page Having confusion over 30 would send you to the page where you have to either give up or press a button until your confusion goes back under 30. However setting it to 9999 was very confusing as there is no indication how exactly much confusion you had, so players would be sitting there pressing the button over and over again not realizing they were only at like 9643 confusion and had to press it hundreds of more times. Anyway, that doesn't matter since even if they pressed all those buttons and got back to the epilogue, they would just be sent right back to this confusion page after getting confusion set to 9999 again. So it was impossible to beat. Fixes tgstation#75427 Also makes JSON prettier ## Why It's Good For The Game Now you can actually beat the adventure ## Changelog 馃啈 fix: fixed "There's a tree in space" adventure being impossible to beat /馃啈 commit d7746fc Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed May 17 00:03:32 2023 +1200 Automatic changelog for PR tgstation#75144 [ci skip] commit fe9012d Author: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Tue May 16 17:33:09 2023 +0530 Adds general helper proc for processing atmos based on it's turf air contents (tgstation#75144) ## About The Pull Request Fixes this  Caused by this https://github.com/tgstation/tgstation/blob/c8982bfb1cd103539d0be86689f40a023dbb7f22/code/modules/atmospherics/machinery/air_alarm/_air_alarm.dm#L305 Scrubbers will now call ` atmos_conditions_changed()` which starts processing based on the turf air contents which indirectly calls `should_atmos_process()` with the correct values. The same helper has been applied to the atmos sensitive component as well and other places ## Changelog 馃啈 fix: runtime when turning scrubber's on via the air alarm UI refactor: `atmos_conditions_changed()` now starts atmos processing based on it's turf air contents /馃啈 commit 399e590 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue May 16 20:55:58 2023 +1200 Automatic changelog for PR tgstation#75079 [ci skip] commit 0bace67 Author: Hatterhat <31829017+Hatterhat@users.noreply.github.com> Date: Tue May 16 03:53:55 2023 -0500 Some Bolt-Action Fixes (sniper rifle mag manip independent of bolt, among other things) (tgstation#75079) - because pipeguns can no longer misfire, removes the code relevant to cleaning them with a cloth - the above makes it so that you can insert/remove a sniper rifle's magazine regardless of bolt open/close status, which is neat - also nudges some code around so that affixing a bayonet or whacking your gun with any item no longer spams it with "can't jam!" or "bolt closed!" ## Why It's Good For The Game less random irrelevant popups, and also the magazine on sniper rifles thing just kind of irked me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
It's kinda strange that security plasmamen has no proper armor and you can just bully them with bottlesmashes. Literally.
Also suits had no wound armor for some reason, which considering that mold dies without hand kinda silly too.
And helmets just had no armor besides 1 melee armor.
Why It's Good For The Game
Plasmamen security won't die that easilly. I mean, still easy to kill them, but not that much.
Changelog
馃啈
balance: Security Plasmamen now have Security armor. No bullying them with bottlesmashes anymore.
/:cl: