Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

North Star Medbay Rework #75595

Merged
merged 7 commits into from May 29, 2023
Merged

Conversation

Cheshify
Copy link
Contributor

@Cheshify Cheshify commented May 22, 2023

About The Pull Request

Completely renovates the North Star Medbay to be more in line with what TG medbays require to operate. This also makes more of Virology's shutters stay open on roundstart, and makes sure that the abandoned medbay above the CMO office will actually spawn with reinforced plating.
f4

Basically nothing in the asylum or chem factory was changed.
There's now a maintenance route to access the morgue, useful for robotics.

Why It's Good For The Game

The original medbay was enjoyable but it couldn't handle everything TG had to throw at it. I think this rework may slightly detract from the strength of surgery rooms, but it makes up for it in aesthetics, passive roleplay space, and functionality, while still retaining much of the original's design.

Changelog

🆑
add: The North Star's medbay has been fully renovated.
fix: The CMO's office ceiling is now properly protected on the North Star.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. labels May 22, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@JohnFulpWillard
Copy link
Member

JohnFulpWillard commented May 22, 2023

If you can please make the coroner’s skeleton look like it’s watching over the surgery table because I wanted it to look like some surgery skeleton sidekick (which I couldn’t do on all maps)

@Cheshify
Copy link
Contributor Author

If you can please make the coroner’s skeleton look like it’s watching over the surgery table because I wanted it to look like some surgery skeleton sidekick (which I couldn’t do on all maps)

Abso-fucking-lutely that is very funny.

@Cheshify
Copy link
Contributor Author

Skellington Menace Increased
image

@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 23, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 23, 2023
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 25, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 25, 2023
@github-actions github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 27, 2023
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 28, 2023
@MMMiracles
Copy link
Contributor

image
pipe/wires that lead into the door, leftover from the original design

image
don't see an associated button for these shutters

image
overlapping wall mounts in patient will look poopy to our 10 AI players, probably should move one of them up a tile

image
pharmacy isn't actually connected to the power grid or distro, just the waste loop

paramedic dispatch lacks air alarm

chemistry, pharmacy, paramedic dispatch, front lobby, patient room, both surgery rooms, cryogenics, medical office, medical storage, psych office, break room lacks a fire alarm

fix that stuff and it should be good to merge

@Cheshify
Copy link
Contributor Author

Appreciate the review, requested changes have been made!

@MMMiracles MMMiracles merged commit bb402de into tgstation:master May 29, 2023
18 checks passed
comfyorange added a commit that referenced this pull request May 29, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants