Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly changes the colours of the oxygen and burn medkits #75792

Merged
merged 2 commits into from Jun 2, 2023

Conversation

Profakos
Copy link
Contributor

@Profakos Profakos commented Jun 1, 2023

About The Pull Request

The recent medkit changes made the Oxygen Medkits be the same colour as the regular medkits. As the specialized healing medkits have always stood out via their colour coding, I feel like i had to touch it up a bit to bring back that feature. They are now slighty less green, and lighter. However, as I wanted to keep them in the same palette range as the other medkits, I didn't do anything too drastic.

image

This PR also tweaks the burn medkit, by request, making its orange less red.

image

Here you can see the recoloured Oxygen medkit, with a general medkit as comparison.

Why It's Good For The Game

Its good for specialized medkits to stand out more, not just via their symbols. This would had to be done anyways in the future when the medibot sprites are updated.

By request, slightly lessens the Red in the orange of the burn medkit, preventing it from looking too similar to the pink of the brute medkit when looked at on highly saturated screens.

Changelog

🆑
image: Made the oxygen medkits different coloured from the general medkit colours, and tweaked the burn medkits to look a bit less orange
/:cl:

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Jun 1, 2023
@lessthnthree
Copy link
Contributor

Can you make burn more of a yellow as well? It's too close to brute.

@Profakos
Copy link
Contributor Author

Profakos commented Jun 1, 2023

Can you make burn more of a yellow as well? It's too close to brute.

Hm, I checked brute and its pink, which doesn't seem close to the orange to me, but the Advanced Medkit's shade of red is indeed very similar? I'll think about it.

@lessthnthree
Copy link
Contributor

lessthnthree commented Jun 1, 2023

Can you make burn more of a yellow as well? It's too close to brute.

Hm, I checked brute and its pink, which doesn't seem close to the orange to me, but the Advanced Medkit's shade of red is indeed very similar? I'll think about it.

At higher color saturations the pink and orange start to blend together. Less of a concern with advanced medkit as it's more of a rarity and not roundstart sitting next to the other medkits.

@Profakos
Copy link
Contributor Author

Profakos commented Jun 1, 2023

Aha, thank you, I will see if I can figure something out.

@Profakos
Copy link
Contributor Author

Profakos commented Jun 1, 2023

image
Would this slight yellowification work?

@lessthnthree
Copy link
Contributor

image Would this slight yellowification work?

Yeah, that's an improvement!

@Profakos
Copy link
Contributor Author

Profakos commented Jun 1, 2023

Alright, I have pushed the change.

@Profakos Profakos changed the title Slightly changes the colours of the oxygen medkits Slightly changes the colours of the oxygen and burn medkits Jun 1, 2023
@Twaticus Twaticus merged commit 928c107 into tgstation:master Jun 2, 2023
20 checks passed
comfyorange added a commit that referenced this pull request Jun 2, 2023
github-actions bot added a commit that referenced this pull request Jun 2, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Jun 2, 2023
…burn medkits (#6085)

Original PR: tgstation/tgstation#75792
-----

## About The Pull Request

The recent medkit changes made the Oxygen Medkits be the same colour as
the regular medkits. As the specialized healing medkits have always
stood out via their colour coding, I feel like i had to touch it up a
bit to bring back that feature. They are now slighty less green, and
lighter. However, as I wanted to keep them in the same palette range as
the other medkits, I didn't do anything too drastic.


![image](https://github.com/tgstation/tgstation/assets/2676196/84204ed3-e0a0-44c5-871f-f268df0e96b0)

This PR also tweaks the burn medkit, by request, making its orange less
red.


![image](https://github.com/tgstation/tgstation/assets/2676196/4ad74f01-b603-4fb2-8b80-a812600d50e3)


Here you can see the recoloured Oxygen medkit, with a general medkit as
comparison.

## Why It's Good For The Game

Its good for specialized medkits to stand out more, not just via their
symbols. This would had to be done anyways in the future when the
medibot sprites are updated.

By request, slightly lessens the Red in the orange of the burn medkit,
preventing it from looking too similar to the pink of the brute medkit
when looked at on highly saturated screens.

## Changelog

:cl:
image: Made the oxygen medkits different coloured from the general
medkit colours, and tweaked the burn medkits to look a bit less orange
/:cl:

---------

Co-authored-by: Profakos <profakos@gmail.com>
@Profakos Profakos deleted the oxygen-blues branch June 2, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants