Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Debug and Admin MODsuits now take a lot less time to (de)activate. #76261

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

Ghommie
Copy link
Member

@Ghommie Ghommie commented Jun 22, 2023

About The Pull Request

Read the title. An equivalent 'activation_step_time' variable has been added to the mod theme datum to accomplish that.

Why It's Good For The Game

Why do we have to wait over 10 seconds for a debug suit to activate or deactivate on top of everything else that comes with coding, programming, bugfixing etc? It now takes about 2 seconds to do so, which should be enough to notice the effects of modules such as the springlock anyway. The admin one takes 0.5 seconds, as it's by all means a better debug suit.

Changelog

🆑
admin: The Debug and Admin MODsuits now take a lot less time to (de)activate. 2 and 0.5 seconds respectively, compared to the default of 10s.
/:cl:

@Ghommie Ghommie requested a review from Fikou as a code owner June 22, 2023 19:30
@tgstation-server tgstation-server added the Administration As generous gods, we have deigned to throw the jannies a bone label Jun 22, 2023
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
@github-actions github-actions bot requested a review from Fikou June 22, 2023 20:13
@san7890 san7890 merged commit f2fc2fb into tgstation:master Jun 24, 2023
18 checks passed
github-actions bot added a commit that referenced this pull request Jun 24, 2023
comfyorange added a commit that referenced this pull request Jun 24, 2023
@Ghommie Ghommie deleted the Ghommie-tg292 branch June 24, 2023 02:26
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Jun 24, 2023
…s time to (de)activate. (#6413)

Original PR: tgstation/tgstation#76261
-----
## About The Pull Request
Read the title. An equivalent 'activation_step_time' variable has been
added to the mod theme datum to accomplish that.

## Why It's Good For The Game
Why do we have to wait over 10 seconds for a debug suit to activate or
deactivate on top of everything else that comes with coding,
programming, bugfixing etc? It now takes about 2 seconds to do so, which
should be enough to notice the effects of modules such as the springlock
anyway. The admin one takes 0.5 seconds, as it's by all means a better
debug suit.

## Changelog

:cl:
admin: The Debug and Admin MODsuits now take a lot less time to
(de)activate. 2 and 0.5 seconds respectively, compared to the default of
10s.
/:cl:

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration As generous gods, we have deigned to throw the jannies a bone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants