Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sprite for engi goggles is yellow and not green in meson mode #76647

Merged
merged 2 commits into from
Jul 10, 2023
Merged

The sprite for engi goggles is yellow and not green in meson mode #76647

merged 2 commits into from
Jul 10, 2023

Conversation

cnleth
Copy link
Contributor

@cnleth cnleth commented Jul 8, 2023

About The Pull Request

#76596 changed engi scanner goggles to be green in meson mode, but the vision tint was still yellow. Originally I wanted to make the tint green (#76630), but it seems that people like yellow engi mesons more, so I changed the sprite instead. I copied the glass part of atmos-thermal mode t-ray goggles onto the engi goggles.
Before:
trayson-meson-prev
After:
trayson-meson
Also atmos thermal imaging goggles are now green to avoid confusion

Why It's Good For The Game

Sprite color matches the vision tint

Changelog

🆑
image: Engineering scanner goggles are now yellow and not green when in meson mode
image: Atmospheric thermal imaging goggles are now green
/:cl:

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Jul 8, 2023
@Fikou
Copy link
Member

Fikou commented Jul 8, 2023

could you do the same thing to the atmospheric temp and shuttle goggles? the atmospheric ones look exactly like mesons after your change, and shuttle goggles look exactly like traitor thermals now

@cnleth
Copy link
Contributor Author

cnleth commented Jul 8, 2023

could you do the same thing to the atmospheric temp and shuttle goggles? the atmospheric ones look exactly like mesons after your change, and shuttle goggles look exactly like traitor thermals now

engi goggles and atmos goggles have a different thing (antenna?) on their frame
meson
atmos
Same thing for shuttle goggles, they have an antenna unlike thermals

@Youtubeboy139
Copy link
Contributor

Youtubeboy139 commented Jul 8, 2023

could you do the same thing to the atmospheric temp and shuttle goggles? the atmospheric ones look exactly like mesons after your change, and shuttle goggles look exactly like traitor thermals now

engi goggles and atmos goggles have a different thing (antenna?) on their frame meson atmos Same thing for shuttle goggles, they have an antenna unlike thermals

I just switched the colors for the trayson-atmospheric-thermal and trayson-meson goggles. I'd just switch them back to their original colors because the antenna difference is so small that it might confuse players.
Screenshot 2023-07-08 121147
TLDR Just make the one Green again and the other the Off Yellow color again.

@cnleth
Copy link
Contributor Author

cnleth commented Jul 8, 2023

Changed the atmos goggles to be green, as suggested
trayson-atmos-new

@Time-Green Time-Green merged commit 4169fc2 into tgstation:master Jul 10, 2023
20 checks passed
comfyorange added a commit that referenced this pull request Jul 10, 2023
github-actions bot added a commit that referenced this pull request Jul 10, 2023
@cnleth cnleth deleted the yellow-engi-goggles branch July 10, 2023 14:31
Onule pushed a commit to TaleStation/TaleStation that referenced this pull request Jul 10, 2023
…reen in meson mode (#6706)

Original PR: tgstation/tgstation#76647
-----
## About The Pull Request
#76596 changed engi scanner goggles to be green in meson mode, but the
vision tint was still yellow. Originally I wanted to make the tint green
(#76630), but it seems that people like yellow engi mesons more, so I
changed the sprite instead. I copied the glass part of atmos-thermal
mode t-ray goggles onto the engi goggles.
Before:

![trayson-meson-prev](https://github.com/tgstation/tgstation/assets/113535457/2069dfd9-3ba1-4a04-8623-6be28aa058b4)
After:

![trayson-meson](https://github.com/tgstation/tgstation/assets/113535457/5f9dbfa5-8d8e-4bc6-bc50-f4a39407084a)
Also atmos thermal imaging goggles are now green to avoid confusion
## Why It's Good For The Game
Sprite color matches the vision tint
## Changelog
:cl:
image: Engineering scanner goggles are now yellow and not green when in
meson mode
image: Atmospheric thermal imaging goggles are now green
/:cl:

---------

Co-authored-by: cnleth <113535457+cnleth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants