-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The sprite for engi goggles is yellow and not green in meson mode #76647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnleth
requested review from
Imaginos16,
Krysonism,
Twaticus and
Wallemations
as code owners
July 8, 2023 08:40
could you do the same thing to the atmospheric temp and shuttle goggles? the atmospheric ones look exactly like mesons after your change, and shuttle goggles look exactly like traitor thermals now |
Wallemations
approved these changes
Jul 8, 2023
comfyorange
added a commit
that referenced
this pull request
Jul 10, 2023
Onule
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jul 10, 2023
…reen in meson mode (#6706) Original PR: tgstation/tgstation#76647 ----- ## About The Pull Request #76596 changed engi scanner goggles to be green in meson mode, but the vision tint was still yellow. Originally I wanted to make the tint green (#76630), but it seems that people like yellow engi mesons more, so I changed the sprite instead. I copied the glass part of atmos-thermal mode t-ray goggles onto the engi goggles. Before: ![trayson-meson-prev](https://github.com/tgstation/tgstation/assets/113535457/2069dfd9-3ba1-4a04-8623-6be28aa058b4) After: ![trayson-meson](https://github.com/tgstation/tgstation/assets/113535457/5f9dbfa5-8d8e-4bc6-bc50-f4a39407084a) Also atmos thermal imaging goggles are now green to avoid confusion ## Why It's Good For The Game Sprite color matches the vision tint ## Changelog :cl: image: Engineering scanner goggles are now yellow and not green when in meson mode image: Atmospheric thermal imaging goggles are now green /:cl: --------- Co-authored-by: cnleth <113535457+cnleth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
#76596 changed engi scanner goggles to be green in meson mode, but the vision tint was still yellow. Originally I wanted to make the tint green (#76630), but it seems that people like yellow engi mesons more, so I changed the sprite instead. I copied the glass part of atmos-thermal mode t-ray goggles onto the engi goggles.
Before:
After:
Also atmos thermal imaging goggles are now green to avoid confusion
Why It's Good For The Game
Sprite color matches the vision tint
Changelog
🆑
image: Engineering scanner goggles are now yellow and not green when in meson mode
image: Atmospheric thermal imaging goggles are now green
/:cl: