New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO GBP] Music Request Credits changed to CKEY #76751
Conversation
I think adding no GBP for this is a smart idea, because its just something stupidly small |
People were trying to tell you why to use ckeys in the last PR, but I'll try to explain the reasons to you again. |
I know, i just have seen a few people who get upset from their CKEY being displayed to others and just eh i dunno, i was trying to appease both sides since i really personally dont care either way. But adding onto this with the week that my change was merged i have also seen people questioning why it shows character name too and just theres no winning whatever i do so i think just flat out doing CKEY is fine |
This never should have been mob name and always ckey regardless. |
…6750) Original PR: tgstation/tgstation#76751 ----- ## About The Pull Request I was requested by one of the game admins over in the TG discord to change the credit from character name to ckey. ## Why It's Good For The Game It's mostly a OOC thing, personally I don't know of a good enough reason to put here other than its a PR someone requested of me. ## Changelog :cl: fix: Music Request Credit shows CKEY instead of character name /:cl: --------- Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
I was the one who originally requested this and did so because I played a song where the person wanted to be credited and it said "Wraith (539) requested..." which had the lovely effect of telling literally everyone there was a cult. Thankfully, the cult was already exceedingly loud at this point, but this PR fixes the issue wholesale. Thank you for doing this. |
About The Pull Request
I was requested by one of the game admins over in the TG discord to change the credit from character name to ckey.
Why It's Good For The Game
It's mostly a OOC thing, personally I don't know of a good enough reason to put here other than its a PR someone requested of me.
Changelog
🆑
fix: Music Request Credit shows CKEY instead of character name
/:cl: