New Mech UI and equipment refactor

[MTandi]

About The Pull Request

Made a new UI and refactored some mech code in the process.

Fixes #66048
Fixes #77051
Fixes #65958 ??? if it was broken
Fixes #73051 - see details below
Fixes other undocumented things, see changelog.

Why It's Good For The Game

The UI was too bulky and Mechs were too complex for no reason.
Now they follow some general rules shared between other SS13 machinery, and there is less magic happening under the hood.

Detailed Changes

New Mech UI, Air Tank and Radio as separate modules

Previous UI for comparison:

Previously mechs came with radio pre-installed and air canisters magically pre-filled with air even when you build one in fab.
Radio and Air Tanks are now both utility modules that are optional to install. Gas RCS thrusters still require Air Tank module to operate.

This made the Mechs more barebones when built, giving you only the basic functionality.

To compensate this change, all mechs got two extra utility module slots.

All other modules got new UI. And ore box now shows the list of ores inside.

Mounted Radio

Works as a normal radio, but with subspace transmission. Available from the basic mech research node and can be printed in fab.

Cabin Sealing

To compensate for the lack of air tank by default, mechs with enclosed cabin (e.g. all except Ripley) got an ability to toggle cabin exposure to the outside air. Exiting the mech makes cabin air automatically exposed.

When you seal the cabin, it traps some of the outside air inside the cabin and you can breathe with this air to perform a short space trips. But the oxygen will run out quickly and CO2 will build up.

Sealing the cabin in space will make the cabin filled with vacuum, and it will stay there until you return to air environment and unseal the cabin, letting the breathable air to enter. There are temperature and pressure sensors that turn yellow/red when the corresponding warning thresholds are reached.

You could also use personal internals in combination with cabin sealing for long space travels, so Air Tank is completely optional now and mostly needed when you need RCS thruster.

RCS thrusters

They are now available earlier in tech tree and consume reasonable amount of air (5 times more than human jetpacks), and they don't work without Mounted Air Tank, unless it's an Ion thruster variant.

Mounted Air Tank

Available from the basic mech research node and can be printed in fab. Built model comes empty, and syndicate mechs come with one full of oxygen.

Can be switched to pressurize or not pressurize the cabin. Releases gas only when the cabin is sealed shut. Starts releasing automatically, but can be toggled to not release if you want to use it just as a portable canister.

Cabin pressure can now be configured in the module UI instead of Maintenance UI.

Can be attached to a pipe network when the mech is parked above a connection port.

Comes with a pump that works similarly to the portable pump. It lets you vent the air tank contents outside, or suck air from the room to fill the air tank. Intended to provide an ability to fill the air tank without the need to bother with pipes.

Also has gas sensors that display gas mix data of the tank and the cabin (when sealed).

Stock part changes

All mechs now require a servo motor and they reduce mech movement power consumption instead of scanning module.

Scanning modules are optional for mech operation (still required to build) and the lack of one disables the following UI elements:

• Display of mech integrity (you can still see the alerts or examine the mech to get rough idea)
• Display of mech status on internal damage (and you can't repair what you can't diagnose)

The rating of scanning module doesn't have any effect as of now.

Cargo mech comes without it roundstart.

Capacitors now also reduce light power usage and raise the overclocking temperature thresholds (see below).

Maintenance

Maintenance UI removed, and its logic migrated to other places.

Access modification now managed inside the mech, and anyone who can control the mech, can adjust the access in the same way as they can set DNA key.

To open the maintenance panel you just need a screwdriver. It is instant when the mech is empty and it has a 5 second delay when there is an occupant to avoid in-combat hacking and part removal. It will alert the occupant that someone is trying to tinker with their mech.

Once the panel is open, you can see the part ratings:

With open panel you can hack the mech wires (roboticists can now see them):

There are wires for:

• Enabling/Disabling ID and DNA locks
• Toggling mech lights
• Toggling mech circuits malfunction (battery drain, sparks)
• Toggling mech equipment malfunction (to repair after EMP or cause EMP-like effect, disarming mech)
• 3 dud wires that do nothing

The hacker may be shocked if the mech power cell allows.

When the panel is open and the user has access to the mech, they can remove parts with a crowbar:

Hitting the mech with an ID from outside now toggles the ID Lock on/off if the ID has sufficient access.

Power consumption and overclocking

Rebalanced mech power consumption. T4 parts were not working in Syndicate Mechs, as their effect was not calculated until you manipulate parts manually. Constructed mechs with t1 parts even had their energy drain reduced with upgrade to t1.

Now all mechs apply their base step power usage correctly don't ignore the stock parts.

Servo tier now reduces base power consumption by 0% at t1, 50% at t2, 33% at t3 and 25% at t4
Capacitor tier now reduces base power consumption of mele attacks, phasing and light by the same amounts.

Gygax leg actuators overload replaced with mech overclocking. Any mech can be overclocked by hacking wires, but only Gygax has a button for toggling it from the Cabin.

Now there is an overclock coefficient. 1.5 for Gygax and other mechs, 2 for Dark Gygax.

When overclocked, mechs moves N times faster, but consumes N times more power.

While overclocked, mech heats up every second, regardless of movement, and starts receiving internal and integrity damage after a certain temperature threshold. The chance is 0% at the threshold, and 100% at thresholds * 2. The roll happens every tick. Capacitor upgrades this threshold, letting you overclock safely for longer periods.

When you stop overclock, the temperature goes back down.

Other changes and fixes

Concealed weapon bay now doesn't show up when you examine the mech, so it's actually concealed now.

New radio module can properly change its frequency, as it didn't work for previous radio.

Launcher type weapons were ignoring cooldowns and power usage, so you could spam explosive banana peals, while they should have a 2 second cooldown:

Now this is fixed and all launcher type weapons properly use power and have their cooldowns working.
And now they have the kickback effect working (when it pushes you in the opposite direction in zero gravity on throw).

Thermoregulator now heats/cools considering heat capacity instead of adding/reducing flat 10 degrees. So you can heat up cabin air quicker if the pressure is low.

There were some other sloppy mistakes in mech code, like some functions returning too early, blocking other functionality unintentionally. Fixed these and made some other minor changes and improvements.

Changelog

🆑
refactor: Refactored Mech UI
refactor: Refactored mech radio into a utility module, adding extra slot to all mechs
refactor: Refactored mech air tank into a utility module with an air pump, adding extra slot to all mechs
refactor: Refactored mech cabin air - there is now a button to seal or unseal cabin to make it airtight or exchanging gases with the environment
refactor: Removed mech maintenance UI Access is set in mech UI, and parts are ejected with a crowbar
add: Mech now has wires and can be hacked
qol: Roboticists now can see MOD suit and mech wires
add: Mechs now require servo motor stock part and it affects movement power usage instead of scanning module
add: Scanning module absence doesnt block mech movement and hides some UI data instead. Big Bess starts without one.
qol: Hitting mech with ID card now toggles ID lock on/off if the card has required access
fix: Fixed concealed weapon bay not being concealed on mech examine
fix: Fixed mech radio not changing frequency
fix: Fixed mech launcher type weapons ignoring specified cooldown
fix: Fixed mech launcher type weapons not using specified power amount
fix: Fixed mech temperature regulator ignoring gas heat capacity
fix: Fixed mech stopping processing other things while not heating internal air
fix: Fixed mech being able to leave transit tube in transit
fix: Fixed mech internal damage flags working incorrectly
fix: Fixed Gygax leg overloading being useless
fix: Fixed mechs ignoring their stock parts on creation. Syndicate mechs now stronger against lasers and consume less energy on move. Upgrading from tier 1 to tier 2 doesn't make mech consume MORE energy than before the upgrade.
balance: Rebalanced mech energy drain with part upgrades. Base energy drain reduced by 50%, 33%, 25% with upgrades and applies to movement (Servo rating), phasing, punching, light (Capacitor rating).
balance: Hydraulic clamp now can force open airlocks
balance: Made mech RCS pack consume reasonable amount of gas
code: Fixed some other minor bugs and made some minor changes in the mech code
/:cl:

[MTandi]

There is a bug related to stock parts loading on mech construction completion / initialization. Marking as draft until I resolve it.

[SyncIt21]

There is a bug related to stock parts loading on mech construction completion / initialization. Marking as draft until I resolve it.

You could create a map load variant which has a flag say init_stock_parts = TRUE and you call CheckParts() , add_servo() etc only when this flag is true. By default this flag would be false of course

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself