Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds kids food, food that kids like #78980

Closed
wants to merge 6 commits into from
Closed

adds kids food, food that kids like #78980

wants to merge 6 commits into from

Conversation

Jackal-boop
Copy link
Contributor

@Jackal-boop Jackal-boop commented Oct 13, 2023 •
edited by github-actions bot

About The Pull Request

adds a kids menu chef box
the kids type food flag
adds the kids type food flag to some foods that kids particularly enjoy
underage characters automatically like kids food

Why It's Good For The Game

kids get to enjoy their appy slices and french fries from mc donalds

Changelog

馃啈
add: kids food, kids menu box, underage characters have taken an affinity to some foods
/:cl:

@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Oct 13, 2023
@IndieanaJones
Copy link
Contributor

17 year old powercreep

@Jackal-boop
Copy link
Contributor Author

17 year old powercreep

oranges forced my hand im sorry

Ghommie
Ghommie requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Ghommie Ghommie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgot to add the define foremost. 馃槢

code/modules/jobs/job_types/_job.dm

if (human.age < AGE_MINOR)
var/obj/item/organ/internal/tongue/tongue = H.get_organ_slot(ORGAN_SLOT_TONGUE)
tongue.liked_foodtypes = KIDS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how this affect the tongue rather than being part of carbon/get_liked_foodtypes(). It's less reliable.

@Jackal-boop
Copy link
Contributor Author

this was all done as a web edit on a shitty lenovo laptop. will get this into VScode on my PC in a bit

MrMelbert
MrMelbert requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@MrMelbert MrMelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want anymore "only used on a few items for a single interaction" foodtypes, since we're running out of space for them. Find another way to accomplish this, such as via traits.

@MrMelbert MrMelbert marked this pull request as draft October 13, 2023 19:13
@Jackal-boop
Copy link
Contributor Author

I don't want anymore "only used on a few items for a single interaction" foodtypes, since we're running out of space for them. Find another way to accomplish this, such as via traits.

whats the difference between a flag and a trait

@Ghommie
Copy link
Member

Ghommie commented Oct 13, 2023

A trait is a string of text contained within a list calld datum_traits, that every datum has, you can check __DEFINES/traits.dm for a list of various traits and the macros used to add, remove and check for them.

JohnFulpWillard
JohnFulpWillard reviewed Oct 13, 2023
View reviewed changes
code/game/objects/items/food/misc.dm
@@ -27,7 +27,7 @@
/datum/reagent/consumable/nutriment = 1,
)
tastes = list("apple" = 1)
foodtypes = FRUIT
foodtypes = FRUIT | KIDS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love eating kids

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Billionaires approve this message.

@Jackal-boop
Copy link
Contributor Author

will close this for now and learn more about traits and do it that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnFulpWillard JohnFulpWillard JohnFulpWillard left review comments

@Xander3359 Xander3359 Xander3359 left review comments

@Ghommie Ghommie Ghommie requested changes

@MrMelbert MrMelbert MrMelbert requested changes

Assignees
No one assigned
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Jackal-boop @IndieanaJones @Ghommie @MrMelbert @JohnFulpWillard @Xander3359 @tgstation-server